Tabora loading issue when returning to planet

[evilwb]

I happened to catch a video where this group ran into the following issue on Tabora:
https://youtu.be/3vGKrM1hXQs?t=8568 (left screen at 2:22:50)

Ratchet spawns near ship but the level isn't loaded so he just falls into the void and dies on repeat.

• It happened on a return visit to Tabora.
• It continued to happen after a complete emulator reset and load from save file.
• Doesn't have any wrench upgrades collected.
• Occurred on either version 0.5.0 or 0.5.1 (not sure).

I saw this issue crop on Tabora a long time ago during development but I wasn't sure what exactly caused it. I though it might be caused by revisiting Tabora without the wrench upgrade, but I tested that case when reviewing the wrench randomization PR and it did not happen. Maybe it's that but inconsistent.

[Dinopony]

It already happened to me once when using my fully complete vanilla save to go to every planet and see if text handling was working properly.

I thought it was caused by some version mismatch, since my save was initially done on 2.0 and dev happens on 1.1, but it appears that it's not the case.

I always found Angela's cutscene at the end of the caves very long to load for what it is, I suspect that it might be where the rest of the level loads as well. Or maybe it is related to the glider checkpoint removal?

[Dinopony]

I watched the playthrough, and the unusual thing I'm seeing is that wrench upgrade checkpoint was triggered without having Heli-Pack (using first person mode).

Maybe we should try the following first:

• Start a run and go to Tabora
• Reach the end of the caves right before Angela's cutscene
• Go to Slim Shack
• Go back to Tabora, and see what happens

[Dinopony]

Hmm, so I'm a bit lost here. I've tried many things attempting to reproduce this, but no luck.

• Having Wrench Lv1 / Lv2 / Lv3
• Having Glider / not having glider
• Having watched wrench upgrade cutscene or not on first visit

I tried many combinations of those (if not all), and none triggered the issue.
I'd guess the wrench upgrade cutscene is not involved, since they get it in the YouTube video on first visit while leone9304 on Discord didn't take in on first visit.

On the YouTube video:

• they still have Lv1 wrench when the bug occurs
• they have the glider when the bug occurs

[Dinopony]

I noticed that my first patch for TABORA_CONTROLLER_FUNC butchers the function with 16 consecutive NOPs.
Some of the instructions removed were initializing sX registers that were used much later (not sure where though, it's hard to track).
I suspect there is randomness to that issue, maybe caused by leftover values in those sX registers.

I'll test a fix tomorrow and if the modified part still works as intended, I'll push it and we'll see if the issue reappears.

[liolu]

I confirm I had the same problem, I did the cave then the cistaux without going to see the guy, the bolt the glider with the charge boots, then when recharging to exit the glinder I had the bug

[Dinopony]

Hypothetic fix was merged, I'm not closing until we make sure it was fixed

[Dinopony]

No reports yet of it happening again, we'll reopen this issue if the problem reappears.