Skip to content

Commit 231b742

Browse files
[deploy] disable zipping of assets by default. Addresses #93.
1 parent b6b9f54 commit 231b742

File tree

9 files changed

+15
-7
lines changed

9 files changed

+15
-7
lines changed

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ As a benefit, this implementation is cross-platform (x64 linux/win are tested, p
2323

2424
### Changelog
2525

26+
#### Changes in version 4.X.Y
27+
28+
The default value for zipping minified assets has changed from `true` to `false`. This has no effect to pre-existing configuration files.
29+
The change was made in anticipation of a new feature in the net9.0 SDK.
30+
2631
#### Changes in version 3.8.14
2732

2833
Support for net7.0 was dropped. The nupkg file was getting outrageously large due to dependencies and duplication across the target frameworks.

Tests_WebCompiler/AutoPipelineRealJustZipTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ public void CreatePipeline()
1515
{
1616
Minifiers = new MinificationSettings
1717
{
18+
GZip = true,
1819
Css = new CssMinifySettings
1920
{
2021
TermSemicolons = false

Tests_WebCompiler/AutoPipelineRealTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ public void CreatePipeline()
1515
{
1616
Minifiers = new MinificationSettings
1717
{
18+
GZip = true,
1819
Css = new CssMinifySettings
1920
{
2021
TermSemicolons = true

Tests_WebCompiler/AutoPipelineScssTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ public void CreatePipeline()
1515
{
1616
Minifiers = new MinificationSettings
1717
{
18+
GZip = true,
1819
Css = new CssMinifySettings
1920
{
2021
TermSemicolons = false

Tests_WebCompiler/Tests_WebCompiler.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<RootNamespace>Tests_WebCompiler</RootNamespace>
77
</PropertyGroup>
88
<ItemGroup>
9-
<PackageReference Include="NUnit" Version="4.2.1" />
9+
<PackageReference Include="NUnit" Version="4.2.2" />
1010
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0">
1111
<PrivateAssets>all</PrivateAssets>
1212
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

Tests_WebCompiler/WholeProgramTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ public void OutputAtSamePlace()
353353
}
354354
}
355355
DeleteTemporaryFiles();
356-
Assert.That(Program.Main("../../../TestCases/Js/test.js", "../../../TestCases/MinCss/site.min.css", "-r", "../../../TestCases/Css"), Is.EqualTo(0));
356+
Assert.That(Program.Main("../../../TestCases/Js/test.js", "../../../TestCases/MinCss/site.min.css", "-r", "../../../TestCases/Css", "-z", "enable"), Is.EqualTo(0));
357357
foreach (var output_file in output_files)
358358
{
359359
Assert.That(File.Exists(output_file), $"Output {output_file} should exist");
@@ -397,7 +397,7 @@ public void OutputAtSamePlaceUnnecessarilySpecified()
397397
}
398398
}
399399
DeleteTemporaryFiles();
400-
Assert.That(Program.Main("../../../TestCases/Js/test.js", "../../../TestCases/MinCss/site.min.css", "-r", "../../../TestCases/Css", "-o", "../../../TestCases"), Is.EqualTo(0));
400+
Assert.That(Program.Main("../../../TestCases/Js/test.js", "../../../TestCases/MinCss/site.min.css", "-r", "../../../TestCases/Css", "-o", "../../../TestCases", "-z", "enable"), Is.EqualTo(0));
401401
foreach (var output_file in output_files)
402402
{
403403
Assert.That(File.Exists(output_file), $"Output {output_file} should exist");
@@ -446,7 +446,7 @@ public void OutputWithPreservation()
446446
}
447447
}
448448
DeleteTemporaryFiles();
449-
Assert.That(Program.Main("../../../TestCases/Js/test.js", "../../../TestCases/MinCss/site.min.css", "-r", "../../../TestCases/Css", "-o", "../../../output/path"), Is.EqualTo(0));
449+
Assert.That(Program.Main("../../../TestCases/Js/test.js", "../../../TestCases/MinCss/site.min.css", "-r", "../../../TestCases/Css", "-o", "../../../output/path", "-z", "enable"), Is.EqualTo(0));
450450
foreach (var output_file in output_files)
451451
{
452452
Assert.That(File.Exists(output_file), $"Output {output_file} should exist");

WebCompiler/Configuration/MinificationSettings.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ namespace WebCompiler.Configuration
44
{
55
public class MinificationSettings
66
{
7-
public bool GZip { get; set; } = true;
7+
public bool GZip { get; set; } = false;
88
public bool Enabled { get; set; } = true;
99
public CssMinifySettings Css { get; set; } = new CssMinifySettings();
1010
public JavaScriptMinifySettings Javascript { get; set; } = new JavaScriptMinifySettings();

WebCompiler/WebCompiler.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
</PropertyGroup>
1111
<ItemGroup>
1212
<PackageReference Include="AutoprefixerHost" Version="3.0.36" />
13-
<PackageReference Include="DartSassHost" Version="1.0.13" />
13+
<PackageReference Include="DartSassHost" Version="1.0.14" />
1414
<PackageReference Include="JavaScriptEngineSwitcher.V8" Version="3.24.2" />
1515
<PackageReference Include="Microsoft.ClearScript.V8.Native.win-x86" Version="7.4.5" />
1616
<PackageReference Include="Microsoft.ClearScript.V8.Native.win-x64" Version="7.4.5" />

WebCompiler/package.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<!--PackageId, Version-->
2121
<PropertyGroup>
2222
<PackageId>Excubo.WebCompiler</PackageId>
23-
<VersionPrefix>3.9.1</VersionPrefix>
23+
<VersionPrefix>4.0.0</VersionPrefix>
2424
<!--<VersionSuffix>preview.1</VersionSuffix>-->
2525
</PropertyGroup>
2626
<!--Self Include-->

0 commit comments

Comments
 (0)