Multiplayer engine hide player mesh while skin is active. Fixes #179.

Adrian Biedrzycki · Adrian Biedrzycki · commit 0561e3705149 · 2017-10-14T07:16:18.000-07:00
diff --git a/core/engines/multiplayer/client.js b/core/engines/multiplayer/client.js
@@ -174,11 +174,16 @@ class Multiplayer {
               this.remotePlayerSkinMeshes.delete(oldSkinMesh);
             }
 
+            const oldPlayerMesh = this.remotePlayerMeshes.get(n);
             if (skinImgBuffer) {
               const newSkinImg = _makeImg(skinImgBuffer, 64, 64);
               const newSkinMesh = skinUtils.makePlayerMesh(newSkinImg);
               scene.add(newSkinMesh);
               this.remotePlayerSkinMeshes.set(n, newSkinMesh);
+
+              oldPlayerMesh.visible = false;
+            } else {
+              oldPlayerMesh.visible = true;
             }
           }
 

Original file line number	Diff line number	Diff line change
`@@ -174,11 +174,16 @@ class Multiplayer {`
`174`	`174`	`this.remotePlayerSkinMeshes.delete(oldSkinMesh);`
`175`	`175`	`}`
`176`	`176`
	`177`	`+ const oldPlayerMesh = this.remotePlayerMeshes.get(n);`
`177`	`178`	`if (skinImgBuffer) {`
`178`	`179`	`const newSkinImg = _makeImg(skinImgBuffer, 64, 64);`
`179`	`180`	`const newSkinMesh = skinUtils.makePlayerMesh(newSkinImg);`
`180`	`181`	`scene.add(newSkinMesh);`
`181`	`182`	`this.remotePlayerSkinMeshes.set(n, newSkinMesh);`
	`183`	`+`
	`184`	`+ oldPlayerMesh.visible = false;`
	`185`	`+ } else {`
	`186`	`+ oldPlayerMesh.visible = true;`
`182`	`187`	`}`
`183`	`188`	`}`
`184`	`189`