Fix

Author: danog

src/describe/abi.rs

@@ -32,7 +32,7 @@ impl<T> Deref for Vec<T> {
 
 impl<T> Drop for Vec<T> {
     fn drop(&mut self) {
-        unsafe { Box::from_raw(std::ptr::slice_from_raw_parts_mut(self.ptr, self.len)) };
+        unsafe { let _ = Box::from_raw(std::ptr::slice_from_raw_parts_mut(self.ptr, self.len)); };
     }
 }
 

src/describe/stub.rs

@@ -52,7 +52,7 @@ impl ToStub for Module {
         // Inserts a value into the entries hashmap. Takes a key and an entry, creating
         // the internal vector if it doesn't already exist.
         let mut insert = |ns, entry| {
-            let bucket = entries.entry(ns).or_insert_with(StdVec::new);
+            let bucket = entries.entry(ns).or_default();
             bucket.push(entry);
         };
 

src/types/array.rs

@@ -768,7 +768,7 @@ impl<'a> FromZval<'a> for &'a ZendHashTable {
 }
 
 ///////////////////////////////////////////
-//// HashMap
+/// HashMap
 ///////////////////////////////////////////
 
 impl<'a, V> TryFrom<&'a ZendHashTable> for HashMap<String, V>
@@ -837,7 +837,7 @@ where
 }
 
 ///////////////////////////////////////////
-//// Vec
+/// Vec
 ///////////////////////////////////////////
 
 impl<'a, T> TryFrom<&'a ZendHashTable> for Vec<T>

src/zend/class.rs

@@ -34,6 +34,7 @@ impl ClassEntry {
     /// # Panics
     ///
     /// Panics when allocating memory for the new object fails.
+    #[allow(clippy::new_ret_no_self)]
     pub fn new(&self) -> ZBox<ZendObject> {
         ZendObject::new(self)
     }

src/zend/function.rs

@@ -56,11 +56,11 @@ impl Function {
             if res.is_null() {
                 return None;
             }
-            return Some(*res);
+            Some(*res)
         }
     }
     pub fn try_from_method(class: &str, name: &str) -> Option<Self> {
-        return match ClassEntry::try_find(class) {
+        match ClassEntry::try_find(class) {
             None => None,
             Some(ce) => unsafe {
                 let res = zend_hash_str_find_ptr_lc(
@@ -71,9 +71,9 @@ impl Function {
                 if res.is_null() {
                     return None;
                 }
-                return Some(*res);
+                Some(*res)
             },
-        };
+        }
     }
 
     pub fn from_function(name: &str) -> Self {