Merge pull request #143 from TobiasBengtsson/fix-clippy-useless-transmute

Fix clippy errors in nightly - useless transmute, useless ref-deref in Windows build

Author: TobiasBengtsson

src/builders/class.rs

@@ -257,7 +257,13 @@ impl ClassBuilder {
         }
 
         for iface in self.interfaces {
-            unsafe { zend_do_implement_interface(class, std::mem::transmute(iface)) };
+            unsafe {
+                zend_do_implement_interface(
+                    class,
+                    iface as *const crate::ffi::_zend_class_entry
+                        as *mut crate::ffi::_zend_class_entry,
+                )
+            };
         }
 
         for (name, mut default, flags) in self.properties {

src/types/callable.rs

@@ -115,7 +115,7 @@ impl<'a> ZendCallable<'a> {
         let result = unsafe {
             _call_user_function_impl(
                 std::ptr::null_mut(),
-                std::mem::transmute(self.0.as_ref()),
+                self.0.as_ref() as *const crate::ffi::_zval_struct as *mut crate::ffi::_zval_struct,
                 &mut retval,
                 len as _,
                 packed.as_ptr() as *mut _,

windows_build.rs

@@ -70,7 +70,7 @@ impl<'a> PHPProvider<'a> for Provider<'a> {
         // this so we need to add it manually.
         let php_lib_name = self.get_php_lib_name()?;
         for line in bindings.lines() {
-            match &*line {
+            match line {
                 "extern \"C\" {" | "extern \"fastcall\" {" => {
                     writeln!(writer, "#[link(name = \"{}\")]", php_lib_name)?;
                 }