From 26d65475805731e695200e3ac0ca59703d1379b8 Mon Sep 17 00:00:00 2001 From: Daniel Abad Cambronero Date: Fri, 23 Jun 2017 12:15:04 +0200 Subject: [PATCH 1/2] Change attributes visibility to allow proper inheritance of this class and the possibility to manage the construct of it Increase gitignore coverage deleted idea --- .gitignore | 6 ++++++ src/AppNexusClient.php | 10 +++++----- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/.gitignore b/.gitignore index c49a5d8..471c8e4 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,9 @@ vendor/ composer.lock phpunit.xml + +# Ides +.idea* + +#OS +.DS_Store diff --git a/src/AppNexusClient.php b/src/AppNexusClient.php index 13ab099..7cfc9e5 100644 --- a/src/AppNexusClient.php +++ b/src/AppNexusClient.php @@ -3,11 +3,11 @@ class AppNexusClient { - private $http; - private $host; - private $username; - private $password; - private $tokenStorage; + protected $http; + protected $host; + protected $username; + protected $password; + protected $tokenStorage; /** * __construct From ddff9ac33b6a099af456928e8bae94883a299f78 Mon Sep 17 00:00:00 2001 From: Daniel Abad Cambronero Date: Sat, 24 Jun 2017 10:18:43 +0200 Subject: [PATCH 2/2] remove system ignored files and limit visibility of attributes --- .gitignore | 6 ------ src/AppNexusClient.php | 8 ++++---- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/.gitignore b/.gitignore index 471c8e4..c49a5d8 100644 --- a/.gitignore +++ b/.gitignore @@ -1,9 +1,3 @@ vendor/ composer.lock phpunit.xml - -# Ides -.idea* - -#OS -.DS_Store diff --git a/src/AppNexusClient.php b/src/AppNexusClient.php index 7cfc9e5..a82bec0 100644 --- a/src/AppNexusClient.php +++ b/src/AppNexusClient.php @@ -4,10 +4,10 @@ class AppNexusClient { protected $http; - protected $host; - protected $username; - protected $password; - protected $tokenStorage; + private $host; + private $username; + private $password; + private $tokenStorage; /** * __construct