From 3fd6dac94aec8f51a09f8d9717135166753097cc Mon Sep 17 00:00:00 2001 From: dzarista Date: Mon, 2 Mar 2026 20:52:37 +0000 Subject: [PATCH 1/2] expected darwin idprom errors --- fboss/platform/platform_manager/ExplorationErrors.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fboss/platform/platform_manager/ExplorationErrors.cpp b/fboss/platform/platform_manager/ExplorationErrors.cpp index 700802767ef89..5051a3661462a 100644 --- a/fboss/platform/platform_manager/ExplorationErrors.cpp +++ b/fboss/platform/platform_manager/ExplorationErrors.cpp @@ -45,6 +45,13 @@ bool isExpectedError( } } + if (*platformConfig.platformName() == "DARWIN" && + errorType == ExplorationErrorType::IDPROM_READ && + (devicePath == "/RACKMON_SLOT@0/[IDPROM]" || + devicePath == "/PEM_SLOT@0/[IDPROM]")) { + return true; + } + return false; } From 1dfa833201821762884ecee35b18c3efff8bf0dd Mon Sep 17 00:00:00 2001 From: Daniel Zhu Date: Wed, 4 Mar 2026 13:30:53 -0600 Subject: [PATCH 2/2] Add explanation comments --- fboss/platform/platform_manager/ExplorationErrors.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fboss/platform/platform_manager/ExplorationErrors.cpp b/fboss/platform/platform_manager/ExplorationErrors.cpp index 5051a3661462a..5a5cf471375da 100644 --- a/fboss/platform/platform_manager/ExplorationErrors.cpp +++ b/fboss/platform/platform_manager/ExplorationErrors.cpp @@ -45,6 +45,8 @@ bool isExpectedError( } } + // These idproms do not support Meta EEPROM format, but can still provide + // useful info through WeutilDarwin if (*platformConfig.platformName() == "DARWIN" && errorType == ExplorationErrorType::IDPROM_READ && (devicePath == "/RACKMON_SLOT@0/[IDPROM]" ||