From cd2f89ec2e53bd1ea7e39a5a6f7c42444fed733f Mon Sep 17 00:00:00 2001 From: jynxio Date: Wed, 3 Dec 2025 02:49:32 +0800 Subject: [PATCH 1/2] [compiler] Fix set-state-in-effect validation for React.useEffect --- .../src/Validation/ValidateNoSetStateInEffects.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/packages/babel-plugin-react-compiler/src/Validation/ValidateNoSetStateInEffects.ts b/compiler/packages/babel-plugin-react-compiler/src/Validation/ValidateNoSetStateInEffects.ts index 86070e2973e..8e9668ccd3e 100644 --- a/compiler/packages/babel-plugin-react-compiler/src/Validation/ValidateNoSetStateInEffects.ts +++ b/compiler/packages/babel-plugin-react-compiler/src/Validation/ValidateNoSetStateInEffects.ts @@ -97,7 +97,7 @@ export function validateNoSetStateInEffects( case 'CallExpression': { const callee = instr.value.kind === 'MethodCall' - ? instr.value.receiver + ? instr.value.property : instr.value.callee; if (isUseEffectEventType(callee.identifier)) { From 93c64c963636b8e144eaf75a4fb5c54c46ae6941 Mon Sep 17 00:00:00 2001 From: jynxio Date: Wed, 3 Dec 2025 02:50:01 +0800 Subject: [PATCH 2/2] [compiler] Add fixture for React.useEffect in set-state-in-effect validation --- .../invalid-setState-in-useEffect.expect.md | 33 +++++++++++++++---- .../compiler/invalid-setState-in-useEffect.js | 8 +++-- 2 files changed, 32 insertions(+), 9 deletions(-) diff --git a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/invalid-setState-in-useEffect.expect.md b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/invalid-setState-in-useEffect.expect.md index 3c3a5a8053a..66814899be0 100644 --- a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/invalid-setState-in-useEffect.expect.md +++ b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/invalid-setState-in-useEffect.expect.md @@ -3,14 +3,18 @@ ```javascript // @loggerTestOnly @validateNoSetStateInEffects -import {useEffect, useState} from 'react'; +import React, {useEffect, useState} from 'react'; function Component() { const [state, setState] = useState(0); + const [state2, setState2] = React.useState(0); useEffect(() => { setState(s => s + 1); }); - return state; + React.useEffect(() => { + setState2(s => s + 1); + }); + return state + state2; } ``` @@ -19,11 +23,12 @@ function Component() { ```javascript import { c as _c } from "react/compiler-runtime"; // @loggerTestOnly @validateNoSetStateInEffects -import { useEffect, useState } from "react"; +import React, { useEffect, useState } from "react"; function Component() { - const $ = _c(1); + const $ = _c(2); const [state, setState] = useState(0); + const [state2, setState2] = React.useState(0); let t0; if ($[0] === Symbol.for("react.memo_cache_sentinel")) { t0 = () => { @@ -34,7 +39,20 @@ function Component() { t0 = $[0]; } useEffect(t0); - return state; + let t1; + if ($[1] === Symbol.for("react.memo_cache_sentinel")) { + t1 = () => { + setState2(_temp2); + }; + $[1] = t1; + } else { + t1 = $[1]; + } + React.useEffect(t1); + return state + state2; +} +function _temp2(s_0) { + return s_0 + 1; } function _temp(s) { return s + 1; @@ -45,8 +63,9 @@ function _temp(s) { ## Logs ``` -{"kind":"CompileError","detail":{"options":{"category":"EffectSetState","reason":"Calling setState synchronously within an effect can trigger cascading renders","description":"Effects are intended to synchronize state between React and external systems such as manually updating the DOM, state management libraries, or other platform APIs. In general, the body of an effect should do one or both of the following:\n* Update external systems with the latest state from React.\n* Subscribe for updates from some external system, calling setState in a callback function when external state changes.\n\nCalling setState synchronously within an effect body causes cascading renders that can hurt performance, and is not recommended. (https://react.dev/learn/you-might-not-need-an-effect)","suggestions":null,"details":[{"kind":"error","loc":{"start":{"line":7,"column":4,"index":180},"end":{"line":7,"column":12,"index":188},"filename":"invalid-setState-in-useEffect.ts","identifierName":"setState"},"message":"Avoid calling setState() directly within an effect"}]}},"fnLoc":null} -{"kind":"CompileSuccess","fnLoc":{"start":{"line":4,"column":0,"index":92},"end":{"line":10,"column":1,"index":225},"filename":"invalid-setState-in-useEffect.ts"},"fnName":"Component","memoSlots":1,"memoBlocks":1,"memoValues":1,"prunedMemoBlocks":0,"prunedMemoValues":0} +{"kind":"CompileError","detail":{"options":{"category":"EffectSetState","reason":"Calling setState synchronously within an effect can trigger cascading renders","description":"Effects are intended to synchronize state between React and external systems such as manually updating the DOM, state management libraries, or other platform APIs. In general, the body of an effect should do one or both of the following:\n* Update external systems with the latest state from React.\n* Subscribe for updates from some external system, calling setState in a callback function when external state changes.\n\nCalling setState synchronously within an effect body causes cascading renders that can hurt performance, and is not recommended. (https://react.dev/learn/you-might-not-need-an-effect)","suggestions":null,"details":[{"kind":"error","loc":{"start":{"line":8,"column":4,"index":236},"end":{"line":8,"column":12,"index":244},"filename":"invalid-setState-in-useEffect.ts","identifierName":"setState"},"message":"Avoid calling setState() directly within an effect"}]}},"fnLoc":null} +{"kind":"CompileError","detail":{"options":{"category":"EffectSetState","reason":"Calling setState synchronously within an effect can trigger cascading renders","description":"Effects are intended to synchronize state between React and external systems such as manually updating the DOM, state management libraries, or other platform APIs. In general, the body of an effect should do one or both of the following:\n* Update external systems with the latest state from React.\n* Subscribe for updates from some external system, calling setState in a callback function when external state changes.\n\nCalling setState synchronously within an effect body causes cascading renders that can hurt performance, and is not recommended. (https://react.dev/learn/you-might-not-need-an-effect)","suggestions":null,"details":[{"kind":"error","loc":{"start":{"line":11,"column":4,"index":294},"end":{"line":11,"column":13,"index":303},"filename":"invalid-setState-in-useEffect.ts","identifierName":"setState2"},"message":"Avoid calling setState() directly within an effect"}]}},"fnLoc":null} +{"kind":"CompileSuccess","fnLoc":{"start":{"line":4,"column":0,"index":99},"end":{"line":14,"column":1,"index":349},"filename":"invalid-setState-in-useEffect.ts"},"fnName":"Component","memoSlots":2,"memoBlocks":2,"memoValues":2,"prunedMemoBlocks":1,"prunedMemoValues":1} ``` ### Eval output diff --git a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/invalid-setState-in-useEffect.js b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/invalid-setState-in-useEffect.js index a95d3642cb8..134c88ab070 100644 --- a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/invalid-setState-in-useEffect.js +++ b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/invalid-setState-in-useEffect.js @@ -1,10 +1,14 @@ // @loggerTestOnly @validateNoSetStateInEffects -import {useEffect, useState} from 'react'; +import React, {useEffect, useState} from 'react'; function Component() { const [state, setState] = useState(0); + const [state2, setState2] = React.useState(0); useEffect(() => { setState(s => s + 1); }); - return state; + React.useEffect(() => { + setState2(s => s + 1); + }); + return state + state2; }