From 6f802312b638d60b19c8ebb683e87c71df9d2525 Mon Sep 17 00:00:00 2001
From: Shai Szulanski <iahs@meta.com>
Date: Mon, 23 Mar 2026 10:56:31 -0700
Subject: [PATCH] Migrate deprecated_terse_writes from thrift_cpp2_options to
 field-level @cpp.DeprecatedTerseWrite

Summary:
The `deprecated_terse_writes` option in `thrift_cpp2_options` applies globally to all fields. This diff migrates the behavior to per-field `cpp.DeprecatedTerseWrite` structured annotations, which is the preferred approach.

Changes to the carbon compiler (`cppgen.py` and `targets.py`):
- Add `cpp.DeprecatedTerseWrite` annotation to each non-optional, non-structured-type field in generated `.thrift` files
- Remove `deprecated_terse_writes` from `thrift_cpp2_options` in generated `BUCK` files
- Skip the annotation for structured types (structs, unions, exceptions) since `cpp.DeprecatedTerseWrite` is not supported on them

All 28 IDL files regenerated.

Differential Revision: D97542094
---
 .../protocol/gen/UcacheBench.thrift           | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/packages/ucache_bench/protocol/gen/UcacheBench.thrift b/packages/ucache_bench/protocol/gen/UcacheBench.thrift
index 5b69f180..25da45d4 100644
--- a/packages/ucache_bench/protocol/gen/UcacheBench.thrift
+++ b/packages/ucache_bench/protocol/gen/UcacheBench.thrift
@@ -29,6 +29,7 @@ struct UcacheBenchRequestCommon {
   2: optional string bucketId
 }
 struct UcacheBenchReplyCommon {
+  @cpp.DeprecatedTerseWrite
   1: carbon.ui32 replySourceBitMask
 }
 @thrift.DeprecatedUnvalidatedAnnotations{
@@ -39,7 +40,9 @@ struct UcacheBenchReplyCommon {
 struct UcbGetRequest {
   @thrift.Mixin
   -1: UcacheBenchRequestCommon ucacheBenchRequestCommon
+  @cpp.DeprecatedTerseWrite
   1: carbon.IOBufKey key
+  @cpp.DeprecatedTerseWrite
   2: carbon.ui64 flags
 }
 @thrift.DeprecatedUnvalidatedAnnotations{
@@ -50,10 +53,14 @@ struct UcbGetRequest {
 struct UcbGetReply {
   @thrift.Mixin
   -1: UcacheBenchReplyCommon ucacheBenchReplyCommon
+  @cpp.DeprecatedTerseWrite
   1: carbon_result.Result result
   2: optional carbon.IOBuf value
+  @cpp.DeprecatedTerseWrite
   3: carbon.ui64 flags
+  @cpp.DeprecatedTerseWrite
   4: string message
+  @cpp.DeprecatedTerseWrite
   5: i16 appSpecificErrorCode
   6: optional i32 exptime
 }
@@ -65,9 +72,13 @@ struct UcbGetReply {
 struct UcbSetRequest {
   @thrift.Mixin
   -1: UcacheBenchRequestCommon ucacheBenchRequestCommon
+  @cpp.DeprecatedTerseWrite
   1: carbon.IOBufKey key
+  @cpp.DeprecatedTerseWrite
   2: i32 exptime
+  @cpp.DeprecatedTerseWrite
   3: carbon.ui64 flags
+  @cpp.DeprecatedTerseWrite
   4: carbon.IOBuf value
 }
 @thrift.DeprecatedUnvalidatedAnnotations{
@@ -78,10 +89,15 @@ struct UcbSetRequest {
 struct UcbSetReply {
   @thrift.Mixin
   -1: UcacheBenchReplyCommon ucacheBenchReplyCommon
+  @cpp.DeprecatedTerseWrite
   1: carbon_result.Result result
+  @cpp.DeprecatedTerseWrite
   2: carbon.ui64 flags
+  @cpp.DeprecatedTerseWrite
   3: carbon.IOBuf value
+  @cpp.DeprecatedTerseWrite
   4: string message
+  @cpp.DeprecatedTerseWrite
   5: i16 appSpecificErrorCode
 }
 @thrift.DeprecatedUnvalidatedAnnotations{
@@ -92,7 +108,9 @@ struct UcbSetReply {
 struct UcbDeleteRequest {
   @thrift.Mixin
   -1: UcacheBenchRequestCommon ucacheBenchRequestCommon
+  @cpp.DeprecatedTerseWrite
   1: carbon.IOBufKey key
+  @cpp.DeprecatedTerseWrite
   2: carbon.ui64 flags
 }
 @thrift.DeprecatedUnvalidatedAnnotations{
@@ -103,9 +121,13 @@ struct UcbDeleteRequest {
 struct UcbDeleteReply {
   @thrift.Mixin
   -1: UcacheBenchReplyCommon ucacheBenchReplyCommon
+  @cpp.DeprecatedTerseWrite
   1: carbon_result.Result result
+  @cpp.DeprecatedTerseWrite
   2: carbon.ui64 flags
+  @cpp.DeprecatedTerseWrite
   3: string message
+  @cpp.DeprecatedTerseWrite
   4: i16 appSpecificErrorCode
 }