-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
enhancementNew feature or requestNew feature or request
Description
After dplyr 1.0 dropped, it became clear where the expect_equal() calls were implicitly ignore attribute checking: we create tibbles of expected output to test against, but the class attributes of the data returned from the facile api isn't just a plain tibble.
For now, these unit tests set expect_equal(returned, expected, **check.attributes = FALSE**) in order to ignore class matching. This is good enough for now since we are most interested in ensuring that the data we get back is sound.
It would be good to more explicitly test the class attributes of the data returned to help formalize what types of classes are returned from which API calls.
These are the unit test locations where check.attributes = FALSE needed to be added.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request