Skip to content

Optimizer as a Class Attribute #18

@davera-017

Description

@davera-017

In QNetwork and DuelingQNetwork brains the optimizer is getting initialized at every update step, which makes the training significantly slower:

def update(self, _, pred, target):
        optimizer = torch.optim.Adam(self.parameters(), lr=self.learning_rate)

Maybe a solution will be to convert it into a class attribute. Ej.:

class QNetwork(nn.Module, Brain):
    def __init__(self, env: gym.Env, hidden_layers=[], learning_rate=0.01, alpha=0.001):
        ...
        self.optimizer = torch.optim.Adam(self.parameters(), lr=self.learning_rate)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions