Skip to content

Commit 51fa951

Browse files
committed
Fixed tracking search runtimes in seconds instead of milliseconds.
1 parent 60546be commit 51fa951

File tree

3 files changed

+26
-27
lines changed

3 files changed

+26
-27
lines changed

composer.lock

Lines changed: 24 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Handler/Search/SearchQueryHandler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function handle(ServerRequestInterface $request): ResponseInterface
7373
$trackingEvent->locale = $clientRequest->locale;
7474
$trackingEvent->queryString = $clientRequest->query;
7575
$trackingEvent->resultCount = $response->totalNumberOfResults;
76-
$trackingEvent->runtime = microtime(true) - $startTime;
76+
$trackingEvent->runtime = round((microtime(true) - $startTime) * 1000);
7777
$trackingEvent->cached = $searchResults->getIsCached();
7878
$this->trackingService->addEvent($trackingEvent);
7979

test/src/Handler/Search/SearchQueryHandlerTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,7 @@ public function testHandle(): void
152152
$this->trackingService->expects($this->once())
153153
->method('addEvent')
154154
->with($this->callback(function (SearchEvent $event) use ($expectedEvent): bool {
155-
$this->assertGreaterThan(0, $event->runtime);
156-
$event->runtime = null;
155+
$event->runtime = null; // Will most likely be 0 because rounding to milliseconds.
157156

158157
$this->assertEquals($expectedEvent, $event);
159158
return true;

0 commit comments

Comments
 (0)