From 900f32690b6a09d3e4abdc30d55cd0cefec0f9dc Mon Sep 17 00:00:00 2001 From: working4coins Date: Sat, 2 Dec 2023 15:18:52 +0100 Subject: [PATCH] Update valuation.py --- coin2086/valuation.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/coin2086/valuation.py b/coin2086/valuation.py index 9771394..25b75c3 100644 --- a/coin2086/valuation.py +++ b/coin2086/valuation.py @@ -90,8 +90,7 @@ def unstack_portfolio_composition(trades, sales, initial_portfolio): portfolio = trades[["cryptocurrency", "quantity", "trade_side"]].copy() # Compute a signed quantity for each trade by multiplying by # -1 for sales and 1 for purchases - portfolio["sign"] = -1 - portfolio.loc[portfolio["trade_side"] == "BUY", "sign"] = 1 + portfolio["sign"] = portfolio["trade_side"].map({"BUY": 1, "SELL": -1}) portfolio["quantity"] = portfolio["quantity"] * portfolio["sign"] portfolio = portfolio.drop(columns=["sign", "trade_side"]) # Unstack the composition of the portofolio after each transaction