fix: make StateRegistry a real singleton

Author: julian-farbcode

src/Concerns/StatefullyLoadsAttributes.php

@@ -156,7 +156,8 @@ public function __call($method, $parameters)
                     continue;
                 }
 
-                $stateInstance = StateRegistry::tryFrom($state);
+                $stateInstance = app(StateRegistry::class)->tryFrom($state);
+
                 if ($stateInstance === null) {
                     continue;
                 }

src/StateRegistry.php

@@ -10,26 +10,29 @@
  */
 class StateRegistry
 {
-    private static array $stateClasses = [];
+    /**
+     * @var array<string, ResourceState>
+     */
+    private array $stateClasses = [];
 
     /**
      * Register a state enum class.
      */
-    public static function register(string $stateClass): void
+    public function register(string $stateClass): void
     {
         if (! is_subclass_of($stateClass, ResourceState::class)) {
-            throw new InvalidArgumentException("State class {$stateClass} must implement the ResourceState interface.");
+            throw new InvalidArgumentException("State class {$stateClass} must be a valid ResourceState enum.");
         }
 
-        self::$stateClasses[] = $stateClass;
+        $this->stateClasses[] = $stateClass;
     }
 
     /**
      * Try to find a state by value across all registered state classes.
      */
-    public static function tryFrom(string $value): ?ResourceState
+    public function tryFrom(string $value): ?ResourceState
     {
-        foreach (self::$stateClasses as $stateClass) {
+        foreach ($this->stateClasses as $stateClass) {
             $state = $stateClass::tryFrom($value);
             if ($state !== null) {
                 return $state;
@@ -42,9 +45,9 @@ public static function tryFrom(string $value): ?ResourceState
     /**
      * Find a state by value across all registered state classes.
      */
-    public static function from(string $value): ResourceState
+    public function from(string $value): ResourceState
     {
-        $state = self::tryFrom($value);
+        $state = $this->tryFrom($value);
 
         if ($state === null) {
             throw new InvalidArgumentException("Unknown state: {$value}");
@@ -56,10 +59,10 @@ public static function from(string $value): ResourceState
     /**
      * Get all available states from all registered classes.
      */
-    public static function all(): array
+    public function all(): array
     {
         $states = [];
-        foreach (self::$stateClasses as $stateClass) {
+        foreach ($this->stateClasses as $stateClass) {
             $states = array_merge($states, $stateClass::cases());
         }
 
@@ -69,8 +72,8 @@ public static function all(): array
     /**
      * Clear all registered state classes.
      */
-    public static function clear(): void
+    public function clear(): void
     {
-        self::$stateClasses = [];
+        $this->stateClasses = [];
     }
 }

src/StatefulJsonResource.php

@@ -57,7 +57,7 @@ public function __construct($resource)
      */
     public static function __callStatic($method, $parameters)
     {
-        $state = StateRegistry::tryFrom($method);
+        $state = app(StateRegistry::class)->tryFrom($method);
 
         if ($state === null) {
             return parent::__callStatic($method, $parameters);