We currently commit a built WASI p1-to-p2 adapter in wasm_abi/data/. I suspect it's just because our build system isn't rigged to automatically build it before building the rest of Viceroy (which needs to read it in at compile time using include_bytes!()).
Let's contrive to make our build system build the adapter automatically, perhaps with a build.rs. This will avoid…
- Me forgetting to update the adapter before building Viceroy and then wondering why my changes didn't take effect
- Having a nondeterministic and thus unverifiable binary committed. (It turns out the binaries differ a lot based on whether they're built on Linux or the Mac (imports and functions being in different orders, making diffing next to impossible); IHNI about Windows. Even between 2 Linux boxes, they differ in their symbol names suffixes, e.g. $_ZN25viceroy_component_adapter6macros10eprint_u3215eprint_u32_impl17hc6b497a227a95847E.llvm.6107973161718614711.)
We currently commit a built WASI p1-to-p2 adapter in
wasm_abi/data/. I suspect it's just because our build system isn't rigged to automatically build it before building the rest of Viceroy (which needs to read it in at compile time usinginclude_bytes!()).Let's contrive to make our build system build the adapter automatically, perhaps with a
build.rs. This will avoid…