From d225ee83f798d83ad6930b3a967cb7edffa78b38 Mon Sep 17 00:00:00 2001 From: Toshi Aizawa Date: Thu, 21 Sep 2017 10:27:50 +0900 Subject: [PATCH 1/2] correct a typo removes the `Set-Cookie` header from a request -> removes the `Set-Cookie` header from a response --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index df6a25b..c1bd567 100644 --- a/README.md +++ b/README.md @@ -168,7 +168,7 @@ end By default, Fastly will not cache any response containing a `Set-Cookie` header. In general, this is beneficial because caching responses that contain sensitive data is typically not done on shared caches. In this plugin the `set_cache_control_headers` method removes the `Set-Cookie` header from a -request. In some cases, other libraries, particularily middleware, may insert or modify HTTP Headers outside the scope of where the `set_cache_control_heades` method is invoked in a controller action. For example, some authentication middleware will add a `Set-Cookie` header into requests *after* fastly-rails removes it. +response. In some cases, other libraries, particularily middleware, may insert or modify HTTP Headers outside the scope of where the `set_cache_control_heades` method is invoked in a controller action. For example, some authentication middleware will add a `Set-Cookie` header into requests *after* fastly-rails removes it. This can cause some requests that can (and should) be cached to not be cached due to the presence of `Set-Cookie`. From 77147e2b74fa835e9ff9e35bb665b32680100914 Mon Sep 17 00:00:00 2001 From: Toshi Aizawa Date: Fri, 5 Jan 2018 15:58:31 +0900 Subject: [PATCH 2/2] make another correction: requests -> responses in Sessions, Cookies, and private data, as @thommahoney suggested --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index c1bd567..cae30f4 100644 --- a/README.md +++ b/README.md @@ -168,7 +168,7 @@ end By default, Fastly will not cache any response containing a `Set-Cookie` header. In general, this is beneficial because caching responses that contain sensitive data is typically not done on shared caches. In this plugin the `set_cache_control_headers` method removes the `Set-Cookie` header from a -response. In some cases, other libraries, particularily middleware, may insert or modify HTTP Headers outside the scope of where the `set_cache_control_heades` method is invoked in a controller action. For example, some authentication middleware will add a `Set-Cookie` header into requests *after* fastly-rails removes it. +response. In some cases, other libraries, particularily middleware, may insert or modify HTTP Headers outside the scope of where the `set_cache_control_heades` method is invoked in a controller action. For example, some authentication middleware will add a `Set-Cookie` header into responses *after* fastly-rails removes it. This can cause some requests that can (and should) be cached to not be cached due to the presence of `Set-Cookie`.