From 8a6191bf7c1cb17d87caab0efb585353b51d40ba Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Wed, 6 May 2026 08:49:34 +0000
Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=A1=EF=B8=8F=20Sentinel:=20Replace=20i?=
 =?UTF-8?q?nsecure=20Math.random=20with=20secure=20code=20generation?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Replaced the insecure Math.random() implementation with a cryptographically secure pseudo-random number generator (CSPRNG) using the Web Crypto API. This prevents potential predictability in generating sensitive business values like coupon codes, store credit codes, and combo group identifiers. Created a centralized utility function `generateSecureCode` in `lib/utils.ts`.

Co-authored-by: f4teless <60130665+f4teless@users.noreply.github.com>
---
 .jules/sentinel.md       |  5 +++++
 app/api/bargain/route.ts |  8 ++------
 lib/actions/admin.ts     |  7 ++-----
 lib/cart-context.tsx     |  3 ++-
 lib/utils.ts             | 12 ++++++++++++
 5 files changed, 23 insertions(+), 12 deletions(-)
 create mode 100644 .jules/sentinel.md

diff --git a/.jules/sentinel.md b/.jules/sentinel.md
new file mode 100644
index 0000000..6e28f11
--- /dev/null
+++ b/.jules/sentinel.md
@@ -0,0 +1,5 @@
+
+## 2025-02-14 - Replace insecure `Math.random` with secure code generation
+**Vulnerability:** Weak random number generation (`Math.random()`) was being used to generate sensitive business values like coupon codes, store credit codes, and combo group IDs. `Math.random()` is not cryptographically secure, making the codes potentially predictable.
+**Learning:** This repo lacked a centralized secure string generator and defaulted to `Math.random` out of convenience for generating unique string identifiers, which poses a risk for financial logic like discount codes.
+**Prevention:** Created a centralized `generateSecureCode` utility in `lib/utils.ts` utilizing the Web Crypto API (`globalThis.crypto.getRandomValues`). Always use this or a similar CSPRNG for generating tokens, passwords, or identifiers involved in business logic or security contexts.
diff --git a/app/api/bargain/route.ts b/app/api/bargain/route.ts
index cd182da..940c89b 100644
--- a/app/api/bargain/route.ts
+++ b/app/api/bargain/route.ts
@@ -4,6 +4,7 @@ import { db, user, coupons, bargainSessions, products, combos } from "@/lib/db";
 import { and, eq, inArray } from "drizzle-orm";
 import { headers } from "next/headers";
 import { auth } from "@/lib/auth";
+import { generateSecureCode } from "@/lib/utils";
 
 export const maxDuration = 30;
 const MAX_NEGOTIATION_ROUNDS = 10;
@@ -20,12 +21,7 @@ type BargainCartItem = {
 
 // Generate unique coupon code
 function generateCouponCode(): string {
-  const chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
-  let code = "BRG-";
-  for (let i = 0; i < 6; i++) {
-    code += chars.charAt(Math.floor(Math.random() * chars.length));
-  }
-  return code;
+  return generateSecureCode("BRG-", 6);
 }
 
 function calculateCartRuleCap(cartTotal: number, isFirstTimeUser: boolean): number {
diff --git a/lib/actions/admin.ts b/lib/actions/admin.ts
index 54c3848..9a1c424 100644
--- a/lib/actions/admin.ts
+++ b/lib/actions/admin.ts
@@ -5,6 +5,7 @@ import { products, productVariants, coupons, orders, orderItems } from "@/lib/db
 import { requireAdmin } from "@/lib/auth-server";
 import { eq, desc, sql, and, gte } from "drizzle-orm";
 import { revalidatePath } from "next/cache";
+import { generateSecureCode } from "@/lib/utils";
 
 // ============================================
 // PRODUCT ACTIONS
@@ -567,11 +568,7 @@ export async function issueStoreCredit(data: IssueStoreCreditInput) {
   const creditAmount = Math.round(data.refundAmount * bonusMultiplier);
   
   // Generate unique store credit code
-  const chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
-  let code = "CREDIT-";
-  for (let i = 0; i < 8; i++) {
-    code += chars.charAt(Math.floor(Math.random() * chars.length));
-  }
+  const code = generateSecureCode("CREDIT-", 8);
 
   // Set validity (30-60 days)
   const validityDays = Math.min(Math.max(data.validityDays || 30, 30), 60);
diff --git a/lib/cart-context.tsx b/lib/cart-context.tsx
index 47e4f67..0e364ea 100644
--- a/lib/cart-context.tsx
+++ b/lib/cart-context.tsx
@@ -1,6 +1,7 @@
 "use client"
 
 import { createContext, useContext, useState, useEffect, ReactNode } from "react"
+import { generateSecureCode } from "@/lib/utils"
 
 export interface CartItem {
     id: string
@@ -80,7 +81,7 @@ export function CartProvider({ children }: { children: ReactNode }) {
     }
 
     const addCombo: CartContextType["addCombo"] = (combo) => {
-        const comboGroupId = `combo-${Date.now()}-${Math.random().toString(36).slice(2, 8)}`
+        const comboGroupId = `combo-${Date.now()}-${generateSecureCode("", 6).toLowerCase()}`
         setItems((prev) => [
             ...prev,
             ...combo.items.map((item) => ({
diff --git a/lib/utils.ts b/lib/utils.ts
index bd0c391..0623a72 100644
--- a/lib/utils.ts
+++ b/lib/utils.ts
@@ -4,3 +4,15 @@ import { twMerge } from "tailwind-merge"
 export function cn(...inputs: ClassValue[]) {
   return twMerge(clsx(inputs))
 }
+
+export function generateSecureCode(prefix: string, length: number): string {
+  const chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
+  const randomValues = new Uint32Array(length);
+  globalThis.crypto.getRandomValues(randomValues);
+
+  let code = prefix;
+  for (let i = 0; i < length; i++) {
+    code += chars[randomValues[i] % chars.length];
+  }
+  return code;
+}