Skip to content

Conversation

@bra-i-am
Copy link
Contributor

@bra-i-am bra-i-am commented Sep 12, 2025

This pull request introduces a new "Course Enrollments" feature, enabling users to view detailed enrollment data for individual courses within a partner's catalog. It also refactors several hooks and APIs to support more flexible data fetching and caching, and improves image rendering in the UI. The most important changes are grouped below.

New Course Enrollments Feature:

  • Added a new route and page (CourseEnrollmentsPage) that displays course enrollment details, including a summary header and a paginated, filterable table of enrolled learners. This includes new components, hooks, API methods, and i18n messages. [1] [2] [3] [4] [5] [6]

API and Data Fetching Improvements:

  • Refactored getCourses API and useCatalogCourses hook to accept parameters as an object, support optional paging and filtering by course overview, and leverage client-side caching for improved performance. [1] [2] [3] [4] [5] [6] [7] [8]
  • Added getCourseDetails API and useCourseDetails hook to fetch and cache detailed information for a single course. [1] [2]

UI Enhancements:

  • Changed image rendering in ImageWithSkeleton to use objectFit: 'contain' for better aspect ratio handling.

@bra-i-am bra-i-am changed the title feat: add enrollments list feat: add enrollments page Sep 12, 2025
@bra-i-am bra-i-am force-pushed the bc/students-list branch 2 times, most recently from a1b7176 to d9e6db5 Compare September 12, 2025 19:45
@dcoa dcoa force-pushed the dcoa/courses-list branch 2 times, most recently from 1dc7460 to 8cde55e Compare September 15, 2025 08:02
@bra-i-am bra-i-am force-pushed the bc/students-list branch 2 times, most recently from 65d9585 to be79e7e Compare September 15, 2025 19:30
@bra-i-am bra-i-am marked this pull request as ready for review September 15, 2025 20:45
@bra-i-am bra-i-am requested a review from dcoa September 16, 2025 19:45
@bra-i-am bra-i-am changed the base branch from dcoa/courses-list to main September 18, 2025 21:28
<Switch>
<Route path={paths.partners.path} component={CorporatePartnerPage} />
<CatalogEditionModalProvider>
<CatalogEditionModalProvider>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done because there were unknown issues with accessing the paths out of the context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants