WIP1

Author: dsun0720

fbclient/common_types.py

@@ -38,7 +38,8 @@ def __init__(self, key: Optional[str], name: Optional[str], **kwargs):
         self._customs = {}
         if len(kwargs) > 0:
             self._customs \
-                .update(dict((k, str(v)) for k, v in kwargs.items() if isinstance(k, str) and k.lower() not in __BUILTINS_MAPING__.keys() and (isinstance(v, str) or is_numeric(v))))
+                .update(dict((k, str(v)) for k, v in kwargs.items() if isinstance(k, str) and k.lower() not in __BUILTINS_MAPING__.keys()
+                             and (isinstance(v, str) or is_numeric(v) or isinstance(v, bool))))
 
     @staticmethod
     def from_dict(user: Dict[str, Any]) -> "FBUser":

fbclient/utils/__init__.py

@@ -133,16 +133,15 @@ def cast_variation_by_flag_type(flag_type: Optional[str], variation: Optional[st
 
 
 def simple_type_inference(value: Any) -> Optional[str]:
-    try:
-        if isinstance(value, bool):
-            return 'boolean'
-        elif isinstance(value, str):
-            return 'string'
-        elif isinstance(value, Iterable) or isinstance(value, Mapping):
-            return 'json'
-        elif is_numeric(str(value)):
-            return 'number'
-        else:
-            return None
-    except:
+    if isinstance(value, bool):
+        return 'boolean'
+    elif isinstance(value, str):
+        return 'string'
+    elif isinstance(value, Iterable) or isinstance(value, Mapping):
+        return 'json'
+    elif is_numeric(value):
+        return 'number'
+    elif value is None:
         return None
+    else:
+        raise ValueError("value type is not supported")