Skip to content

Drop dependent_version? #32

@axilleas

Description

@axilleas

Is there any reason to have dependent_version in the Dependency table? Currently this is used in places that do not add anything to the app:

> ack dependent_version app/
app/models/ruby_gem.rb
64:        d.dependent_version = dep['requirements']

app/models/fedora_rpm.rb
207:      d.dependent_version = 

With current implementation of obtaining the build dependencies (parsing spec file), we sometimes end up with double dependencies, with only difference their version.

Example: mail is picked twice because of spec file definition.

FedoraRpm.find_by(name: 'rubygem-actionmailer').dependencies

+------+-------------+------------+-------------------+-------------------------+-------------------------+------------+--------------+
| id   | environment | dependent  | dependent_version | created_at              | updated_at              | package_id | package_type |
+------+-------------+------------+-------------------+-------------------------+-------------------------+------------+--------------+
| 9894 | development | mocha      |                   | 2014-09-07 03:18:30 UTC | 2014-09-07 03:18:30 UTC | 143        | FedoraRpm    |
| 9893 | development | minitest   |                   | 2014-09-07 03:18:18 UTC | 2014-09-07 03:18:18 UTC | 143        | FedoraRpm    |
| 9892 | development | mail       | < 2.6             | 2014-09-07 03:18:06 UTC | 2014-09-07 03:18:06 UTC | 143        | FedoraRpm    |
| 9891 | development | mail       | >= 2.5.3          | 2014-09-07 03:17:54 UTC | 2014-09-07 03:17:54 UTC | 143        | FedoraRpm    |
| 9890 | development | actionview | = 4.1.5           | 2014-09-07 03:17:42 UTC | 2014-09-07 03:17:42 UTC | 143        | FedoraRpm    |
| 9889 | development | actionpack | = 4.1.5           | 2014-09-07 03:17:31 UTC | 2014-09-07 03:17:31 UTC | 143        | FedoraRpm    |
| 9888 | runtime     | actionview |                   | 2014-09-07 03:17:02 UTC | 2014-09-07 03:17:02 UTC | 143        | FedoraRpm    |
| 9887 | runtime     | actionpack |                   | 2014-09-07 03:17:02 UTC | 2014-09-07 03:17:02 UTC | 143        | FedoraRpm    |
| 9886 | runtime     | mail       |                   | 2014-09-07 03:17:02 UTC | 2014-09-07 03:17:02 UTC | 143        | FedoraRpm    |
+------+-------------+------------+-------------------+-------------------------+-------------------------+------------+--------------+

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions