`mkIf` under `files.<file>.text` no longer works

[fxzzi]

The below works fine on revision 31f969f

xdg.config.files."zsh/.zprofile".text = mkIf cfg.autoStart autoStartCmd;

On latest master it doesn't tho, however the below does

xdg.config.files."zsh/.zprofile" = mkIf cfg.autoStart {text = autoStartCmd;};

[eclairevoyant]

Wdym by "doesn't work"?

Besides, the second option is better anyway.

[eclairevoyant]

Okay after further testing, the former produces the error

'foo.source' is required for the following types: ["copy","symlink"]

The problem is that fundamentally if we want to do some validity checks (like (elem type ["copy" "symlink"]) == (source != null)) and somehow satisfy the former case, we have to put some options.[whatever].isDefined checks all over the place which gets unreadable.

Or stated simply - if we have files.<file> defined, we expect files.<file>.* to be coherently configured.

Also, the latter is better, since we're not generating an entire attrset anyway just to throw it away. (Even NixOS and home-manager modules should use the latter pattern.)

For now, I don't think we plan to support the former; however, we can document it for clarity.

[fxzzi]

That's fine, if the second option is better anyway then it makes sense. You're right that we should probably document this

[atagen]

I'm hitting this error on these lines from hjem-rum. it appears that the mkIf here should be properly formed, any idea why this would still cause an issue?

[player131007]

I'm hitting this error on these lines from hjem-rum. it appears that the mkIf here should be properly formed, any idea why this would still cause an issue?

The direnv tests succeeded, what is your relevant config? Also I think you should open an issue over at hjem-rum.

[atagen]

I'm hitting this error on these lines from hjem-rum. it appears that the mkIf here should be properly formed, any idea why this would still cause an issue?

The direnv tests succeeded, what is your relevant config?

hjem.users.<name>.rum.programs.direnv = {
  enable = false;
  integrations.fish.enable = true;
};

Also I think you should open an issue over at hjem-rum.

done.

edit: it appears this was a misconfiguration on my part, apologies for the noise

[eclairevoyant]

we should probably document this

https://github.com/snugnug/hjem-rum/blob/main/docs/CONTRIBUTING.md#conditional-config explains it better, we'll try to point people there