Code maintenance "Run Code Cleanup (Profile 1)"

[flucas1]

I would like to review a few things in this control with a much of static code analyzers.
I have the impression (no proof) of some "memory leak" hitting somethings, although I am not sure what the root cause is,

As a first step I would suggest the tool of Visual Studio "Run Code Cleanup (Profile 1)", before further changes.
This is a massive commit of several of several thousands of lines of code.

I can do this huge pull request, and just "trust me", or can be done by @fidarit
I consider this a previous step before start suggesting any other change.

[fidarit]

Right now my top priority is to fix the performance degradation caused by the weird virtualization behavior. I also suspect the memory leak might be related to the same issue.

I've already tried tackling it several times, but without success so far. After the weekend I’m planning to dive into it again.

[flucas1]

For performance with Avalonia 11 I have this "hack"

flucas1@2280ed3

where I remove a call to check the thread status. from the base control function.
With this I improved significantly the rendering speed of cells.

So far it works for me.

I do not know if this has changed for Avalonia 12, I have not checked. I informed of this issue to the Avalonia team before the 12 release... but never got any answer. For a few controls that are monstly static is not an issue (the usual screen), , but for scrolling the TreeDataGrid and the recycling this was an issue...

[flucas1]

Nevertheless I would suggest that you run the code cleanup and commit the changes. This is a no-brainer, as there are no changes in the logic, it is only code style issues. But some of the checks of the static analyzers complain a lot about code style issues... and there is too much noise ...

So I would be willing to have a look on my side on some topics, and have some occasional pull request, but only after sanitizing a bit the base code (as per the code cleanup tool rules).