chore: add common.targets file and modify settings

filzrev · filzrev · commit 0547648c8f27 · 2025-12-17T19:51:26.000+09:00
diff --git a/BenchmarkDotNet.slnx b/BenchmarkDotNet.slnx
@@ -1,5 +1,10 @@
 <Solution>
+  <Folder Name="/build/">
+    <File Path="build/common.props" />
+    <File Path="build/common.targets" />
+  </Folder>
   <Folder Name="/samples/">
+    <File Path="samples/Directory.build.props" />
     <Project Path="samples/BenchmarkDotNet.Samples.FSharp/BenchmarkDotNet.Samples.FSharp.fsproj" />
     <Project Path="samples/BenchmarkDotNet.Samples/BenchmarkDotNet.Samples.csproj" DefaultStartup="true" />
   </Folder>
@@ -19,6 +24,7 @@
     <Project Path="templates/BenchmarkDotNet.Templates.csproj" />
   </Folder>
   <Folder Name="/tests/">
+    <File Path="tests/Directory.build.props" />
     <Project Path="tests/BenchmarkDotNet.Analyzers.Tests/BenchmarkDotNet.Analyzers.Tests.csproj" />
     <Project Path="tests/BenchmarkDotNet.Exporters.Plotting.Tests/BenchmarkDotNet.Exporters.Plotting.Tests.csproj" />
     <Project Path="tests/BenchmarkDotNet.IntegrationTests.ConfigPerAssembly/BenchmarkDotNet.IntegrationTests.ConfigPerAssembly.csproj" />
diff --git a/build/common.props b/build/common.props
@@ -28,20 +28,16 @@
     <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
   </PropertyGroup>
 
-  <ItemGroup>
-    <None Include="$(MSBuildThisFileDirectory)package-icon.png" Pack="True" PackagePath=""/>
-  </ItemGroup>
-
   <PropertyGroup>
     <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)strongNameKey.snk</AssemblyOriginatorKeyFile>
     <SignAssembly>true</SignAssembly>
   </PropertyGroup>
 
-  <PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
+  <PropertyGroup Condition="'$(GenerateDocumentationFile)' == '' AND '$(Configuration)' == 'Release' ">
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
   </PropertyGroup>
 
-  <PropertyGroup Condition=" '$(IsVisualBasic)' != 'true' AND '$(IsFsharp)' != 'true' ">
+  <PropertyGroup Condition="'$(MSBuildProjectExtension)' != '.fsproj' ">
     <LangVersion>14.0</LangVersion>
   </PropertyGroup>
 
@@ -68,14 +64,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
-    </PackageReference>
-    <PackageReference Include="StyleCop.Analyzers.Unstable" Version="1.2.0.556">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
-    </PackageReference>
+    <GlobalPackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />
+    <GlobalPackageReference Include="StyleCop.Analyzers.Unstable" Version="1.2.0.556" />
   </ItemGroup>
 
   <UsingTask TaskName="ReplaceFileText"
diff --git a/build/common.targets b/build/common.targets
@@ -0,0 +1,7 @@
+<Project>
+
+  <ItemGroup Condition="'$(IsPackable)' == 'true'">
+    <None Include="$(MSBuildThisFileDirectory)package-icon.png" Pack="True" PackagePath=""/>
+  </ItemGroup>
+
+</Project>
diff --git a/samples/BenchmarkDotNet.Samples.FSharp/BenchmarkDotNet.Samples.FSharp.fsproj b/samples/BenchmarkDotNet.Samples.FSharp/BenchmarkDotNet.Samples.FSharp.fsproj
@@ -1,8 +1,4 @@
 <Project Sdk="Microsoft.NET.Sdk">
-  <PropertyGroup>
-    <!-- MSBuild was complaing about InformationalVersion from common.props file, so I excluded them in conditional way -->
-    <IsFsharp>true</IsFsharp>
-  </PropertyGroup>
   <Import Project="..\..\build\common.props" />
   <PropertyGroup>
     <OutputType>Exe</OutputType>
@@ -28,4 +24,6 @@
     <PackageReference Update="System.ValueTuple" Version="4.6.1" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
   </ItemGroup>
+
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/samples/BenchmarkDotNet.Samples.Maui/BenchmarkDotNet.Samples.Maui.csproj b/samples/BenchmarkDotNet.Samples.Maui/BenchmarkDotNet.Samples.Maui.csproj
@@ -68,4 +68,5 @@
 		<ProjectReference Include="..\..\src\BenchmarkDotNet\BenchmarkDotNet.csproj" />
 	</ItemGroup>
 
+	<Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/samples/BenchmarkDotNet.Samples/BenchmarkDotNet.Samples.csproj b/samples/BenchmarkDotNet.Samples/BenchmarkDotNet.Samples.csproj
@@ -7,7 +7,6 @@
     <AssemblyName>BenchmarkDotNet.Samples</AssemblyName>
     <OutputType>Exe</OutputType>
     <PackageId>BenchmarkDotNet.Samples</PackageId>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <PlatformTarget>AnyCPU</PlatformTarget>
     <DebugSymbols>true</DebugSymbols>
     <NoWarn>$(NoWarn);CA1018;CA5351;CA1825</NoWarn>
@@ -44,4 +43,5 @@
     <!-- Enables analyzers for this project (this is required since ProjectReference is not transitive). -->
     <ProjectReference Include="..\..\src\BenchmarkDotNet.Analyzers\BenchmarkDotNet.Analyzers.csproj" ReferenceOutputAssembly="false" OutputItemType="Analyzer"/>
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/samples/Directory.build.props b/samples/Directory.build.props
@@ -0,0 +1,6 @@
+<Project>
+  <PropertyGroup>
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
+    <IsPackable>false</IsPackable>
+  </PropertyGroup>
+</Project>
diff --git a/src/BenchmarkDotNet.Analyzers/BenchmarkDotNet.Analyzers.csproj b/src/BenchmarkDotNet.Analyzers/BenchmarkDotNet.Analyzers.csproj
@@ -48,4 +48,5 @@
       <_Parameter1>BenchmarkDotNet.Analyzers.Tests,PublicKey=00240000048000009400000006020000002400005253413100040000010001002970bbdfca4d129fc74b4845b239973f1b183684f0d7db5e1de7e085917e3656cf94884803cb800d85d5aae5838fb3f8fd1f2829e8208c4f087afcfe970bce44037ba30a66749cd5514b410ca8a35e9c7d6eb86975853c834c9ad25051537f9a05a0c540c5d84f2c7b32ab01619d84367fd424797ba3242f08b0e6ae75f66dad</_Parameter1>
     </AssemblyAttribute>
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/src/BenchmarkDotNet.Annotations/BenchmarkDotNet.Annotations.csproj b/src/BenchmarkDotNet.Annotations/BenchmarkDotNet.Annotations.csproj
@@ -47,4 +47,5 @@
       </ItemGroup>
     </Otherwise>
   </Choose>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/src/BenchmarkDotNet.Diagnostics.Windows/BenchmarkDotNet.Diagnostics.Windows.csproj b/src/BenchmarkDotNet.Diagnostics.Windows/BenchmarkDotNet.Diagnostics.Windows.csproj
@@ -14,4 +14,5 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.Diagnostics.Tracing.TraceEvent" Version="3.1.21" PrivateAssets="contentfiles;analyzers" />
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/src/BenchmarkDotNet.Diagnostics.dotMemory/BenchmarkDotNet.Diagnostics.dotMemory.csproj b/src/BenchmarkDotNet.Diagnostics.dotMemory/BenchmarkDotNet.Diagnostics.dotMemory.csproj
@@ -17,4 +17,5 @@
         <PackageReference Include="JetBrains.Profiler.SelfApi" Version="2.5.13" />
     </ItemGroup>
 
+    <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/src/BenchmarkDotNet.Diagnostics.dotTrace/BenchmarkDotNet.Diagnostics.dotTrace.csproj b/src/BenchmarkDotNet.Diagnostics.dotTrace/BenchmarkDotNet.Diagnostics.dotTrace.csproj
@@ -17,4 +17,5 @@
         <PackageReference Include="JetBrains.Profiler.SelfApi" Version="2.5.13" />
     </ItemGroup>
 
+    <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/src/BenchmarkDotNet.Disassembler/BenchmarkDotNet.Disassembler.csproj b/src/BenchmarkDotNet.Disassembler/BenchmarkDotNet.Disassembler.csproj
@@ -15,4 +15,5 @@
   <ItemGroup>
     <ProjectReference Include="..\BenchmarkDotNet\BenchmarkDotNet.csproj" />
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/src/BenchmarkDotNet.Exporters.Plotting/BenchmarkDotNet.Exporters.Plotting.csproj b/src/BenchmarkDotNet.Exporters.Plotting/BenchmarkDotNet.Exporters.Plotting.csproj
@@ -16,4 +16,5 @@
   <ItemGroup>
     <PackageReference Include="ScottPlot" Version="5.0.55" />
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/src/BenchmarkDotNet.TestAdapter/BenchmarkDotNet.TestAdapter.csproj b/src/BenchmarkDotNet.TestAdapter/BenchmarkDotNet.TestAdapter.csproj
@@ -27,4 +27,5 @@
     <None Include="entrypoints\EntryPoint.*" Pack="true" PackagePath="entrypoints\" />
     <None Include="build\BenchmarkDotNet.TestAdapter.props" Pack="true" PackagePath="build\" />
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/src/BenchmarkDotNet.Weaver/BenchmarkDotNet.Weaver.csproj b/src/BenchmarkDotNet.Weaver/BenchmarkDotNet.Weaver.csproj
@@ -31,4 +31,6 @@ then run `build.cmd pack-weaver`.
     <Content Include="$(OutputPath)**\*.dll" Pack="true" PackagePath="tasks/$(TargetFramework)" />
     <None Remove="packages\**" />
   </ItemGroup>
+
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/src/BenchmarkDotNet/BenchmarkDotNet.csproj b/src/BenchmarkDotNet/BenchmarkDotNet.csproj
@@ -49,4 +49,5 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/templates/BenchmarkDotNet.Templates.csproj b/templates/BenchmarkDotNet.Templates.csproj
@@ -45,4 +45,5 @@
             MatchExpression='("defaultValue": )"([\d+\.?]+)"'
             ReplacementText='${1}"$(VersionPrefix)"' />
   </Target>
+  <Import Project="..\build\common.targets" />
 </Project>
diff --git a/tests/BenchmarkDotNet.Analyzers.Tests/BenchmarkDotNet.Analyzers.Tests.csproj b/tests/BenchmarkDotNet.Analyzers.Tests/BenchmarkDotNet.Analyzers.Tests.csproj
@@ -30,4 +30,5 @@
     <ProjectReference Include="..\..\src\BenchmarkDotNet.Analyzers\BenchmarkDotNet.Analyzers.csproj" />
     <ProjectReference Include="..\..\src\BenchmarkDotNet\BenchmarkDotNet.csproj" />
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/tests/BenchmarkDotNet.Exporters.Plotting.Tests/BenchmarkDotNet.Exporters.Plotting.Tests.csproj b/tests/BenchmarkDotNet.Exporters.Plotting.Tests/BenchmarkDotNet.Exporters.Plotting.Tests.csproj
@@ -2,8 +2,6 @@
   <Import Project="..\..\build\common.props" />
   <PropertyGroup>
     <TargetFrameworks>net8.0;net462</TargetFrameworks>
-    <IsPackable>false</IsPackable>
-    <IsTestProject>true</IsTestProject>
     <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
   </PropertyGroup>
@@ -23,4 +21,5 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/tests/BenchmarkDotNet.IntegrationTests.ConfigPerAssembly/BenchmarkDotNet.IntegrationTests.ConfigPerAssembly.csproj b/tests/BenchmarkDotNet.IntegrationTests.ConfigPerAssembly/BenchmarkDotNet.IntegrationTests.ConfigPerAssembly.csproj
@@ -17,4 +17,5 @@
     <PackageReference Include="Microsoft.NETCore.Platforms" Version="7.0.4" />
     <Reference Include="System.Runtime" />
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/tests/BenchmarkDotNet.IntegrationTests.CustomPaths/BenchmarkDotNet.IntegrationTests.CustomPaths.csproj b/tests/BenchmarkDotNet.IntegrationTests.CustomPaths/BenchmarkDotNet.IntegrationTests.CustomPaths.csproj
@@ -29,4 +29,5 @@
       <HintPath>customPath\VerySimple.dll</HintPath>
     </Reference>
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/tests/BenchmarkDotNet.IntegrationTests.DisabledOptimizations/BenchmarkDotNet.IntegrationTests.DisabledOptimizations.csproj b/tests/BenchmarkDotNet.IntegrationTests.DisabledOptimizations/BenchmarkDotNet.IntegrationTests.DisabledOptimizations.csproj
@@ -19,4 +19,5 @@
     <PackageReference Include="Microsoft.NETCore.Platforms" Version="7.0.4" />
     <Reference Include="System.Runtime" />
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/tests/BenchmarkDotNet.IntegrationTests.EnabledOptimizations/BenchmarkDotNet.IntegrationTests.EnabledOptimizations.csproj b/tests/BenchmarkDotNet.IntegrationTests.EnabledOptimizations/BenchmarkDotNet.IntegrationTests.EnabledOptimizations.csproj
@@ -19,4 +19,5 @@
     <PackageReference Include="Microsoft.NETCore.Platforms" Version="7.0.4" />
     <Reference Include="System.Runtime" />
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/tests/BenchmarkDotNet.IntegrationTests.FSharp/BenchmarkDotNet.IntegrationTests.FSharp.fsproj b/tests/BenchmarkDotNet.IntegrationTests.FSharp/BenchmarkDotNet.IntegrationTests.FSharp.fsproj
@@ -1,8 +1,4 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
-  <PropertyGroup>
-    <!-- MSBuild was complaing about InformationalVersion from common.props file, so I excluded them in conditional way -->
-    <IsFsharp>true</IsFsharp>
-  </PropertyGroup>
   <Import Project="..\..\build\common.props" />
   <PropertyGroup>
     <TargetFrameworks>net462;net8.0</TargetFrameworks>
@@ -18,4 +14,5 @@
     <PackageReference Update="FSharp.Core" Version="9.0.300" />
     <PackageReference Update="System.ValueTuple" Version="4.6.1" />
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/tests/BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks/BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks.csproj b/tests/BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks/BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks.csproj
@@ -50,4 +50,5 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/tests/BenchmarkDotNet.IntegrationTests.ManualRunning/BenchmarkDotNet.IntegrationTests.ManualRunning.csproj b/tests/BenchmarkDotNet.IntegrationTests.ManualRunning/BenchmarkDotNet.IntegrationTests.ManualRunning.csproj
@@ -41,4 +41,5 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/tests/BenchmarkDotNet.IntegrationTests.Static/BenchmarkDotNet.IntegrationTests.Static.csproj b/tests/BenchmarkDotNet.IntegrationTests.Static/BenchmarkDotNet.IntegrationTests.Static.csproj
@@ -17,4 +17,5 @@
     <PackageReference Include="Microsoft.NETCore.Platforms" Version="7.0.4" />
     <Reference Include="System.Runtime" />
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/tests/BenchmarkDotNet.IntegrationTests.VisualBasic/BenchmarkDotNet.IntegrationTests.VisualBasic.vbproj b/tests/BenchmarkDotNet.IntegrationTests.VisualBasic/BenchmarkDotNet.IntegrationTests.VisualBasic.vbproj
@@ -1,13 +1,10 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
-  <PropertyGroup>
-    <!-- MSBuild was complaing about some settings from common.props file, so I excluded them in conditional way -->
-    <IsVisualBasic>true</IsVisualBasic>
-  </PropertyGroup>
   <Import Project="..\..\build\common.props" />
   <PropertyGroup>
     <TargetFrameworks>net462;net8.0</TargetFrameworks>
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\..\src\BenchmarkDotNet\BenchmarkDotNet.csproj" />
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/tests/BenchmarkDotNet.IntegrationTests/BenchmarkDotNet.IntegrationTests.csproj b/tests/BenchmarkDotNet.IntegrationTests/BenchmarkDotNet.IntegrationTests.csproj
@@ -125,4 +125,5 @@
       <LastGenOutput>RunnableVoidCaseBenchmark.cs</LastGenOutput>
     </None>
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/tests/BenchmarkDotNet.Tests/BenchmarkDotNet.Tests.csproj b/tests/BenchmarkDotNet.Tests/BenchmarkDotNet.Tests.csproj
@@ -53,4 +53,5 @@
     <Folder Include="Detectors\" />
     <Folder Include="Perfonar\VerifiedFiles\" />
   </ItemGroup>
+  <Import Project="..\..\build\common.targets" />
 </Project>
diff --git a/tests/Directory.build.props b/tests/Directory.build.props
@@ -1,4 +1,9 @@
 <Project>
+  <PropertyGroup>
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
+    <IsPackable>false</IsPackable>
+  </PropertyGroup>
+
   <!-- ProjectReferences are not transitive, so we need to directly include the analyzers for all test projects. -->
   <ItemGroup Condition="'$(AssemblyName)' != 'BenchmarkDotNet.Analyzers.Tests'">
     <ProjectReference Include="$(MSBuildThisFileDirectory)..\src\BenchmarkDotNet.Analyzers\BenchmarkDotNet.Analyzers.csproj" ReferenceOutputAssembly="false" OutputItemType="Analyzer" />
