From 9b917e4c29753132ad45f72acb8e60b70307f454 Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 8 Apr 2025 22:08:20 +0200 Subject: [PATCH 1/8] Update GitHub Action --- .github/workflows/runTests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/runTests.yml b/.github/workflows/runTests.yml index 294d0c5..5449cd9 100644 --- a/.github/workflows/runTests.yml +++ b/.github/workflows/runTests.yml @@ -9,11 +9,11 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4.2.2 - uses: dart-lang/setup-dart@v1 - name: Install dependencies - run: dart pub get + run: flutter pub get - name: Verify formatting run: dart format --output=none --set-exit-if-changed . From 9d9d08d3496207b95c95bff2a8b42270a8f02848 Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 8 Apr 2025 22:09:53 +0200 Subject: [PATCH 2/8] Update GitHub Action --- .github/workflows/runTests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/runTests.yml b/.github/workflows/runTests.yml index 5449cd9..9373662 100644 --- a/.github/workflows/runTests.yml +++ b/.github/workflows/runTests.yml @@ -13,7 +13,7 @@ jobs: - uses: dart-lang/setup-dart@v1 - name: Install dependencies - run: flutter pub get + run: dart pub get - name: Verify formatting run: dart format --output=none --set-exit-if-changed . From 546be8fcdb237cb9b5c765c80b5979e8c68c94dd Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 8 Apr 2025 22:13:15 +0200 Subject: [PATCH 3/8] Update GitHub Action --- .github/workflows/runTests.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/runTests.yml b/.github/workflows/runTests.yml index 9373662..d10cbc1 100644 --- a/.github/workflows/runTests.yml +++ b/.github/workflows/runTests.yml @@ -10,10 +10,15 @@ jobs: steps: - uses: actions/checkout@v4.2.2 - - uses: dart-lang/setup-dart@v1 + + - name: Set up Flutter + uses: subosito/flutter-action@v2 + with: + channel: stable + flutter-version-file: pubspec.yaml - name: Install dependencies - run: dart pub get + run: flutter pub get - name: Verify formatting run: dart format --output=none --set-exit-if-changed . From b675c8e8f8923e0987744884ef51fdf725a903be Mon Sep 17 00:00:00 2001 From: Moritz Date: Wed, 9 Apr 2025 20:59:34 +0200 Subject: [PATCH 4/8] Update GitHub Action --- .github/workflows/runTests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/runTests.yml b/.github/workflows/runTests.yml index d10cbc1..838285e 100644 --- a/.github/workflows/runTests.yml +++ b/.github/workflows/runTests.yml @@ -2,7 +2,7 @@ name: Run tests on: push: - branches: [ master, develop ] + branches: [ master, develop, feature/update-2025 ] jobs: build: @@ -15,7 +15,7 @@ jobs: uses: subosito/flutter-action@v2 with: channel: stable - flutter-version-file: pubspec.yaml + flutter-version: 3.29.2 - name: Install dependencies run: flutter pub get From dd83d175f47e283012df477e501aae43ce91a776 Mon Sep 17 00:00:00 2001 From: Moritz Date: Wed, 9 Apr 2025 21:51:48 +0200 Subject: [PATCH 5/8] Fix book example --- example/book_example.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/example/book_example.dart b/example/book_example.dart index 2d3dbe7..6a13a27 100644 --- a/example/book_example.dart +++ b/example/book_example.dart @@ -15,9 +15,9 @@ void main() async { print(chapters.docs); Response booksExceptFirstOne = await lotrApi.getBooks( - pagination: Pagination(limit: 2, page: 1, offset: 0), + pagination: Pagination(limit: 2, page: 1, offset: 1), sorting: BookSortings.byNameAsc, - idFilters: [Matches(firstBookId)], + idFilters: [NotMatches(firstBookId)], ); print(booksExceptFirstOne); } From d897e8d31239225130d86201e2a955e0467d42ae Mon Sep 17 00:00:00 2001 From: Moritz Date: Fri, 11 Apr 2025 18:59:12 +0200 Subject: [PATCH 6/8] Comment sorting until this issue is fixed: https://github.com/gitfrosh/lotr-api/issues/188 --- example/README.md | 3 ++- example/book_example.dart | 3 ++- example/chapter_example.dart | 3 ++- example/movie_example.dart | 3 ++- example/quote_example.dart | 3 ++- pubspec.yaml | 2 +- 6 files changed, 11 insertions(+), 6 deletions(-) diff --git a/example/README.md b/example/README.md index 177ccb7..8402e4e 100644 --- a/example/README.md +++ b/example/README.md @@ -12,7 +12,8 @@ void main() async { pagination: Pagination( limit: 10, ), - sorting: QuoteSortings.byIdAsc, + // https://github.com/gitfrosh/lotr-api/issues/188 + // sorting: QuoteSortings.byIdAsc, idFilters: [ Exists(), ], diff --git a/example/book_example.dart b/example/book_example.dart index 6a13a27..9d681df 100644 --- a/example/book_example.dart +++ b/example/book_example.dart @@ -16,7 +16,8 @@ void main() async { Response booksExceptFirstOne = await lotrApi.getBooks( pagination: Pagination(limit: 2, page: 1, offset: 1), - sorting: BookSortings.byNameAsc, + // https://github.com/gitfrosh/lotr-api/issues/188 + // sorting: BookSortings.byNameAsc, idFilters: [NotMatches(firstBookId)], ); print(booksExceptFirstOne); diff --git a/example/chapter_example.dart b/example/chapter_example.dart index 741c49c..0148602 100644 --- a/example/chapter_example.dart +++ b/example/chapter_example.dart @@ -8,7 +8,8 @@ void main(List args) async { var lotrApi = LotrApi(apiKey: args.first); Response chapters = await lotrApi.getChapters( - sorting: ChapterSortings.byChapterNameAsc, + // https://github.com/gitfrosh/lotr-api/issues/188 + // sorting: ChapterSortings.byChapterNameAsc, ); print(chapters); diff --git a/example/movie_example.dart b/example/movie_example.dart index 022edf9..f1503a8 100644 --- a/example/movie_example.dart +++ b/example/movie_example.dart @@ -9,7 +9,8 @@ void main(List args) async { Response response = await lotrApi.getMovies( nameFilters: [Exists()], budgetInMillionsFilters: [GreaterThanOrEquals(100), LessThan(250)], - sorting: MovieSortings.byAcademyAwardWinsDesc, + // https://github.com/gitfrosh/lotr-api/issues/188 + // sorting: MovieSortings.byAcademyAwardWinsDesc, ); print(response); diff --git a/example/quote_example.dart b/example/quote_example.dart index d88c651..afd49eb 100644 --- a/example/quote_example.dart +++ b/example/quote_example.dart @@ -8,7 +8,8 @@ void main(List args) async { var lotrApi = LotrApi(apiKey: args.first); Response quotes = await lotrApi.getQuotes( - sorting: QuoteSortings.byDialogAsc, + // https://github.com/gitfrosh/lotr-api/issues/188 + // sorting: QuoteSortings.byDialogAsc, pagination: Pagination(limit: 10, offset: 2), dialogFilters: [MatchesRegex('Frodo')], ); diff --git a/pubspec.yaml b/pubspec.yaml index 15c7b08..19001c4 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,5 +1,5 @@ name: lotr_api -version: 1.0.0 +version: 0.1.0 description: API that accesses data on quotes, characters, books, etc. from the Tolkien universe. homepage: https://github.com/finkmoritz/lotr_api repository: https://github.com/finkmoritz/lotr_api From 100f37aa45cabdba66a28d416c87b8964a76dad7 Mon Sep 17 00:00:00 2001 From: Moritz Date: Fri, 11 Apr 2025 19:04:35 +0200 Subject: [PATCH 7/8] Run tests on every push and pull request --- .github/workflows/runTests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/runTests.yml b/.github/workflows/runTests.yml index 838285e..d1ff69a 100644 --- a/.github/workflows/runTests.yml +++ b/.github/workflows/runTests.yml @@ -2,7 +2,7 @@ name: Run tests on: push: - branches: [ master, develop, feature/update-2025 ] + pull_request: jobs: build: From 88523d214a7907f5064f84d754e3c2d09710c555 Mon Sep 17 00:00:00 2001 From: Moritz Date: Fri, 11 Apr 2025 19:06:25 +0200 Subject: [PATCH 8/8] Prepare release 0.1.0 --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 52dc807..3d8db92 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,4 @@ -# 1.0.0 (2025-04-08) +# 0.1.0 (2025-04-11) * Improve dart docs