refactor: improve partitioning code

Author: cabljac

firestore-bigquery-export/firestore-bigquery-change-tracker/package.json

@@ -5,7 +5,7 @@
     "url": "github.com/firebase/extensions.git",
     "directory": "firestore-bigquery-export/firestore-bigquery-change-tracker"
   },
-  "version": "1.1.38",
+  "version": "2.0.0",
   "description": "Core change-tracker library for Cloud Firestore Collection BigQuery Exports",
   "main": "./lib/index.js",
   "scripts": {

firestore-bigquery-export/firestore-bigquery-change-tracker/src/bigquery/index.ts

@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import * as admin from "firebase-admin";
 import * as bigquery from "@google-cloud/bigquery";
 import { DocumentReference } from "firebase-admin/firestore";
 import * as traverse from "traverse";
@@ -45,25 +44,9 @@ import { tableRequiresUpdate, viewRequiresUpdate } from "./checkUpdates";
 import { parseErrorMessage, waitForInitialization } from "./utils";
 
 export { RawChangelogSchema, RawChangelogViewSchema } from "./schema";
-
-export interface FirestoreBigQueryEventHistoryTrackerConfig {
-  datasetId: string;
-  tableId: string;
-  datasetLocation?: string | undefined;
-  transformFunction?: string | undefined;
-  timePartitioning?: string | undefined;
-  timePartitioningField?: string | undefined;
-  timePartitioningFieldType?: string | undefined;
-  timePartitioningFirestoreField?: string | undefined;
-  clustering: string[] | null;
-  databaseId?: string | undefined;
-  wildcardIds?: boolean;
-  bqProjectId?: string | undefined;
-  backupTableId?: string | undefined;
-  useNewSnapshotQuerySyntax?: boolean;
-  skipInit?: boolean;
-  kmsKeyName?: string | undefined;
-}
+import type { Config } from "./types";
+import { PartitioningConfig } from "./partitioning/config";
+export type { Config } from "./types";
 
 /**
  * An FirestoreEventHistoryTracker that exports data to BigQuery.
@@ -80,12 +63,15 @@ export class FirestoreBigQueryEventHistoryTracker
 {
   bq: bigquery.BigQuery;
   _initialized: boolean = false;
+  partitioningConfig: PartitioningConfig;
 
-  constructor(public config: FirestoreBigQueryEventHistoryTrackerConfig) {
+  constructor(public config: Config) {
     this.bq = new bigquery.BigQuery();
 
     this.bq.projectId = config.bqProjectId || process.env.PROJECT_ID;
 
+    this.partitioningConfig = new PartitioningConfig(this.config.partitioning);
+
     if (!this.config.datasetLocation) {
       this.config.datasetLocation = "us";
     }
@@ -96,7 +82,7 @@ export class FirestoreBigQueryEventHistoryTracker
       await this.initialize();
     }
 
-    const partitionHandler = new Partitioning(this.config);
+    const partitionHandler = new Partitioning(this.partitioningConfig);
 
     const rows = events.map((event) => {
       const partitionValue = partitionHandler.getPartitionValue(event);
@@ -327,7 +313,7 @@ export class FirestoreBigQueryEventHistoryTracker
     const dataset = this.bigqueryDataset();
     const table = dataset.table(changelogName);
     const [tableExists] = await table.exists();
-    const partitioning = new Partitioning(this.config, table);
+    const partitioning = new Partitioning(this.partitioningConfig, table);
     const clustering = new Clustering(this.config, table);
 
     if (tableExists) {