Fix storage emulator env formatting (#1257)

* Fix storage emulator env formatting

* Repair test

* Rename test

* Dang tests 2 good 4 me

* Fix test

* Fix tests again

Author: abeisgoat

src/storage/storage.ts

@@ -49,7 +49,16 @@ export class Storage implements StorageInterface {
     }
 
     if (!process.env.STORAGE_EMULATOR_HOST && process.env.FIREBASE_STORAGE_EMULATOR_HOST) {
-      process.env.STORAGE_EMULATOR_HOST = process.env.FIREBASE_STORAGE_EMULATOR_HOST;
+      const firebaseStorageEmulatorHost = process.env.FIREBASE_STORAGE_EMULATOR_HOST;
+
+      if (firebaseStorageEmulatorHost.match(/https?:\/\//)) {
+        throw new FirebaseError({
+          code: 'storage/invalid-emulator-host',
+          message: 'FIREBASE_STORAGE_EMULATOR_HOST should not contain a protocol (http or https).',
+        });
+      }
+
+      process.env.STORAGE_EMULATOR_HOST = `http://${process.env.FIREBASE_STORAGE_EMULATOR_HOST}`;
     }
 
     let storage: typeof StorageClient;

test/unit/storage/storage.spec.ts

@@ -114,18 +114,27 @@ describe('Storage', () => {
     });
   });
 
-  describe('Emulator mode', () => {
-    const EMULATOR_HOST = 'http://localhost:9199';
+  describe.only('Emulator mode', () => {
+    const VALID_EMULATOR_HOST = 'localhost:9199';
+    const INVALID_EMULATOR_HOST = 'https://localhost:9199';
 
-    before(() => {
+    beforeEach(() => {
       delete process.env.STORAGE_EMULATOR_HOST;
-      process.env.FIREBASE_STORAGE_EMULATOR_HOST = EMULATOR_HOST;
+      delete process.env.FIREBASE_STORAGE_EMULATOR_HOST;
     });
 
     it('sets STORAGE_EMULATOR_HOST if FIREBASE_STORAGE_EMULATOR_HOST is set', () => {
-      new Storage(mockApp);
-      
-      expect(process.env.STORAGE_EMULATOR_HOST).to.equal(EMULATOR_HOST);
+      process.env.FIREBASE_STORAGE_EMULATOR_HOST = VALID_EMULATOR_HOST;
+
+      new Storage(mockApp)
+      expect(process.env.STORAGE_EMULATOR_HOST).to.equal(`http://${VALID_EMULATOR_HOST}`);
+    });
+
+    it('throws if FIREBASE_STORAGE_EMULATOR_HOST has a protocol', () => {
+      process.env.FIREBASE_STORAGE_EMULATOR_HOST = INVALID_EMULATOR_HOST;
+
+      expect(() => new Storage(mockApp)).to.throw(
+        'FIREBASE_STORAGE_EMULATOR_HOST should not contain a protocol');
     });
 
     after(() => {