Fix @types/node conflict with grpc and port type (#1258)

nikhilag · web-flow · commit ab034f5f4317 · 2021-05-10T17:44:55.000-04:00
Upgraded the @types/node dependency to v12.12.47
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -58,7 +58,7 @@
   "dependencies": {
     "@firebase/database": "^0.10.0",
     "@firebase/database-types": "^0.7.2",
-    "@types/node": "^10.10.0",
+    "@types/node": ">=12.12.47",
     "dicer": "^0.3.0",
     "jsonwebtoken": "^8.5.1",
     "jwks-rsa": "^2.0.2",
diff --git a/src/utils/api-request.ts b/src/utils/api-request.ts
@@ -728,7 +728,7 @@ class HttpRequestConfigImpl implements HttpRequestConfig {
   public buildRequestOptions(): https.RequestOptions {
     const parsed = this.buildUrl();
     const protocol = parsed.protocol;
-    let port: string | undefined = parsed.port;
+    let port: string | null = parsed.port;
     if (!port) {
       const isHttps = protocol === 'https:';
       port = isHttps ? '443' : '80';
