Commit 6323357
authored
Added logic to retry transient failures for all operations in desktop storage implementation. (#824)
* Update GetBytes to repreatedly sent requests until one succeeds
* Generalized retry logic, added retry to GetFile, added exponential backoff, no longer cancel once deadline is reached, just don't retry after this point. Added integration test that retries 404 errors.
* some minor cleanup - removed temporary debug logs in the integration test, defined constants for initial and max sleep time
* Make changes based on review feedback
* Changes based on review feedback
* Add retry logic to all operations in desktop storage implementation, not just get bytes
* Only extern g_retry_file_not_found_for_testing in FIREBASE_PLATFORM_DESKTOP version of integration tests
* Add integration tests to retry GetBytes, GetFile, GetMetadata, and Delete
* Add integration test to retry PutFile by having nonexistent local file
* Update release notes
* single variable to retry all errors and other minor review feedback
* Remove unused include1 parent dcb0b3b commit 6323357
File tree
4 files changed
+756
-82
lines changed- release_build_files
- storage
- integration_test/src
- src/desktop
4 files changed
+756
-82
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
573 | 573 | | |
574 | 574 | | |
575 | 575 | | |
| 576 | + | |
576 | 577 | | |
577 | 578 | | |
578 | 579 | | |
| |||
0 commit comments