From 40ce259935410232d655c8f9dd07d56c750b30fd Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 25 Sep 2025 16:10:30 -0400 Subject: [PATCH 01/25] fix: zip qs testing workflows --- .github/workflows/zip.yml | 49 +++++++++++++++++++++------------------ 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 570bce868fd..a6a49a3ed90 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -6,6 +6,11 @@ permissions: actions: read contents: read +env: + # When a run_id is specified, build jobs will be skipped and the specified + # run's artifacts will be used for testing. + PINNED_RUN_ID: '17965877651' + on: pull_request: paths: @@ -44,7 +49,7 @@ jobs: if: | github.repository == 'firebase/firebase-ios-sdk' && contains(fromJSON('["schedule", "pull_request", "workflow_dispatch"]'), github.event_name) && - github.event.inputs.zip_run_id == '' + github.event.inputs.zip_run_id == '' && github.env.PINNED_RUN_ID == '' runs-on: macos-14 steps: - uses: actions/checkout@v4 @@ -75,7 +80,7 @@ jobs: if: | github.repository == 'firebase/firebase-ios-sdk' && contains(fromJSON('["schedule", "pull_request", "workflow_dispatch"]'), github.event_name) && - github.event.inputs.zip_run_id == '' + github.event.inputs.zip_run_id == '' && github.env.PINNED_RUN_ID == '' runs-on: macos-14 steps: - uses: actions/checkout@v4 @@ -119,7 +124,7 @@ jobs: quickstart_framework_abtesting: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "ABTesting" @@ -136,7 +141,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -172,7 +177,7 @@ jobs: quickstart_framework_auth: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Authentication" @@ -190,7 +195,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -223,7 +228,7 @@ jobs: quickstart_framework_config: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Config" @@ -240,7 +245,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -272,7 +277,7 @@ jobs: quickstart_framework_crashlytics: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Crashlytics" @@ -289,7 +294,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -338,7 +343,7 @@ jobs: quickstart_framework_database: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Database" @@ -354,7 +359,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -390,7 +395,7 @@ jobs: quickstart_framework_firestore: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Firestore" @@ -407,7 +412,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -447,7 +452,7 @@ jobs: check_framework_firestore_symbols: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} env: FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT: 1 runs-on: macos-14 @@ -459,7 +464,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: Firebase-actions-dir - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Setup Bundler @@ -479,7 +484,7 @@ jobs: quickstart_framework_inappmessaging: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "InAppMessaging" @@ -496,7 +501,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -532,7 +537,7 @@ jobs: quickstart_framework_messaging: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Messaging" @@ -549,7 +554,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -585,7 +590,7 @@ jobs: quickstart_framework_storage: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Storage" @@ -602,7 +607,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode From c72026c05c7a30ca7965180ef28e65bb20ec2156 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 25 Sep 2025 16:33:25 -0400 Subject: [PATCH 02/25] maybe --- .github/workflows/zip.yml | 44 +++++++++++++++++++-------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index a6a49a3ed90..28d227ad32e 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -49,7 +49,7 @@ jobs: if: | github.repository == 'firebase/firebase-ios-sdk' && contains(fromJSON('["schedule", "pull_request", "workflow_dispatch"]'), github.event_name) && - github.event.inputs.zip_run_id == '' && github.env.PINNED_RUN_ID == '' + github.event.inputs.zip_run_id == '' && env.PINNED_RUN_ID == '' runs-on: macos-14 steps: - uses: actions/checkout@v4 @@ -80,7 +80,7 @@ jobs: if: | github.repository == 'firebase/firebase-ios-sdk' && contains(fromJSON('["schedule", "pull_request", "workflow_dispatch"]'), github.event_name) && - github.event.inputs.zip_run_id == '' && github.env.PINNED_RUN_ID == '' + github.event.inputs.zip_run_id == '' && env.PINNED_RUN_ID == '' runs-on: macos-14 steps: - uses: actions/checkout@v4 @@ -124,7 +124,7 @@ jobs: quickstart_framework_abtesting: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "ABTesting" @@ -141,7 +141,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -177,7 +177,7 @@ jobs: quickstart_framework_auth: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Authentication" @@ -195,7 +195,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -228,7 +228,7 @@ jobs: quickstart_framework_config: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Config" @@ -245,7 +245,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -277,7 +277,7 @@ jobs: quickstart_framework_crashlytics: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Crashlytics" @@ -294,7 +294,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -343,7 +343,7 @@ jobs: quickstart_framework_database: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Database" @@ -359,7 +359,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -395,7 +395,7 @@ jobs: quickstart_framework_firestore: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Firestore" @@ -412,7 +412,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -452,7 +452,7 @@ jobs: check_framework_firestore_symbols: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} env: FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT: 1 runs-on: macos-14 @@ -464,7 +464,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: Firebase-actions-dir - run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Setup Bundler @@ -484,7 +484,7 @@ jobs: quickstart_framework_inappmessaging: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "InAppMessaging" @@ -501,7 +501,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -537,7 +537,7 @@ jobs: quickstart_framework_messaging: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Messaging" @@ -554,7 +554,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -590,7 +590,7 @@ jobs: quickstart_framework_storage: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || github.env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Storage" @@ -607,7 +607,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode From 23b83d97611f9ff96da263a37f66e5b6c9d8f0d0 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 25 Sep 2025 16:41:56 -0400 Subject: [PATCH 03/25] work --- .github/workflows/zip.yml | 46 ++++++++++++++++++++------------------- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 28d227ad32e..4b56af10736 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -47,9 +47,10 @@ jobs: package-release: # Don't run on private repo. if: | + false && github.repository == 'firebase/firebase-ios-sdk' && contains(fromJSON('["schedule", "pull_request", "workflow_dispatch"]'), github.event_name) && - github.event.inputs.zip_run_id == '' && env.PINNED_RUN_ID == '' + github.event.inputs.zip_run_id == '' runs-on: macos-14 steps: - uses: actions/checkout@v4 @@ -78,9 +79,10 @@ jobs: build: # Don't run on private repo unless it is a PR. if: | + false && github.repository == 'firebase/firebase-ios-sdk' && contains(fromJSON('["schedule", "pull_request", "workflow_dispatch"]'), github.event_name) && - github.event.inputs.zip_run_id == '' && env.PINNED_RUN_ID == '' + github.event.inputs.zip_run_id == '' runs-on: macos-14 steps: - uses: actions/checkout@v4 @@ -124,7 +126,7 @@ jobs: quickstart_framework_abtesting: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "ABTesting" @@ -141,7 +143,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -177,7 +179,7 @@ jobs: quickstart_framework_auth: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Authentication" @@ -195,7 +197,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -228,7 +230,7 @@ jobs: quickstart_framework_config: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Config" @@ -245,7 +247,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -277,7 +279,7 @@ jobs: quickstart_framework_crashlytics: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Crashlytics" @@ -294,7 +296,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -343,7 +345,7 @@ jobs: quickstart_framework_database: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Database" @@ -359,7 +361,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -395,7 +397,7 @@ jobs: quickstart_framework_firestore: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Firestore" @@ -412,7 +414,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -452,7 +454,7 @@ jobs: check_framework_firestore_symbols: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT: 1 runs-on: macos-14 @@ -464,7 +466,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: Firebase-actions-dir - run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Setup Bundler @@ -484,7 +486,7 @@ jobs: quickstart_framework_inappmessaging: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "InAppMessaging" @@ -501,7 +503,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -537,7 +539,7 @@ jobs: quickstart_framework_messaging: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Messaging" @@ -554,7 +556,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -590,7 +592,7 @@ jobs: quickstart_framework_storage: needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '' || env.PINNED_RUN_ID != '') }} + if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Storage" @@ -607,7 +609,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID != '' || github.run_id }} + run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode From 214795ba339ce931818917a1238dea96a1a95a82 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 25 Sep 2025 16:53:05 -0400 Subject: [PATCH 04/25] d --- .github/workflows/zip.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 4b56af10736..0f12e91e1fb 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -111,6 +111,7 @@ jobs: run: ./scripts/setup_bundler.sh - name: ZipBuildingTest run: | + exit 0 mkdir -p zip_output_dir sh -x scripts/build_zip.sh \ zip_output_dir "${{ github.event.inputs.custom_spec_repos || 'https://github.com/firebase/SpecsStaging.git,https://github.com/firebase/SpecsDev.git' }}" \ From 8cb218ee879ff060e58525e6f56b13edb68a6b50 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 25 Sep 2025 17:12:06 -0400 Subject: [PATCH 05/25] d --- .github/workflows/zip.yml | 195 +++++++++++++++++++------------------- 1 file changed, 97 insertions(+), 98 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 0f12e91e1fb..256538bc45c 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -44,90 +44,89 @@ concurrency: cancel-in-progress: true jobs: - package-release: - # Don't run on private repo. - if: | - false && - github.repository == 'firebase/firebase-ios-sdk' && - contains(fromJSON('["schedule", "pull_request", "workflow_dispatch"]'), github.event_name) && - github.event.inputs.zip_run_id == '' - runs-on: macos-14 - steps: - - uses: actions/checkout@v4 - - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 - with: - cache_key: package-release - - name: Xcode 16.2 - run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Setup Bundler - run: ./scripts/setup_bundler.sh - - name: ZipBuildingTest - run: | - mkdir -p release_zip_dir - sh -x scripts/build_zip.sh release_zip_dir \ - "${{ github.event.inputs.custom_spec_repos || 'https://github.com/firebase/SpecsStaging.git' }}" \ - build-release \ - static - - uses: actions/upload-artifact@v4 - with: - name: Firebase-release-zip-zip - # Zip the entire output directory since the builder adds subdirectories we don't know the - # name of. - path: release_zip_dir + # package-release: + # # Don't run on private repo. + # if: | + # false && + # github.repository == 'firebase/firebase-ios-sdk' && + # contains(fromJSON('["schedule", "pull_request", "workflow_dispatch"]'), github.event_name) && + # github.event.inputs.zip_run_id == '' + # runs-on: macos-14 + # steps: + # - uses: actions/checkout@v4 + # - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 + # with: + # cache_key: package-release + # - name: Xcode 16.2 + # run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer + # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 + # - name: Setup Bundler + # run: ./scripts/setup_bundler.sh + # - name: ZipBuildingTest + # run: | + # mkdir -p release_zip_dir + # sh -x scripts/build_zip.sh release_zip_dir \ + # "${{ github.event.inputs.custom_spec_repos || 'https://github.com/firebase/SpecsStaging.git' }}" \ + # build-release \ + # static + # - uses: actions/upload-artifact@v4 + # with: + # name: Firebase-release-zip-zip + # # Zip the entire output directory since the builder adds subdirectories we don't know the + # # name of. + # path: release_zip_dir - build: - # Don't run on private repo unless it is a PR. - if: | - false && - github.repository == 'firebase/firebase-ios-sdk' && - contains(fromJSON('["schedule", "pull_request", "workflow_dispatch"]'), github.event_name) && - github.event.inputs.zip_run_id == '' - runs-on: macos-14 - steps: - - uses: actions/checkout@v4 - - name: Xcode 16.2 - run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer - - name: Build - run: | - cd ReleaseTooling - swift build -v + # build: + # # Don't run on private repo unless it is a PR. + # if: | + # false && + # github.repository == 'firebase/firebase-ios-sdk' && + # contains(fromJSON('["schedule", "pull_request", "workflow_dispatch"]'), github.event_name) && + # github.event.inputs.zip_run_id == '' + # runs-on: macos-14 + # steps: + # - uses: actions/checkout@v4 + # - name: Xcode 16.2 + # run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer + # - name: Build + # run: | + # cd ReleaseTooling + # swift build -v - package-head: - needs: build - strategy: - matrix: - linking_type: [static, dynamic] - runs-on: macos-14 - steps: - - uses: actions/checkout@v4 - - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 - with: - cache_key: package-head - - name: Xcode 16.2 - run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Setup Bundler - run: ./scripts/setup_bundler.sh - - name: ZipBuildingTest - run: | - exit 0 - mkdir -p zip_output_dir - sh -x scripts/build_zip.sh \ - zip_output_dir "${{ github.event.inputs.custom_spec_repos || 'https://github.com/firebase/SpecsStaging.git,https://github.com/firebase/SpecsDev.git' }}" \ - build-head \ - ${{ matrix.linking_type }} - - uses: actions/upload-artifact@v4 - if: ${{ always() }} - with: - name: ${{ matrix.linking_type == 'static' && 'Firebase-actions-dir' || 'Firebase-actions-dir-dynamic' }} - # Zip the entire output directory since the builder adds subdirectories we don't know the - # name of. - path: zip_output_dir + # package-head: + # needs: build + # strategy: + # matrix: + # linking_type: [static, dynamic] + # runs-on: macos-14 + # steps: + # - uses: actions/checkout@v4 + # - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 + # with: + # cache_key: package-head + # - name: Xcode 16.2 + # run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer + # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 + # - name: Setup Bundler + # run: ./scripts/setup_bundler.sh + # - name: ZipBuildingTest + # run: | + # mkdir -p zip_output_dir + # sh -x scripts/build_zip.sh \ + # zip_output_dir "${{ github.event.inputs.custom_spec_repos || 'https://github.com/firebase/SpecsStaging.git,https://github.com/firebase/SpecsDev.git' }}" \ + # build-head \ + # ${{ matrix.linking_type }} + # - uses: actions/upload-artifact@v4 + # if: ${{ always() }} + # with: + # name: ${{ matrix.linking_type == 'static' && 'Firebase-actions-dir' || 'Firebase-actions-dir-dynamic' }} + # # Zip the entire output directory since the builder adds subdirectories we don't know the + # # name of. + # path: zip_output_dir quickstart_framework_abtesting: - needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "ABTesting" @@ -179,8 +178,8 @@ jobs: # path: quickstart-ios/ quickstart_framework_auth: - needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Authentication" @@ -230,8 +229,8 @@ jobs: # path: quickstart-ios/ quickstart_framework_config: - needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Config" @@ -279,8 +278,8 @@ jobs: # path: quickstart-ios/ quickstart_framework_crashlytics: - needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Crashlytics" @@ -345,8 +344,8 @@ jobs: # path: quickstart-ios/ quickstart_framework_database: - needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Database" @@ -397,8 +396,8 @@ jobs: # path: quickstart-ios/ quickstart_framework_firestore: - needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Firestore" @@ -454,8 +453,8 @@ jobs: # path: quickstart_artifacts_firestore.zip check_framework_firestore_symbols: - needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT: 1 runs-on: macos-14 @@ -486,8 +485,8 @@ jobs: "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/FirebaseFirestoreInternal.xcframework quickstart_framework_inappmessaging: - needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "InAppMessaging" @@ -539,8 +538,8 @@ jobs: # path: quickstart-ios/ quickstart_framework_messaging: - needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Messaging" @@ -592,8 +591,8 @@ jobs: # path: quickstart-ios/ quickstart_framework_storage: - needs: package-head - if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} SDK: "Storage" From c1b3f0f863fd25935ea9ff9616d786a1bd32fe0e Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 25 Sep 2025 17:16:06 -0400 Subject: [PATCH 06/25] zip --- .github/workflows/zip.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 256538bc45c..e38d7240bd1 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -132,7 +132,7 @@ jobs: SDK: "ABTesting" strategy: matrix: - artifact: [Firebase-actions-dir, Firebase-actions-dir-dynamic] + artifact: [Firebase-actions-dir] build-env: - os: macos-15 xcode: Xcode_16.4 @@ -186,7 +186,7 @@ jobs: strategy: matrix: os: [macos-15] - artifact: [Firebase-actions-dir, Firebase-actions-dir-dynamic] + artifact: [Firebase-actions-dir] include: - os: macos-15 xcode: Xcode_16.4 @@ -236,7 +236,7 @@ jobs: SDK: "Config" strategy: matrix: - artifact: [Firebase-actions-dir, Firebase-actions-dir-dynamic] + artifact: [Firebase-actions-dir] build-env: - os: macos-15 xcode: Xcode_16.4 @@ -285,7 +285,7 @@ jobs: SDK: "Crashlytics" strategy: matrix: - artifact: [Firebase-actions-dir, Firebase-actions-dir-dynamic] + artifact: [Firebase-actions-dir] build-env: - os: macos-15 xcode: Xcode_16.4 @@ -353,7 +353,7 @@ jobs: matrix: os: [macos-14] xcode: [Xcode_16.2] - artifact: [Firebase-actions-dir, Firebase-actions-dir-dynamic] + artifact: [Firebase-actions-dir] runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v4 @@ -403,7 +403,7 @@ jobs: SDK: "Firestore" strategy: matrix: - artifact: [Firebase-actions-dir, Firebase-actions-dir-dynamic] + artifact: [Firebase-actions-dir] build-env: - os: macos-15 xcode: Xcode_16.4 @@ -492,7 +492,7 @@ jobs: SDK: "InAppMessaging" strategy: matrix: - artifact: [Firebase-actions-dir, Firebase-actions-dir-dynamic] + artifact: [Firebase-actions-dir] build-env: - os: macos-15 xcode: Xcode_16.4 @@ -545,7 +545,7 @@ jobs: SDK: "Messaging" strategy: matrix: - artifact: [Firebase-actions-dir, Firebase-actions-dir-dynamic] + artifact: [Firebase-actions-dir] build-env: - os: macos-15 xcode: Xcode_16.4 @@ -598,7 +598,7 @@ jobs: SDK: "Storage" strategy: matrix: - artifact: [Firebase-actions-dir, Firebase-actions-dir-dynamic] + artifact: [Firebase-actions-dir] build-env: - os: macos-15 xcode: Xcode_16.4 From 6f6570f9cc6756d28354c05f4c19bf0ea86c6fd5 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 25 Sep 2025 17:23:28 -0400 Subject: [PATCH 07/25] disable others --- .github/workflows/zip.yml | 918 +++++++++++++++++++------------------- 1 file changed, 459 insertions(+), 459 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index e38d7240bd1..8eb59db0448 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -124,58 +124,58 @@ jobs: # # name of. # path: zip_output_dir - quickstart_framework_abtesting: -# needs: package-head -# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} - env: - plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - SDK: "ABTesting" - strategy: - matrix: - artifact: [Firebase-actions-dir] - build-env: - - os: macos-15 - xcode: Xcode_16.4 - runs-on: ${{ matrix.build-env.os }} - steps: - - uses: actions/checkout@v4 - - name: Get framework dir - uses: actions/download-artifact@v4.1.7 - with: - name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID || github.run_id }} - github-token: ${{ secrets.GITHUB_TOKEN }} - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Xcode - run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer - - name: Setup Bundler - run: ./scripts/setup_bundler.sh - - name: Move frameworks - run: | - mkdir -p "${HOME}"/ios_frameworks/ - find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + - - uses: actions/checkout@v4 - - name: Setup quickstart - run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ - "${HOME}"/ios_frameworks/Firebase/FirebaseRemoteConfig/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/FirebaseCore.xcframework \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/FirebaseCoreInternal.xcframework \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/FBLPromises.xcframework \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/FirebaseInstallations.xcframework \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/GoogleUtilities.xcframework - - name: Install Secret GoogleService-Info.plist - run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-abtesting.plist.gpg \ - quickstart-ios/abtesting/GoogleService-Info.plist "$plist_secret" - - name: Test Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - - name: Remove data before upload - if: ${{ failure() }} - run: scripts/remove_data.sh abtesting - # - uses: actions/upload-artifact@v4 - # if: ${{ failure() }} - # with: - # name: quickstart_artifacts_abtesting - # path: quickstart-ios/ +# quickstart_framework_abtesting: +# # needs: package-head +# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# env: +# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} +# SDK: "ABTesting" +# strategy: +# matrix: +# artifact: [Firebase-actions-dir] +# build-env: +# - os: macos-15 +# xcode: Xcode_16.4 +# runs-on: ${{ matrix.build-env.os }} +# steps: +# - uses: actions/checkout@v4 +# - name: Get framework dir +# uses: actions/download-artifact@v4.1.7 +# with: +# name: ${{ matrix.artifact }} +# run-id: ${{ github.event.inputs.zip_run_id || env.PINNED_RUN_ID || github.run_id }} +# github-token: ${{ secrets.GITHUB_TOKEN }} +# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 +# - name: Xcode +# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer +# - name: Setup Bundler +# run: ./scripts/setup_bundler.sh +# - name: Move frameworks +# run: | +# mkdir -p "${HOME}"/ios_frameworks/ +# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + +# - uses: actions/checkout@v4 +# - name: Setup quickstart +# run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseRemoteConfig/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/FirebaseCore.xcframework \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/FirebaseCoreInternal.xcframework \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/FBLPromises.xcframework \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/FirebaseInstallations.xcframework \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/GoogleUtilities.xcframework +# - name: Install Secret GoogleService-Info.plist +# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-abtesting.plist.gpg \ +# quickstart-ios/abtesting/GoogleService-Info.plist "$plist_secret" +# - name: Test Quickstart +# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") +# - name: Remove data before upload +# if: ${{ failure() }} +# run: scripts/remove_data.sh abtesting +# # - uses: actions/upload-artifact@v4 +# # if: ${{ failure() }} +# # with: +# # name: quickstart_artifacts_abtesting +# # path: quickstart-ios/ quickstart_framework_auth: # needs: package-head @@ -228,418 +228,418 @@ jobs: # name: quickstart_artifacts_auth # path: quickstart-ios/ - quickstart_framework_config: -# needs: package-head -# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} - env: - plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - SDK: "Config" - strategy: - matrix: - artifact: [Firebase-actions-dir] - build-env: - - os: macos-15 - xcode: Xcode_16.4 - runs-on: ${{ matrix.build-env.os }} - steps: - - uses: actions/checkout@v4 - - name: Get framework dir - uses: actions/download-artifact@v4.1.7 - with: - name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} - github-token: ${{ secrets.GITHUB_TOKEN }} - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Xcode - run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer - - name: Setup Bundler - run: ./scripts/setup_bundler.sh - - name: Move frameworks - run: | - mkdir -p "${HOME}"/ios_frameworks/ - find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + - - name: Setup Swift Quickstart +# quickstart_framework_config: +# # needs: package-head +# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# env: +# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} +# SDK: "Config" +# strategy: +# matrix: +# artifact: [Firebase-actions-dir] +# build-env: +# - os: macos-15 +# xcode: Xcode_16.4 +# runs-on: ${{ matrix.build-env.os }} +# steps: +# - uses: actions/checkout@v4 +# - name: Get framework dir +# uses: actions/download-artifact@v4.1.7 +# with: +# name: ${{ matrix.artifact }} +# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# github-token: ${{ secrets.GITHUB_TOKEN }} +# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 +# - name: Xcode +# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer +# - name: Setup Bundler +# run: ./scripts/setup_bundler.sh +# - name: Move frameworks +# run: | +# mkdir -p "${HOME}"/ios_frameworks/ +# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + +# - name: Setup Swift Quickstart - run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ - "${HOME}"/ios_frameworks/Firebase/FirebaseRemoteConfig/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* - - name: Install Secret GoogleService-Info.plist - run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-config.plist.gpg \ - quickstart-ios/config/GoogleService-Info.plist "$plist_secret" - - name: Test Swift Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - - name: Remove data before upload - if: ${{ failure() }} - run: scripts/remove_data.sh config - # - uses: actions/upload-artifact@v4 - # if: ${{ failure() }} - # with: - # name: quickstart_artifacts_config - # path: quickstart-ios/ +# run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseRemoteConfig/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* +# - name: Install Secret GoogleService-Info.plist +# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-config.plist.gpg \ +# quickstart-ios/config/GoogleService-Info.plist "$plist_secret" +# - name: Test Swift Quickstart +# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") +# - name: Remove data before upload +# if: ${{ failure() }} +# run: scripts/remove_data.sh config +# # - uses: actions/upload-artifact@v4 +# # if: ${{ failure() }} +# # with: +# # name: quickstart_artifacts_config +# # path: quickstart-ios/ - quickstart_framework_crashlytics: -# needs: package-head -# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} - env: - plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - SDK: "Crashlytics" - strategy: - matrix: - artifact: [Firebase-actions-dir] - build-env: - - os: macos-15 - xcode: Xcode_16.4 - runs-on: ${{ matrix.build-env.os }} - steps: - - uses: actions/checkout@v4 - - name: Get framework dir - uses: actions/download-artifact@v4.1.7 - with: - name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} - github-token: ${{ secrets.GITHUB_TOKEN }} - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Xcode - run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer - - name: Setup Bundler - run: ./scripts/setup_bundler.sh - - name: Move frameworks - run: | - mkdir -p "${HOME}"/ios_frameworks/ - find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + - - uses: actions/checkout@v4 - - name: Setup quickstart - run: | - SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ - "${HOME}"/ios_frameworks/Firebase/FirebaseCrashlytics/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* - cp quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Firebase/run quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart - cp quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Firebase/upload-symbols quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart - chmod +x quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/run - chmod +x quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/upload-symbols - # TODO(#8057): Restore Swift Quickstart - # - name: Setup swift quickstart - # env: - # LEGACY: true - # run: | - # SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" NON_FIREBASE_SDKS="ReachabilitySwift" scripts/setup_quickstart_framework.sh \ - # "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/* - - name: Install Secret GoogleService-Info.plist - run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-crashlytics.plist.gpg \ - quickstart-ios/crashlytics/GoogleService-Info.plist "$plist_secret" - - name: Test Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - # TODO(#8057): Restore Swift Quickstart - # - name: Test Swift Quickstart - # env: - # LEGACY: true - # run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) - - name: Remove data before upload - if: ${{ failure() }} - run: scripts/remove_data.sh crashlytics - # - uses: actions/upload-artifact@v4 - # if: ${{ failure() }} - # with: - # name: quickstart_artifacts_crashlytics - # path: quickstart-ios/ +# quickstart_framework_crashlytics: +# # needs: package-head +# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# env: +# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} +# SDK: "Crashlytics" +# strategy: +# matrix: +# artifact: [Firebase-actions-dir] +# build-env: +# - os: macos-15 +# xcode: Xcode_16.4 +# runs-on: ${{ matrix.build-env.os }} +# steps: +# - uses: actions/checkout@v4 +# - name: Get framework dir +# uses: actions/download-artifact@v4.1.7 +# with: +# name: ${{ matrix.artifact }} +# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# github-token: ${{ secrets.GITHUB_TOKEN }} +# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 +# - name: Xcode +# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer +# - name: Setup Bundler +# run: ./scripts/setup_bundler.sh +# - name: Move frameworks +# run: | +# mkdir -p "${HOME}"/ios_frameworks/ +# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + +# - uses: actions/checkout@v4 +# - name: Setup quickstart +# run: | +# SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseCrashlytics/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* +# cp quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Firebase/run quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart +# cp quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Firebase/upload-symbols quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart +# chmod +x quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/run +# chmod +x quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/upload-symbols +# # TODO(#8057): Restore Swift Quickstart +# # - name: Setup swift quickstart +# # env: +# # LEGACY: true +# # run: | +# # SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" NON_FIREBASE_SDKS="ReachabilitySwift" scripts/setup_quickstart_framework.sh \ +# # "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/* +# - name: Install Secret GoogleService-Info.plist +# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-crashlytics.plist.gpg \ +# quickstart-ios/crashlytics/GoogleService-Info.plist "$plist_secret" +# - name: Test Quickstart +# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") +# # TODO(#8057): Restore Swift Quickstart +# # - name: Test Swift Quickstart +# # env: +# # LEGACY: true +# # run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) +# - name: Remove data before upload +# if: ${{ failure() }} +# run: scripts/remove_data.sh crashlytics +# # - uses: actions/upload-artifact@v4 +# # if: ${{ failure() }} +# # with: +# # name: quickstart_artifacts_crashlytics +# # path: quickstart-ios/ - quickstart_framework_database: -# needs: package-head -# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} - env: - plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - SDK: "Database" - strategy: - matrix: - os: [macos-14] - xcode: [Xcode_16.2] - artifact: [Firebase-actions-dir] - runs-on: ${{ matrix.os }} - steps: - - uses: actions/checkout@v4 - - name: Get framework dir - uses: actions/download-artifact@v4.1.7 - with: - name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} - github-token: ${{ secrets.GITHUB_TOKEN }} - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Xcode - run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer - - name: Setup Bundler - run: ./scripts/setup_bundler.sh - - name: Move frameworks - run: | - mkdir -p "${HOME}"/ios_frameworks/ - find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + - - uses: actions/checkout@v4 - - name: Setup quickstart - run: SAMPLE="$SDK" TARGET="${SDK}Example" NON_FIREBASE_SDKS="FirebaseDatabaseUI" scripts/setup_quickstart_framework.sh \ - "${HOME}"/ios_frameworks/Firebase/FirebaseDatabase/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseStorage/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \ - "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* - - name: Install Secret GoogleService-Info.plist - run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-database.plist.gpg \ - quickstart-ios/database/GoogleService-Info.plist "$plist_secret" - - name: Test Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - - name: Remove data before upload - if: ${{ failure() }} - run: scripts/remove_data.sh database - # - uses: actions/upload-artifact@v4 - # if: ${{ failure() }} - # with: - # name: quickstart_artifacts database - # path: quickstart-ios/ +# quickstart_framework_database: +# # needs: package-head +# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# env: +# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} +# SDK: "Database" +# strategy: +# matrix: +# os: [macos-14] +# xcode: [Xcode_16.2] +# artifact: [Firebase-actions-dir] +# runs-on: ${{ matrix.os }} +# steps: +# - uses: actions/checkout@v4 +# - name: Get framework dir +# uses: actions/download-artifact@v4.1.7 +# with: +# name: ${{ matrix.artifact }} +# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# github-token: ${{ secrets.GITHUB_TOKEN }} +# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 +# - name: Xcode +# run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer +# - name: Setup Bundler +# run: ./scripts/setup_bundler.sh +# - name: Move frameworks +# run: | +# mkdir -p "${HOME}"/ios_frameworks/ +# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + +# - uses: actions/checkout@v4 +# - name: Setup quickstart +# run: SAMPLE="$SDK" TARGET="${SDK}Example" NON_FIREBASE_SDKS="FirebaseDatabaseUI" scripts/setup_quickstart_framework.sh \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseDatabase/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseStorage/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \ +# "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* +# - name: Install Secret GoogleService-Info.plist +# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-database.plist.gpg \ +# quickstart-ios/database/GoogleService-Info.plist "$plist_secret" +# - name: Test Quickstart +# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") +# - name: Remove data before upload +# if: ${{ failure() }} +# run: scripts/remove_data.sh database +# # - uses: actions/upload-artifact@v4 +# # if: ${{ failure() }} +# # with: +# # name: quickstart_artifacts database +# # path: quickstart-ios/ - quickstart_framework_firestore: -# needs: package-head -# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} - env: - plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - SDK: "Firestore" - strategy: - matrix: - artifact: [Firebase-actions-dir] - build-env: - - os: macos-15 - xcode: Xcode_16.4 - runs-on: ${{ matrix.build-env.os }} - steps: - - uses: actions/checkout@v4 - - name: Get framework dir - uses: actions/download-artifact@v4.1.7 - with: - name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} - github-token: ${{ secrets.GITHUB_TOKEN }} - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Xcode - run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer - - name: Setup Bundler - run: ./scripts/setup_bundler.sh - - name: Move frameworks - run: | - mkdir -p "${HOME}"/ios_frameworks/ - find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + - - uses: actions/checkout@v4 - - name: Setup quickstart - run: SAMPLE="$SDK" TARGET="${SDK}Example" NON_FIREBASE_SDKS="SDWebImage FirebaseAuthUI FirebaseEmailAuthUI" scripts/setup_quickstart_framework.sh \ - "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* - - name: Upload build logs on failure - if: ${{ failure() }} - uses: actions/upload-artifact@v4 - with: - name: build_logs_firestore_${{ matrix.artifact }}_${{ matrix.build-env.os }} - path: sdk_zip/build_logs/ - - name: Install Secret GoogleService-Info.plist - run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-firestore.plist.gpg \ - quickstart-ios/firestore/GoogleService-Info.plist "$plist_secret" - - name: Test Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - - name: Remove data before upload and zip directory to reduce upload size. - if: ${{ failure() }} - run: scripts/remove_data.sh firestore; zip -r --symlinks quickstart_artifacts_firestore.zip quickstart-ios/ - # - uses: actions/upload-artifact@v4 - # if: ${{ failure() }} - # with: - # name: quickstart_artifacts_firestore_${{ matrix.artifact }}_${{ matrix.build-env.os }} - # path: quickstart_artifacts_firestore.zip +# quickstart_framework_firestore: +# # needs: package-head +# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# env: +# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} +# SDK: "Firestore" +# strategy: +# matrix: +# artifact: [Firebase-actions-dir] +# build-env: +# - os: macos-15 +# xcode: Xcode_16.4 +# runs-on: ${{ matrix.build-env.os }} +# steps: +# - uses: actions/checkout@v4 +# - name: Get framework dir +# uses: actions/download-artifact@v4.1.7 +# with: +# name: ${{ matrix.artifact }} +# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# github-token: ${{ secrets.GITHUB_TOKEN }} +# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 +# - name: Xcode +# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer +# - name: Setup Bundler +# run: ./scripts/setup_bundler.sh +# - name: Move frameworks +# run: | +# mkdir -p "${HOME}"/ios_frameworks/ +# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + +# - uses: actions/checkout@v4 +# - name: Setup quickstart +# run: SAMPLE="$SDK" TARGET="${SDK}Example" NON_FIREBASE_SDKS="SDWebImage FirebaseAuthUI FirebaseEmailAuthUI" scripts/setup_quickstart_framework.sh \ +# "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* +# - name: Upload build logs on failure +# if: ${{ failure() }} +# uses: actions/upload-artifact@v4 +# with: +# name: build_logs_firestore_${{ matrix.artifact }}_${{ matrix.build-env.os }} +# path: sdk_zip/build_logs/ +# - name: Install Secret GoogleService-Info.plist +# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-firestore.plist.gpg \ +# quickstart-ios/firestore/GoogleService-Info.plist "$plist_secret" +# - name: Test Quickstart +# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") +# - name: Remove data before upload and zip directory to reduce upload size. +# if: ${{ failure() }} +# run: scripts/remove_data.sh firestore; zip -r --symlinks quickstart_artifacts_firestore.zip quickstart-ios/ +# # - uses: actions/upload-artifact@v4 +# # if: ${{ failure() }} +# # with: +# # name: quickstart_artifacts_firestore_${{ matrix.artifact }}_${{ matrix.build-env.os }} +# # path: quickstart_artifacts_firestore.zip - check_framework_firestore_symbols: -# needs: package-head -# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} - env: - FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT: 1 - runs-on: macos-14 - steps: - - name: Xcode 16.2 - run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer - - uses: actions/checkout@v4 - - name: Get framework dir - uses: actions/download-artifact@v4.1.7 - with: - name: Firebase-actions-dir - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} - github-token: ${{ secrets.GITHUB_TOKEN }} - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Setup Bundler - run: ./scripts/setup_bundler.sh - - name: Install xcpretty - run: gem install xcpretty - - name: Move frameworks - run: | - mkdir -p "${HOME}"/ios_frameworks/ - find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + - - uses: actions/checkout@v4 - - name: Check linked Firestore.xcframework for unlinked symbols. - run: | - scripts/check_firestore_symbols.sh \ - $(pwd) \ - "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/FirebaseFirestoreInternal.xcframework +# check_framework_firestore_symbols: +# # needs: package-head +# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# env: +# FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT: 1 +# runs-on: macos-14 +# steps: +# - name: Xcode 16.2 +# run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer +# - uses: actions/checkout@v4 +# - name: Get framework dir +# uses: actions/download-artifact@v4.1.7 +# with: +# name: Firebase-actions-dir +# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# github-token: ${{ secrets.GITHUB_TOKEN }} +# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 +# - name: Setup Bundler +# run: ./scripts/setup_bundler.sh +# - name: Install xcpretty +# run: gem install xcpretty +# - name: Move frameworks +# run: | +# mkdir -p "${HOME}"/ios_frameworks/ +# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + +# - uses: actions/checkout@v4 +# - name: Check linked Firestore.xcframework for unlinked symbols. +# run: | +# scripts/check_firestore_symbols.sh \ +# $(pwd) \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/FirebaseFirestoreInternal.xcframework - quickstart_framework_inappmessaging: -# needs: package-head -# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} - env: - plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - SDK: "InAppMessaging" - strategy: - matrix: - artifact: [Firebase-actions-dir] - build-env: - - os: macos-15 - xcode: Xcode_16.4 - runs-on: ${{ matrix.build-env.os }} - steps: - - uses: actions/checkout@v4 - - name: Get framework dir - uses: actions/download-artifact@v4.1.7 - with: - name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} - github-token: ${{ secrets.GITHUB_TOKEN }} - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Xcode - run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer - - name: Setup Bundler - run: ./scripts/setup_bundler.sh - - name: Move frameworks - run: | - mkdir -p "${HOME}"/ios_frameworks/ - find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + - - uses: actions/checkout@v4 - - name: Setup quickstart - run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ - "${HOME}"/ios_frameworks/Firebase/FirebaseInAppMessaging/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* - - name: Setup swift quickstart - run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh - - name: Install Secret GoogleService-Info.plist - run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-inappmessaging.plist.gpg \ - quickstart-ios/inappmessaging/GoogleService-Info.plist "$plist_secret" - - name: Test Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - - name: Test Swift Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) - - name: Remove data before upload - if: ${{ failure() }} - run: scripts/remove_data.sh inappmessaging - # - uses: actions/upload-artifact@v4 - # if: ${{ failure() }} - # with: - # name: quickstart_artifacts_inappmessaging - # path: quickstart-ios/ +# quickstart_framework_inappmessaging: +# # needs: package-head +# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# env: +# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} +# SDK: "InAppMessaging" +# strategy: +# matrix: +# artifact: [Firebase-actions-dir] +# build-env: +# - os: macos-15 +# xcode: Xcode_16.4 +# runs-on: ${{ matrix.build-env.os }} +# steps: +# - uses: actions/checkout@v4 +# - name: Get framework dir +# uses: actions/download-artifact@v4.1.7 +# with: +# name: ${{ matrix.artifact }} +# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# github-token: ${{ secrets.GITHUB_TOKEN }} +# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 +# - name: Xcode +# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer +# - name: Setup Bundler +# run: ./scripts/setup_bundler.sh +# - name: Move frameworks +# run: | +# mkdir -p "${HOME}"/ios_frameworks/ +# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + +# - uses: actions/checkout@v4 +# - name: Setup quickstart +# run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseInAppMessaging/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* +# - name: Setup swift quickstart +# run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh +# - name: Install Secret GoogleService-Info.plist +# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-inappmessaging.plist.gpg \ +# quickstart-ios/inappmessaging/GoogleService-Info.plist "$plist_secret" +# - name: Test Quickstart +# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") +# - name: Test Swift Quickstart +# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) +# - name: Remove data before upload +# if: ${{ failure() }} +# run: scripts/remove_data.sh inappmessaging +# # - uses: actions/upload-artifact@v4 +# # if: ${{ failure() }} +# # with: +# # name: quickstart_artifacts_inappmessaging +# # path: quickstart-ios/ - quickstart_framework_messaging: -# needs: package-head -# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} - env: - plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - SDK: "Messaging" - strategy: - matrix: - artifact: [Firebase-actions-dir] - build-env: - - os: macos-15 - xcode: Xcode_16.4 - runs-on: ${{ matrix.build-env.os }} - steps: - - uses: actions/checkout@v4 - - name: Get framework dir - uses: actions/download-artifact@v4.1.7 - with: - name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} - github-token: ${{ secrets.GITHUB_TOKEN }} - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Xcode - run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer - - name: Setup Bundler - run: ./scripts/setup_bundler.sh - - name: Move frameworks - run: | - mkdir -p "${HOME}"/ios_frameworks/ - find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + - - uses: actions/checkout@v4 - - name: Setup quickstart - run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ - "${HOME}"/ios_frameworks/Firebase/FirebaseMessaging/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* - - name: Setup swift quickstart - run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh - - name: Install Secret GoogleService-Info.plist - run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-messaging.plist.gpg \ - quickstart-ios/messaging/GoogleService-Info.plist "$plist_secret" - - name: Test Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - - name: Test Swift Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) - - name: Remove data before upload - if: ${{ failure() }} - run: scripts/remove_data.sh messaging - # - uses: actions/upload-artifact@v4 - # if: ${{ failure() }} - # with: - # name: quickstart_artifacts_messaging - # path: quickstart-ios/ +# quickstart_framework_messaging: +# # needs: package-head +# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# env: +# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} +# SDK: "Messaging" +# strategy: +# matrix: +# artifact: [Firebase-actions-dir] +# build-env: +# - os: macos-15 +# xcode: Xcode_16.4 +# runs-on: ${{ matrix.build-env.os }} +# steps: +# - uses: actions/checkout@v4 +# - name: Get framework dir +# uses: actions/download-artifact@v4.1.7 +# with: +# name: ${{ matrix.artifact }} +# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# github-token: ${{ secrets.GITHUB_TOKEN }} +# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 +# - name: Xcode +# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer +# - name: Setup Bundler +# run: ./scripts/setup_bundler.sh +# - name: Move frameworks +# run: | +# mkdir -p "${HOME}"/ios_frameworks/ +# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + +# - uses: actions/checkout@v4 +# - name: Setup quickstart +# run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseMessaging/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* +# - name: Setup swift quickstart +# run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh +# - name: Install Secret GoogleService-Info.plist +# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-messaging.plist.gpg \ +# quickstart-ios/messaging/GoogleService-Info.plist "$plist_secret" +# - name: Test Quickstart +# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") +# - name: Test Swift Quickstart +# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) +# - name: Remove data before upload +# if: ${{ failure() }} +# run: scripts/remove_data.sh messaging +# # - uses: actions/upload-artifact@v4 +# # if: ${{ failure() }} +# # with: +# # name: quickstart_artifacts_messaging +# # path: quickstart-ios/ - quickstart_framework_storage: -# needs: package-head -# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} - env: - plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - SDK: "Storage" - strategy: - matrix: - artifact: [Firebase-actions-dir] - build-env: - - os: macos-15 - xcode: Xcode_16.4 - runs-on: ${{ matrix.build-env.os }} - steps: - - uses: actions/checkout@v4 - - name: Get framework dir - uses: actions/download-artifact@v4.1.7 - with: - name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} - github-token: ${{ secrets.GITHUB_TOKEN }} - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Xcode - run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer - - name: Setup Bundler - run: ./scripts/setup_bundler.sh - - name: Move frameworks - run: | - mkdir -p "${HOME}"/ios_frameworks/ - find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + - - uses: actions/checkout@v4 - - name: Setup quickstart - run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ - "${HOME}"/ios_frameworks/Firebase/FirebaseStorage/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* - - name: Setup swift quickstart - run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh - - name: Install Secret GoogleService-Info.plist - run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-storage.plist.gpg \ - quickstart-ios/storage/GoogleService-Info.plist "$plist_secret" - - name: Test Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - - name: Test Swift Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) - - name: Remove data before upload - if: ${{ failure() }} - run: scripts/remove_data.sh storage - # - uses: actions/upload-artifact@v4 - # if: ${{ failure() }} - # with: - # name: quickstart_artifacts_storage - # path: quickstart-ios/ +# quickstart_framework_storage: +# # needs: package-head +# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# env: +# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} +# SDK: "Storage" +# strategy: +# matrix: +# artifact: [Firebase-actions-dir] +# build-env: +# - os: macos-15 +# xcode: Xcode_16.4 +# runs-on: ${{ matrix.build-env.os }} +# steps: +# - uses: actions/checkout@v4 +# - name: Get framework dir +# uses: actions/download-artifact@v4.1.7 +# with: +# name: ${{ matrix.artifact }} +# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# github-token: ${{ secrets.GITHUB_TOKEN }} +# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 +# - name: Xcode +# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer +# - name: Setup Bundler +# run: ./scripts/setup_bundler.sh +# - name: Move frameworks +# run: | +# mkdir -p "${HOME}"/ios_frameworks/ +# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + +# - uses: actions/checkout@v4 +# - name: Setup quickstart +# run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseStorage/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* +# - name: Setup swift quickstart +# run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh +# - name: Install Secret GoogleService-Info.plist +# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-storage.plist.gpg \ +# quickstart-ios/storage/GoogleService-Info.plist "$plist_secret" +# - name: Test Quickstart +# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") +# - name: Test Swift Quickstart +# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) +# - name: Remove data before upload +# if: ${{ failure() }} +# run: scripts/remove_data.sh storage +# # - uses: actions/upload-artifact@v4 +# # if: ${{ failure() }} +# # with: +# # name: quickstart_artifacts_storage +# # path: quickstart-ios/ From 85a00e9f16377117d2494b99afd710bfafb662e8 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 26 Sep 2025 10:05:26 -0400 Subject: [PATCH 08/25] zip run id --- .github/workflows/zip.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 8eb59db0448..86f143e52ae 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -197,7 +197,7 @@ jobs: uses: actions/download-artifact@v4.1.7 with: name: ${{ matrix.artifact }} - run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} + run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} github-token: ${{ secrets.GITHUB_TOKEN }} - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - name: Xcode @@ -247,7 +247,7 @@ jobs: # uses: actions/download-artifact@v4.1.7 # with: # name: ${{ matrix.artifact }} -# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} # github-token: ${{ secrets.GITHUB_TOKEN }} # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 # - name: Xcode @@ -296,7 +296,7 @@ jobs: # uses: actions/download-artifact@v4.1.7 # with: # name: ${{ matrix.artifact }} -# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} # github-token: ${{ secrets.GITHUB_TOKEN }} # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 # - name: Xcode @@ -361,7 +361,7 @@ jobs: # uses: actions/download-artifact@v4.1.7 # with: # name: ${{ matrix.artifact }} -# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} # github-token: ${{ secrets.GITHUB_TOKEN }} # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 # - name: Xcode @@ -414,7 +414,7 @@ jobs: # uses: actions/download-artifact@v4.1.7 # with: # name: ${{ matrix.artifact }} -# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} # github-token: ${{ secrets.GITHUB_TOKEN }} # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 # - name: Xcode @@ -466,7 +466,7 @@ jobs: # uses: actions/download-artifact@v4.1.7 # with: # name: Firebase-actions-dir -# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} # github-token: ${{ secrets.GITHUB_TOKEN }} # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 # - name: Setup Bundler @@ -503,7 +503,7 @@ jobs: # uses: actions/download-artifact@v4.1.7 # with: # name: ${{ matrix.artifact }} -# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} # github-token: ${{ secrets.GITHUB_TOKEN }} # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 # - name: Xcode @@ -556,7 +556,7 @@ jobs: # uses: actions/download-artifact@v4.1.7 # with: # name: ${{ matrix.artifact }} -# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} # github-token: ${{ secrets.GITHUB_TOKEN }} # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 # - name: Xcode @@ -609,7 +609,7 @@ jobs: # uses: actions/download-artifact@v4.1.7 # with: # name: ${{ matrix.artifact }} -# run-id: ${{ github.event.inputs.zip_run_id || github.run_id }} +# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} # github-token: ${{ secrets.GITHUB_TOKEN }} # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 # - name: Xcode From d87dddde075362f54378f80b0dab45094e798856 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 26 Sep 2025 10:32:59 -0400 Subject: [PATCH 09/25] branch --- scripts/setup_quickstart_framework.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/setup_quickstart_framework.sh b/scripts/setup_quickstart_framework.sh index 51499ab6efa..5415b6f7518 100755 --- a/scripts/setup_quickstart_framework.sh +++ b/scripts/setup_quickstart_framework.sh @@ -17,6 +17,7 @@ set -ex REPO=`pwd` if [ ! -d "quickstart-ios" ]; then git clone https://github.com/firebase/quickstart-ios.git + git checkout nc/quickstarts fi QS_SCRIPTS="${REPO}"/quickstart-ios/scripts cd quickstart-ios/"${SAMPLE}" From 6da8ca4dd33fae80d5c6f5cdcd11d7469dfb40a9 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 26 Sep 2025 11:24:09 -0400 Subject: [PATCH 10/25] script --- scripts/setup_quickstart_framework.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/setup_quickstart_framework.sh b/scripts/setup_quickstart_framework.sh index 5415b6f7518..1ce75f279d9 100755 --- a/scripts/setup_quickstart_framework.sh +++ b/scripts/setup_quickstart_framework.sh @@ -16,11 +16,11 @@ set -ex REPO=`pwd` if [ ! -d "quickstart-ios" ]; then - git clone https://github.com/firebase/quickstart-ios.git - git checkout nc/quickstarts + git clone https://github.com/firebase/quickstart-ios.git fi QS_SCRIPTS="${REPO}"/quickstart-ios/scripts cd quickstart-ios/"${SAMPLE}" +git checkout nc/quickstarts if [[ ! -z "$LEGACY" ]]; then cd "Legacy${SAMPLE}Quickstart" From 36c784656cb1ce21702b765677462c079e693c0e Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 6 Oct 2025 16:09:25 -0400 Subject: [PATCH 11/25] Apply suggestion from @ncooke3 --- scripts/setup_quickstart_framework.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/setup_quickstart_framework.sh b/scripts/setup_quickstart_framework.sh index 1ce75f279d9..1f6addcbe98 100755 --- a/scripts/setup_quickstart_framework.sh +++ b/scripts/setup_quickstart_framework.sh @@ -16,7 +16,7 @@ set -ex REPO=`pwd` if [ ! -d "quickstart-ios" ]; then - git clone https://github.com/firebase/quickstart-ios.git + git clone https://github.com/firebase/quickstart-ios.git fi QS_SCRIPTS="${REPO}"/quickstart-ios/scripts cd quickstart-ios/"${SAMPLE}" From 4f8f90c96c8e9a3b58a2b6f1e1fc9b46ab87fcb4 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Tue, 7 Oct 2025 10:43:18 -0400 Subject: [PATCH 12/25] Fix .github/workflows/zip.yml --- .github/workflows/zip.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 86f143e52ae..c73b1d03d11 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -221,7 +221,7 @@ jobs: run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - name: Remove data before upload if: ${{ failure() }} - run: scripts/remove_data.sh authentiation + run: scripts/remove_data.sh authentication # - uses: actions/upload-artifact@v4 # if: ${{ failure() }} # with: From 6eaa4e78455deaf35cce261aeb37f6d4514155d7 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Tue, 7 Oct 2025 10:44:21 -0400 Subject: [PATCH 13/25] Remove project deps but not target deps --- scripts/setup_quickstart_framework.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/setup_quickstart_framework.sh b/scripts/setup_quickstart_framework.sh index 1f6addcbe98..f79bd0baa18 100755 --- a/scripts/setup_quickstart_framework.sh +++ b/scripts/setup_quickstart_framework.sh @@ -22,6 +22,10 @@ QS_SCRIPTS="${REPO}"/quickstart-ios/scripts cd quickstart-ios/"${SAMPLE}" git checkout nc/quickstarts +# Remove all SPM dependencies from the project. This is necessary to prepare +# the project for framework-based testing. +"${REPO}"/scripts/remove_spm_dependencies.rb "${SAMPLE}Example.xcodeproj" + if [[ ! -z "$LEGACY" ]]; then cd "Legacy${SAMPLE}Quickstart" fi From 34bd33d18e651d8eb7c1475127ffc1ea99705f35 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Tue, 7 Oct 2025 10:46:42 -0400 Subject: [PATCH 14/25] add scripts/remove_spm_dependencies.rb --- scripts/remove_spm_dependencies.rb | 77 ++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100755 scripts/remove_spm_dependencies.rb diff --git a/scripts/remove_spm_dependencies.rb b/scripts/remove_spm_dependencies.rb new file mode 100755 index 00000000000..9d1fd6df10c --- /dev/null +++ b/scripts/remove_spm_dependencies.rb @@ -0,0 +1,77 @@ +#!/usr/bin/env ruby + +# Copyright 2025 Google LLC +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +require 'xcodeproj' + +# This script removes all Swift Package Manager dependencies from an Xcode project. +# It's designed to be used in CI to prepare a project for framework-based testing. + +# --- Argument Parsing --- +unless ARGV.length == 1 + puts "Usage: #{$0} " + exit 1 +end + +project_path = ARGV[0] + +# --- Main Logic --- +begin + project = Xcodeproj::Project.open(project_path) +rescue => e + puts "Error opening project at #{project_path}: #{e.message}" + exit 1 +end + +puts "Opened project: #{project.path}" + +# Remove package references from the project's root object. +# This corresponds to the "Package Dependencies" section in Xcode's navigator. +unless project.root_object.package_references.empty? + puts "Removing #{project.root_object.package_references.count} package reference(s)..." + project.root_object.package_references.clear + puts "All package references removed from the project." +else + puts "No package references found in the project." +end + +# Remove package product dependencies from all targets. +# This removes the link to the package products in the "Frameworks, Libraries, +# and Embedded Content" section of each target. +project.targets.each do |target| + dependencies_to_remove = target.dependencies.select do |dependency| + dependency.is_a?(Xcodeproj::Project::Object::XCSwiftPackageProductDependency) + end + + unless dependencies_to_remove.empty? + puts "Found #{dependencies_to_remove.count} SPM product dependencies in target '#{target.name}'. Removing..." + dependencies_to_remove.each do |dep| + puts "Removing #{dep.product_name}" + target.dependencies.delete(dep) + end + puts "SPM product dependencies removed from target '#{target.name}'." + else + puts "No SPM product dependencies found in target '#{target.name}'." + end +end + +# Save the modified project. +begin + project.save + puts "Project saved successfully." +rescue => e + puts "Error saving project: #{e.message}" + exit 1 +end From 34125d7f8a4fb551ea28a543dbbfa08ebd0b2bae Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Tue, 7 Oct 2025 10:53:04 -0400 Subject: [PATCH 15/25] upload to see what's wrong --- .github/workflows/zip.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index c73b1d03d11..241ffbded51 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -222,11 +222,11 @@ jobs: - name: Remove data before upload if: ${{ failure() }} run: scripts/remove_data.sh authentication - # - uses: actions/upload-artifact@v4 - # if: ${{ failure() }} - # with: - # name: quickstart_artifacts_auth - # path: quickstart-ios/ + - uses: actions/upload-artifact@v4 + if: ${{ failure() }} + with: + name: quickstart_artifacts_auth + path: quickstart-ios/ # quickstart_framework_config: # # needs: package-head From f35456426a5f920a86ba2d6b366006e68db9b853 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Tue, 7 Oct 2025 16:56:28 -0400 Subject: [PATCH 16/25] Script changes --- scripts/remove_spm_dependencies.rb | 83 +++++++++++++++++++++--------- 1 file changed, 59 insertions(+), 24 deletions(-) diff --git a/scripts/remove_spm_dependencies.rb b/scripts/remove_spm_dependencies.rb index 9d1fd6df10c..0e95c83b092 100755 --- a/scripts/remove_spm_dependencies.rb +++ b/scripts/remove_spm_dependencies.rb @@ -4,7 +4,8 @@ # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. -# You may obtain a copy of the License at +# You may +# obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # @@ -15,6 +16,7 @@ # limitations under the License. require 'xcodeproj' +require 'set' # This script removes all Swift Package Manager dependencies from an Xcode project. # It's designed to be used in CI to prepare a project for framework-based testing. @@ -37,37 +39,70 @@ puts "Opened project: #{project.path}" -# Remove package references from the project's root object. -# This corresponds to the "Package Dependencies" section in Xcode's navigator. -unless project.root_object.package_references.empty? - puts "Removing #{project.root_object.package_references.count} package reference(s)..." - project.root_object.package_references.clear - puts "All package references removed from the project." -else - puts "No package references found in the project." +# --- Step 1: Find all SPM product dependencies --- +package_product_dependencies = project.objects.select do |obj| + obj.is_a?(Xcodeproj::Project::Object::XCSwiftPackageProductDependency) end -# Remove package product dependencies from all targets. -# This removes the link to the package products in the "Frameworks, Libraries, -# and Embedded Content" section of each target. -project.targets.each do |target| - dependencies_to_remove = target.dependencies.select do |dependency| - dependency.is_a?(Xcodeproj::Project::Object::XCSwiftPackageProductDependency) +if package_product_dependencies.empty? + puts "No SPM product dependencies found to remove." +else + puts "Found #{package_product_dependencies.count} SPM product dependencies. Removing all references..." + package_product_dep_uuids = package_product_dependencies.map(&:uuid).to_set + + # --- Step 2: Find all BuildFile objects that reference these SPM products --- + build_files_to_remove = project.objects.select do |obj| + obj.is_a?(Xcodeproj::Project::Object::PBXBuildFile) && + obj.product_ref && + package_product_dep_uuids.include?(obj.product_ref.uuid) end + build_file_uuids_to_remove = build_files_to_remove.map(&:uuid).to_set + + # --- Step 3: Remove references from all targets --- + project.targets.each do |target| + puts "Cleaning target '#{target.name}'..." - unless dependencies_to_remove.empty? - puts "Found #{dependencies_to_remove.count} SPM product dependencies in target '#{target.name}'. Removing..." - dependencies_to_remove.each do |dep| - puts "Removing #{dep.product_name}" - target.dependencies.delete(dep) + # Remove from target dependencies list + removed_deps = target.dependencies.reject! do |dep| + package_product_dep_uuids.include?(dep.uuid) + end + if removed_deps + puts " - Removed #{removed_deps.count} SPM target dependencies." + end + + # Remove from build phases (e.g., "Link Binary With Libraries") + target.build_phases.each do |phase| + next unless phase.respond_to?(:files) + + original_file_count = phase.files.count + phase.files.reject! do |build_file| + build_file_uuids_to_remove.include?(build_file.uuid) + end + removed_count = original_file_count - phase.files.count + if removed_count > 0 + puts " - Removed #{removed_count} SPM build file references from '#{phase.display_name}'." + end end - puts "SPM product dependencies removed from target '#{target.name}'." - else - puts "No SPM product dependencies found in target '#{target.name}'." end + + # --- Step 4: Delete the now-orphaned BuildFile and dependency objects --- + puts "Deleting #{build_files_to_remove.count} SPM BuildFile object(s)..." + build_files_to_remove.each(&:remove_from_project) + + puts "Deleting #{package_product_dependencies.count} SPM product dependency object(s)..." + package_product_dependencies.each(&:remove_from_project) +end + +# --- Step 5: Remove package references from the project root --- +unless project.root_object.package_references.empty? + puts "Removing #{project.root_object.package_references.count} package reference(s)..." + project.root_object.package_references.clear + puts "All package references removed from the project." +else + puts "No package references found in the project." end -# Save the modified project. +# --- Step 6: Save the modified project --- begin project.save puts "Project saved successfully." From 2a2cf406f8d22820bcd67acf541a1f1426aa1393 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Tue, 7 Oct 2025 17:02:57 -0400 Subject: [PATCH 17/25] test config --- .github/workflows/zip.yml | 97 +++++++++++++++++++-------------------- 1 file changed, 48 insertions(+), 49 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 241ffbded51..021dfe0dc07 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -219,63 +219,62 @@ jobs: quickstart-ios/authentication/GoogleService-Info.plist "$plist_secret" - name: Test Swift Quickstart run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") + # TODO: Can this be reusable? - name: Remove data before upload - if: ${{ failure() }} run: scripts/remove_data.sh authentication - uses: actions/upload-artifact@v4 - if: ${{ failure() }} + # if: ${{ failure() }} with: name: quickstart_artifacts_auth path: quickstart-ios/ -# quickstart_framework_config: -# # needs: package-head -# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} -# env: -# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} -# SDK: "Config" -# strategy: -# matrix: -# artifact: [Firebase-actions-dir] -# build-env: -# - os: macos-15 -# xcode: Xcode_16.4 -# runs-on: ${{ matrix.build-env.os }} -# steps: -# - uses: actions/checkout@v4 -# - name: Get framework dir -# uses: actions/download-artifact@v4.1.7 -# with: -# name: ${{ matrix.artifact }} -# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} -# github-token: ${{ secrets.GITHUB_TOKEN }} -# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 -# - name: Xcode -# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer -# - name: Setup Bundler -# run: ./scripts/setup_bundler.sh -# - name: Move frameworks -# run: | -# mkdir -p "${HOME}"/ios_frameworks/ -# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + -# - name: Setup Swift Quickstart + quickstart_framework_config: +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + env: + plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} + SDK: "Config" + strategy: + matrix: + artifact: [Firebase-actions-dir] + build-env: + - os: macos-15 + xcode: Xcode_16.4 + runs-on: ${{ matrix.build-env.os }} + steps: + - uses: actions/checkout@v4 + - name: Get framework dir + uses: actions/download-artifact@v4.1.7 + with: + name: ${{ matrix.artifact }} + run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} + github-token: ${{ secrets.GITHUB_TOKEN }} + - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 + - name: Xcode + run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer + - name: Setup Bundler + run: ./scripts/setup_bundler.sh + - name: Move frameworks + run: | + mkdir -p "${HOME}"/ios_frameworks/ + find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + + - name: Setup Swift Quickstart -# run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseRemoteConfig/* \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* -# - name: Install Secret GoogleService-Info.plist -# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-config.plist.gpg \ -# quickstart-ios/config/GoogleService-Info.plist "$plist_secret" -# - name: Test Swift Quickstart -# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") -# - name: Remove data before upload -# if: ${{ failure() }} -# run: scripts/remove_data.sh config -# # - uses: actions/upload-artifact@v4 -# # if: ${{ failure() }} -# # with: -# # name: quickstart_artifacts_config -# # path: quickstart-ios/ + run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ + "${HOME}"/ios_frameworks/Firebase/FirebaseRemoteConfig/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* + - name: Install Secret GoogleService-Info.plist + run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-config.plist.gpg \ + quickstart-ios/config/GoogleService-Info.plist "$plist_secret" + - name: Test Swift Quickstart + run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") + - name: Remove data before upload + run: scripts/remove_data.sh config + - uses: actions/upload-artifact@v4 + if: ${{ failure() }} + with: + name: quickstart_artifacts_config + path: quickstart-ios/ # quickstart_framework_crashlytics: # # needs: package-head From 048a0642610e7af532be67174fbb4fa5f08fedec Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Wed, 8 Oct 2025 10:54:37 -0400 Subject: [PATCH 18/25] enable all --- .github/workflows/zip.yml | 652 +++++++++++++++++++------------------- 1 file changed, 323 insertions(+), 329 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 021dfe0dc07..4a9e40203fa 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -276,180 +276,177 @@ jobs: name: quickstart_artifacts_config path: quickstart-ios/ -# quickstart_framework_crashlytics: -# # needs: package-head -# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} -# env: -# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} -# SDK: "Crashlytics" -# strategy: -# matrix: -# artifact: [Firebase-actions-dir] -# build-env: -# - os: macos-15 -# xcode: Xcode_16.4 -# runs-on: ${{ matrix.build-env.os }} -# steps: -# - uses: actions/checkout@v4 -# - name: Get framework dir -# uses: actions/download-artifact@v4.1.7 -# with: -# name: ${{ matrix.artifact }} -# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} -# github-token: ${{ secrets.GITHUB_TOKEN }} -# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 -# - name: Xcode -# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer -# - name: Setup Bundler -# run: ./scripts/setup_bundler.sh -# - name: Move frameworks -# run: | -# mkdir -p "${HOME}"/ios_frameworks/ -# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + -# - uses: actions/checkout@v4 -# - name: Setup quickstart -# run: | -# SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseCrashlytics/* \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* -# cp quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Firebase/run quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart -# cp quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Firebase/upload-symbols quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart -# chmod +x quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/run -# chmod +x quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/upload-symbols -# # TODO(#8057): Restore Swift Quickstart -# # - name: Setup swift quickstart -# # env: -# # LEGACY: true -# # run: | -# # SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" NON_FIREBASE_SDKS="ReachabilitySwift" scripts/setup_quickstart_framework.sh \ -# # "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/* -# - name: Install Secret GoogleService-Info.plist -# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-crashlytics.plist.gpg \ -# quickstart-ios/crashlytics/GoogleService-Info.plist "$plist_secret" -# - name: Test Quickstart -# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") -# # TODO(#8057): Restore Swift Quickstart -# # - name: Test Swift Quickstart -# # env: -# # LEGACY: true -# # run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) -# - name: Remove data before upload -# if: ${{ failure() }} -# run: scripts/remove_data.sh crashlytics -# # - uses: actions/upload-artifact@v4 -# # if: ${{ failure() }} -# # with: -# # name: quickstart_artifacts_crashlytics -# # path: quickstart-ios/ + quickstart_framework_crashlytics: +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + env: + plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} + SDK: "Crashlytics" + strategy: + matrix: + artifact: [Firebase-actions-dir] + build-env: + - os: macos-15 + xcode: Xcode_16.4 + runs-on: ${{ matrix.build-env.os }} + steps: + - uses: actions/checkout@v4 + - name: Get framework dir + uses: actions/download-artifact@v4.1.7 + with: + name: ${{ matrix.artifact }} + run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} + github-token: ${{ secrets.GITHUB_TOKEN }} + - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 + - name: Xcode + run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer + - name: Setup Bundler + run: ./scripts/setup_bundler.sh + - name: Move frameworks + run: | + mkdir -p "${HOME}"/ios_frameworks/ + find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + + - uses: actions/checkout@v4 + - name: Setup quickstart + run: | + SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ + "${HOME}"/ios_frameworks/Firebase/FirebaseCrashlytics/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* + cp quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Firebase/run quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart + cp quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Firebase/upload-symbols quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart + chmod +x quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/run + chmod +x quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/upload-symbols + # TODO(#8057): Restore Swift Quickstart + # - name: Setup swift quickstart + # env: + # LEGACY: true + # run: | + # SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" NON_FIREBASE_SDKS="ReachabilitySwift" scripts/setup_quickstart_framework.sh \ + # "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/* + - name: Install Secret GoogleService-Info.plist + run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-crashlytics.plist.gpg \ + quickstart-ios/crashlytics/GoogleService-Info.plist "$plist_secret" + - name: Test Quickstart + run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") + # TODO(#8057): Restore Swift Quickstart + # - name: Test Swift Quickstart + # env: + # LEGACY: true + # run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) + - name: Remove data before upload + run: scripts/remove_data.sh crashlytics + # - uses: actions/upload-artifact@v4 + # if: ${{ failure() }} + # with: + # name: quickstart_artifacts_crashlytics + # path: quickstart-ios/ -# quickstart_framework_database: -# # needs: package-head -# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} -# env: -# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} -# SDK: "Database" -# strategy: -# matrix: -# os: [macos-14] -# xcode: [Xcode_16.2] -# artifact: [Firebase-actions-dir] -# runs-on: ${{ matrix.os }} -# steps: -# - uses: actions/checkout@v4 -# - name: Get framework dir -# uses: actions/download-artifact@v4.1.7 -# with: -# name: ${{ matrix.artifact }} -# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} -# github-token: ${{ secrets.GITHUB_TOKEN }} -# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 -# - name: Xcode -# run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer -# - name: Setup Bundler -# run: ./scripts/setup_bundler.sh -# - name: Move frameworks -# run: | -# mkdir -p "${HOME}"/ios_frameworks/ -# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + -# - uses: actions/checkout@v4 -# - name: Setup quickstart -# run: SAMPLE="$SDK" TARGET="${SDK}Example" NON_FIREBASE_SDKS="FirebaseDatabaseUI" scripts/setup_quickstart_framework.sh \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseDatabase/* \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseStorage/* \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/* \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \ -# "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/* \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* -# - name: Install Secret GoogleService-Info.plist -# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-database.plist.gpg \ -# quickstart-ios/database/GoogleService-Info.plist "$plist_secret" -# - name: Test Quickstart -# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") -# - name: Remove data before upload -# if: ${{ failure() }} -# run: scripts/remove_data.sh database -# # - uses: actions/upload-artifact@v4 -# # if: ${{ failure() }} -# # with: -# # name: quickstart_artifacts database -# # path: quickstart-ios/ + quickstart_framework_database: +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + env: + plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} + SDK: "Database" + strategy: + matrix: + os: [macos-14] + xcode: [Xcode_16.2] + artifact: [Firebase-actions-dir] + runs-on: ${{ matrix.os }} + steps: + - uses: actions/checkout@v4 + - name: Get framework dir + uses: actions/download-artifact@v4.1.7 + with: + name: ${{ matrix.artifact }} + run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} + github-token: ${{ secrets.GITHUB_TOKEN }} + - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 + - name: Xcode + run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer + - name: Setup Bundler + run: ./scripts/setup_bundler.sh + - name: Move frameworks + run: | + mkdir -p "${HOME}"/ios_frameworks/ + find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + + - uses: actions/checkout@v4 + - name: Setup quickstart + run: SAMPLE="$SDK" TARGET="${SDK}Example" NON_FIREBASE_SDKS="FirebaseDatabaseUI" scripts/setup_quickstart_framework.sh \ + "${HOME}"/ios_frameworks/Firebase/FirebaseDatabase/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseStorage/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \ + "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* + - name: Install Secret GoogleService-Info.plist + run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-database.plist.gpg \ + quickstart-ios/database/GoogleService-Info.plist "$plist_secret" + - name: Test Quickstart + run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") + - name: Remove data before upload + run: scripts/remove_data.sh database + # - uses: actions/upload-artifact@v4 + # if: ${{ failure() }} + # with: + # name: quickstart_artifacts database + # path: quickstart-ios/ -# quickstart_framework_firestore: -# # needs: package-head -# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} -# env: -# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} -# SDK: "Firestore" -# strategy: -# matrix: -# artifact: [Firebase-actions-dir] -# build-env: -# - os: macos-15 -# xcode: Xcode_16.4 -# runs-on: ${{ matrix.build-env.os }} -# steps: -# - uses: actions/checkout@v4 -# - name: Get framework dir -# uses: actions/download-artifact@v4.1.7 -# with: -# name: ${{ matrix.artifact }} -# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} -# github-token: ${{ secrets.GITHUB_TOKEN }} -# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 -# - name: Xcode -# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer -# - name: Setup Bundler -# run: ./scripts/setup_bundler.sh -# - name: Move frameworks -# run: | -# mkdir -p "${HOME}"/ios_frameworks/ -# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + -# - uses: actions/checkout@v4 -# - name: Setup quickstart -# run: SAMPLE="$SDK" TARGET="${SDK}Example" NON_FIREBASE_SDKS="SDWebImage FirebaseAuthUI FirebaseEmailAuthUI" scripts/setup_quickstart_framework.sh \ -# "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/* \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/* \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* -# - name: Upload build logs on failure -# if: ${{ failure() }} -# uses: actions/upload-artifact@v4 -# with: -# name: build_logs_firestore_${{ matrix.artifact }}_${{ matrix.build-env.os }} -# path: sdk_zip/build_logs/ -# - name: Install Secret GoogleService-Info.plist -# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-firestore.plist.gpg \ -# quickstart-ios/firestore/GoogleService-Info.plist "$plist_secret" -# - name: Test Quickstart -# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") -# - name: Remove data before upload and zip directory to reduce upload size. -# if: ${{ failure() }} -# run: scripts/remove_data.sh firestore; zip -r --symlinks quickstart_artifacts_firestore.zip quickstart-ios/ -# # - uses: actions/upload-artifact@v4 -# # if: ${{ failure() }} -# # with: -# # name: quickstart_artifacts_firestore_${{ matrix.artifact }}_${{ matrix.build-env.os }} -# # path: quickstart_artifacts_firestore.zip + quickstart_framework_firestore: +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + env: + plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} + SDK: "Firestore" + strategy: + matrix: + artifact: [Firebase-actions-dir] + build-env: + - os: macos-15 + xcode: Xcode_16.4 + runs-on: ${{ matrix.build-env.os }} + steps: + - uses: actions/checkout@v4 + - name: Get framework dir + uses: actions/download-artifact@v4.1.7 + with: + name: ${{ matrix.artifact }} + run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} + github-token: ${{ secrets.GITHUB_TOKEN }} + - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 + - name: Xcode + run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer + - name: Setup Bundler + run: ./scripts/setup_bundler.sh + - name: Move frameworks + run: | + mkdir -p "${HOME}"/ios_frameworks/ + find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + + - uses: actions/checkout@v4 + - name: Setup quickstart + run: SAMPLE="$SDK" TARGET="${SDK}Example" NON_FIREBASE_SDKS="SDWebImage FirebaseAuthUI FirebaseEmailAuthUI" scripts/setup_quickstart_framework.sh \ + "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* + - name: Upload build logs on failure + if: ${{ failure() }} + uses: actions/upload-artifact@v4 + with: + name: build_logs_firestore_${{ matrix.artifact }}_${{ matrix.build-env.os }} + path: sdk_zip/build_logs/ + - name: Install Secret GoogleService-Info.plist + run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-firestore.plist.gpg \ + quickstart-ios/firestore/GoogleService-Info.plist "$plist_secret" + - name: Test Quickstart + run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") + - name: Remove data before upload and zip directory to reduce upload size. + run: scripts/remove_data.sh firestore; zip -r --symlinks quickstart_artifacts_firestore.zip quickstart-ios/ + # - uses: actions/upload-artifact@v4 + # if: ${{ failure() }} + # with: + # name: quickstart_artifacts_firestore_${{ matrix.artifact }}_${{ matrix.build-env.os }} + # path: quickstart_artifacts_firestore.zip # check_framework_firestore_symbols: # # needs: package-head @@ -483,162 +480,159 @@ jobs: # $(pwd) \ # "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/FirebaseFirestoreInternal.xcframework -# quickstart_framework_inappmessaging: -# # needs: package-head -# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} -# env: -# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} -# SDK: "InAppMessaging" -# strategy: -# matrix: -# artifact: [Firebase-actions-dir] -# build-env: -# - os: macos-15 -# xcode: Xcode_16.4 -# runs-on: ${{ matrix.build-env.os }} -# steps: -# - uses: actions/checkout@v4 -# - name: Get framework dir -# uses: actions/download-artifact@v4.1.7 -# with: -# name: ${{ matrix.artifact }} -# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} -# github-token: ${{ secrets.GITHUB_TOKEN }} -# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 -# - name: Xcode -# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer -# - name: Setup Bundler -# run: ./scripts/setup_bundler.sh -# - name: Move frameworks -# run: | -# mkdir -p "${HOME}"/ios_frameworks/ -# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + -# - uses: actions/checkout@v4 -# - name: Setup quickstart -# run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseInAppMessaging/* \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* -# - name: Setup swift quickstart -# run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh -# - name: Install Secret GoogleService-Info.plist -# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-inappmessaging.plist.gpg \ -# quickstart-ios/inappmessaging/GoogleService-Info.plist "$plist_secret" -# - name: Test Quickstart -# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") -# - name: Test Swift Quickstart -# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) -# - name: Remove data before upload -# if: ${{ failure() }} -# run: scripts/remove_data.sh inappmessaging -# # - uses: actions/upload-artifact@v4 -# # if: ${{ failure() }} -# # with: -# # name: quickstart_artifacts_inappmessaging -# # path: quickstart-ios/ + quickstart_framework_inappmessaging: +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + env: + plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} + SDK: "InAppMessaging" + strategy: + matrix: + artifact: [Firebase-actions-dir] + build-env: + - os: macos-15 + xcode: Xcode_16.4 + runs-on: ${{ matrix.build-env.os }} + steps: + - uses: actions/checkout@v4 + - name: Get framework dir + uses: actions/download-artifact@v4.1.7 + with: + name: ${{ matrix.artifact }} + run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} + github-token: ${{ secrets.GITHUB_TOKEN }} + - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 + - name: Xcode + run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer + - name: Setup Bundler + run: ./scripts/setup_bundler.sh + - name: Move frameworks + run: | + mkdir -p "${HOME}"/ios_frameworks/ + find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + + - uses: actions/checkout@v4 + - name: Setup quickstart + run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ + "${HOME}"/ios_frameworks/Firebase/FirebaseInAppMessaging/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* + - name: Setup swift quickstart + run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh + - name: Install Secret GoogleService-Info.plist + run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-inappmessaging.plist.gpg \ + quickstart-ios/inappmessaging/GoogleService-Info.plist "$plist_secret" + - name: Test Quickstart + run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") + - name: Test Swift Quickstart + run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) + - name: Remove data before upload + run: scripts/remove_data.sh inappmessaging + # - uses: actions/upload-artifact@v4 + # if: ${{ failure() }} + # with: + # name: quickstart_artifacts_inappmessaging + # path: quickstart-ios/ -# quickstart_framework_messaging: -# # needs: package-head -# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} -# env: -# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} -# SDK: "Messaging" -# strategy: -# matrix: -# artifact: [Firebase-actions-dir] -# build-env: -# - os: macos-15 -# xcode: Xcode_16.4 -# runs-on: ${{ matrix.build-env.os }} -# steps: -# - uses: actions/checkout@v4 -# - name: Get framework dir -# uses: actions/download-artifact@v4.1.7 -# with: -# name: ${{ matrix.artifact }} -# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} -# github-token: ${{ secrets.GITHUB_TOKEN }} -# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 -# - name: Xcode -# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer -# - name: Setup Bundler -# run: ./scripts/setup_bundler.sh -# - name: Move frameworks -# run: | -# mkdir -p "${HOME}"/ios_frameworks/ -# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + -# - uses: actions/checkout@v4 -# - name: Setup quickstart -# run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseMessaging/* \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* -# - name: Setup swift quickstart -# run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh -# - name: Install Secret GoogleService-Info.plist -# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-messaging.plist.gpg \ -# quickstart-ios/messaging/GoogleService-Info.plist "$plist_secret" -# - name: Test Quickstart -# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") -# - name: Test Swift Quickstart -# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) -# - name: Remove data before upload -# if: ${{ failure() }} -# run: scripts/remove_data.sh messaging -# # - uses: actions/upload-artifact@v4 -# # if: ${{ failure() }} -# # with: -# # name: quickstart_artifacts_messaging -# # path: quickstart-ios/ + quickstart_framework_messaging: +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + env: + plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} + SDK: "Messaging" + strategy: + matrix: + artifact: [Firebase-actions-dir] + build-env: + - os: macos-15 + xcode: Xcode_16.4 + runs-on: ${{ matrix.build-env.os }} + steps: + - uses: actions/checkout@v4 + - name: Get framework dir + uses: actions/download-artifact@v4.1.7 + with: + name: ${{ matrix.artifact }} + run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} + github-token: ${{ secrets.GITHUB_TOKEN }} + - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 + - name: Xcode + run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer + - name: Setup Bundler + run: ./scripts/setup_bundler.sh + - name: Move frameworks + run: | + mkdir -p "${HOME}"/ios_frameworks/ + find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + + - uses: actions/checkout@v4 + - name: Setup quickstart + run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ + "${HOME}"/ios_frameworks/Firebase/FirebaseMessaging/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* + - name: Setup swift quickstart + run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh + - name: Install Secret GoogleService-Info.plist + run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-messaging.plist.gpg \ + quickstart-ios/messaging/GoogleService-Info.plist "$plist_secret" + - name: Test Quickstart + run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") + - name: Test Swift Quickstart + run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) + - name: Remove data before upload + run: scripts/remove_data.sh messaging + # - uses: actions/upload-artifact@v4 + # if: ${{ failure() }} + # with: + # name: quickstart_artifacts_messaging + # path: quickstart-ios/ -# quickstart_framework_storage: -# # needs: package-head -# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} -# env: -# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} -# SDK: "Storage" -# strategy: -# matrix: -# artifact: [Firebase-actions-dir] -# build-env: -# - os: macos-15 -# xcode: Xcode_16.4 -# runs-on: ${{ matrix.build-env.os }} -# steps: -# - uses: actions/checkout@v4 -# - name: Get framework dir -# uses: actions/download-artifact@v4.1.7 -# with: -# name: ${{ matrix.artifact }} -# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} -# github-token: ${{ secrets.GITHUB_TOKEN }} -# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 -# - name: Xcode -# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer -# - name: Setup Bundler -# run: ./scripts/setup_bundler.sh -# - name: Move frameworks -# run: | -# mkdir -p "${HOME}"/ios_frameworks/ -# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + -# - uses: actions/checkout@v4 -# - name: Setup quickstart -# run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseStorage/* \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* -# - name: Setup swift quickstart -# run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh -# - name: Install Secret GoogleService-Info.plist -# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-storage.plist.gpg \ -# quickstart-ios/storage/GoogleService-Info.plist "$plist_secret" -# - name: Test Quickstart -# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") -# - name: Test Swift Quickstart -# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) -# - name: Remove data before upload -# if: ${{ failure() }} -# run: scripts/remove_data.sh storage -# # - uses: actions/upload-artifact@v4 -# # if: ${{ failure() }} -# # with: -# # name: quickstart_artifacts_storage -# # path: quickstart-ios/ + quickstart_framework_storage: +# needs: package-head +# if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} + env: + plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} + SDK: "Storage" + strategy: + matrix: + artifact: [Firebase-actions-dir] + build-env: + - os: macos-15 + xcode: Xcode_16.4 + runs-on: ${{ matrix.build-env.os }} + steps: + - uses: actions/checkout@v4 + - name: Get framework dir + uses: actions/download-artifact@v4.1.7 + with: + name: ${{ matrix.artifact }} + run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} + github-token: ${{ secrets.GITHUB_TOKEN }} + - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 + - name: Xcode + run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer + - name: Setup Bundler + run: ./scripts/setup_bundler.sh + - name: Move frameworks + run: | + mkdir -p "${HOME}"/ios_frameworks/ + find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + + - uses: actions/checkout@v4 + - name: Setup quickstart + run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ + "${HOME}"/ios_frameworks/Firebase/FirebaseStorage/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* + - name: Setup swift quickstart + run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh + - name: Install Secret GoogleService-Info.plist + run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-storage.plist.gpg \ + quickstart-ios/storage/GoogleService-Info.plist "$plist_secret" + - name: Test Quickstart + run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") + - name: Test Swift Quickstart + run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) + - name: Remove data before upload + run: scripts/remove_data.sh storage + # - uses: actions/upload-artifact@v4 + # if: ${{ failure() }} + # with: + # name: quickstart_artifacts_storage + # path: quickstart-ios/ From 32c4dc2f856d55e959eefd29e0d0cee785464a5f Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 10 Oct 2025 11:28:44 -0400 Subject: [PATCH 19/25] add script scheme catch --- scripts/zip_quickstart_test.sh | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/scripts/zip_quickstart_test.sh b/scripts/zip_quickstart_test.sh index 3b531f8e3f9..1476b2b1985 100755 --- a/scripts/zip_quickstart_test.sh +++ b/scripts/zip_quickstart_test.sh @@ -42,10 +42,23 @@ else device_name="iPhone 16" fi +# Define project and scheme names +PROJECT_NAME="${SAMPLE}Example.xcodeproj" +SCHEME_NAME="${SAMPLE}Example${SWIFT_SUFFIX}" + +# Check if the scheme exists before attempting to build. +# The `awk` command prints all lines from "Schemes:" to the end of the output. +if ! xcodebuild -list -project "${PROJECT_NAME}" | awk '/Schemes:/,0' | grep -q "^\s*${SCHEME_NAME}"$; then + echo "Error: Scheme '${SCHEME_NAME}' not found in project '${PROJECT_NAME}'." + echo "Available schemes from '${PROJECT_NAME}':" + xcodebuild -list -project "${PROJECT_NAME}" + exit 65 +fi + ( xcodebuild \ --project ${SAMPLE}Example.xcodeproj \ --scheme ${SAMPLE}Example${SWIFT_SUFFIX} \ +-project ${PROJECT_NAME} \ +-scheme ${SCHEME_NAME} \ -destination "platform=iOS Simulator,name=$device_name" "SWIFT_VERSION=5.3" "OTHER_LDFLAGS=\$(OTHER_LDFLAGS) -ObjC" "FRAMEWORK_SEARCH_PATHS= \$(PROJECT_DIR)/Firebase/" HEADER_SEARCH_PATHS='$(PROJECT_DIR)/Firebase' \ build \ ) || EXIT_STATUS=$? From 51e9dc8c7c2a1761efbec169eb3ff19857a1b846 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 10 Oct 2025 12:03:50 -0400 Subject: [PATCH 20/25] zip --- .github/workflows/zip.yml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 4a9e40203fa..4d06e7bba3c 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -309,13 +309,9 @@ jobs: - uses: actions/checkout@v4 - name: Setup quickstart run: | - SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ - "${HOME}"/ios_frameworks/Firebase/FirebaseCrashlytics/* \ - "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* - cp quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Firebase/run quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart - cp quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Firebase/upload-symbols quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart - chmod +x quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/run - chmod +x quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/upload-symbols + SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \ + "${HOME}"/ios_frameworks/Firebase/FirebaseCrashlytics/* \ + "${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/* # TODO(#8057): Restore Swift Quickstart # - name: Setup swift quickstart # env: From 3e624b030789a5d26154bfde2ee04ea6efaae5a2 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 10 Oct 2025 12:04:42 -0400 Subject: [PATCH 21/25] remove swift storage qs test --- .github/workflows/zip.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 4d06e7bba3c..18379a93ccb 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -623,8 +623,6 @@ jobs: quickstart-ios/storage/GoogleService-Info.plist "$plist_secret" - name: Test Quickstart run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - - name: Test Swift Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) - name: Remove data before upload run: scripts/remove_data.sh storage # - uses: actions/upload-artifact@v4 From 7faff20b2173a0ff22b245da030dfe4863b666d2 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 10 Oct 2025 12:20:14 -0400 Subject: [PATCH 22/25] move fst check symbols --- .github/workflows/zip.yml | 64 +++++++++++++++++++-------------------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 18379a93ccb..58e219fd89a 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -124,6 +124,38 @@ jobs: # # name of. # path: zip_output_dir +# check_framework_firestore_symbols: +# # needs: package-head +# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} +# env: +# FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT: 1 +# runs-on: macos-14 +# steps: +# - name: Xcode 16.2 +# run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer +# - uses: actions/checkout@v4 +# - name: Get framework dir +# uses: actions/download-artifact@v4.1.7 +# with: +# name: Firebase-actions-dir +# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} +# github-token: ${{ secrets.GITHUB_TOKEN }} +# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 +# - name: Setup Bundler +# run: ./scripts/setup_bundler.sh +# - name: Install xcpretty +# run: gem install xcpretty +# - name: Move frameworks +# run: | +# mkdir -p "${HOME}"/ios_frameworks/ +# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + +# - uses: actions/checkout@v4 +# - name: Check linked Firestore.xcframework for unlinked symbols. +# run: | +# scripts/check_firestore_symbols.sh \ +# $(pwd) \ +# "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/FirebaseFirestoreInternal.xcframework + # quickstart_framework_abtesting: # # needs: package-head # # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} @@ -444,38 +476,6 @@ jobs: # name: quickstart_artifacts_firestore_${{ matrix.artifact }}_${{ matrix.build-env.os }} # path: quickstart_artifacts_firestore.zip -# check_framework_firestore_symbols: -# # needs: package-head -# # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} -# env: -# FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT: 1 -# runs-on: macos-14 -# steps: -# - name: Xcode 16.2 -# run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer -# - uses: actions/checkout@v4 -# - name: Get framework dir -# uses: actions/download-artifact@v4.1.7 -# with: -# name: Firebase-actions-dir -# run-id: 17965877651 # ${{ github.event.inputs.zip_run_id || github.run_id }} -# github-token: ${{ secrets.GITHUB_TOKEN }} -# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 -# - name: Setup Bundler -# run: ./scripts/setup_bundler.sh -# - name: Install xcpretty -# run: gem install xcpretty -# - name: Move frameworks -# run: | -# mkdir -p "${HOME}"/ios_frameworks/ -# find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + -# - uses: actions/checkout@v4 -# - name: Check linked Firestore.xcframework for unlinked symbols. -# run: | -# scripts/check_firestore_symbols.sh \ -# $(pwd) \ -# "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/FirebaseFirestoreInternal.xcframework - quickstart_framework_inappmessaging: # needs: package-head # if: ${{ !cancelled() && (success() || github.event.inputs.zip_run_id != '') }} From 7974e981779acb8a4758b85a86c0c2fdafb8b7b8 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 13 Oct 2025 11:31:45 -0400 Subject: [PATCH 23/25] zip --- .github/workflows/zip.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 58e219fd89a..1d6094b0b6d 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -363,11 +363,11 @@ jobs: # run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) - name: Remove data before upload run: scripts/remove_data.sh crashlytics - # - uses: actions/upload-artifact@v4 - # if: ${{ failure() }} - # with: - # name: quickstart_artifacts_crashlytics - # path: quickstart-ios/ + - uses: actions/upload-artifact@v4 + if: ${{ failure() }} + with: + name: quickstart_artifacts_crashlytics + path: quickstart-ios/ quickstart_framework_database: # needs: package-head From d4786519ce894c99d720a9f091e481174e19296f Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 13 Oct 2025 14:09:08 -0400 Subject: [PATCH 24/25] always clean --- .github/workflows/zip.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 1d6094b0b6d..a337eed2d4d 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -202,6 +202,7 @@ jobs: # run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") # - name: Remove data before upload # if: ${{ failure() }} + if: always() # run: scripts/remove_data.sh abtesting # # - uses: actions/upload-artifact@v4 # # if: ${{ failure() }} @@ -253,6 +254,7 @@ jobs: run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") # TODO: Can this be reusable? - name: Remove data before upload + if: always() run: scripts/remove_data.sh authentication - uses: actions/upload-artifact@v4 # if: ${{ failure() }} @@ -301,6 +303,7 @@ jobs: - name: Test Swift Quickstart run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - name: Remove data before upload + if: always() run: scripts/remove_data.sh config - uses: actions/upload-artifact@v4 if: ${{ failure() }} @@ -362,6 +365,7 @@ jobs: # LEGACY: true # run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) - name: Remove data before upload + if: always() run: scripts/remove_data.sh crashlytics - uses: actions/upload-artifact@v4 if: ${{ failure() }} @@ -413,6 +417,7 @@ jobs: - name: Test Quickstart run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - name: Remove data before upload + if: always() run: scripts/remove_data.sh database # - uses: actions/upload-artifact@v4 # if: ${{ failure() }} @@ -469,6 +474,7 @@ jobs: - name: Test Quickstart run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - name: Remove data before upload and zip directory to reduce upload size. + if: always() run: scripts/remove_data.sh firestore; zip -r --symlinks quickstart_artifacts_firestore.zip quickstart-ios/ # - uses: actions/upload-artifact@v4 # if: ${{ failure() }} @@ -521,6 +527,7 @@ jobs: - name: Test Swift Quickstart run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) - name: Remove data before upload + if: always() run: scripts/remove_data.sh inappmessaging # - uses: actions/upload-artifact@v4 # if: ${{ failure() }} @@ -573,6 +580,7 @@ jobs: - name: Test Swift Quickstart run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) - name: Remove data before upload + if: always() run: scripts/remove_data.sh messaging # - uses: actions/upload-artifact@v4 # if: ${{ failure() }} @@ -624,6 +632,7 @@ jobs: - name: Test Quickstart run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - name: Remove data before upload + if: always() run: scripts/remove_data.sh storage # - uses: actions/upload-artifact@v4 # if: ${{ failure() }} From 6db35cf2d04ec47ac17c7574df4397cc229c0296 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 13 Oct 2025 14:37:28 -0400 Subject: [PATCH 25/25] fix syntax --- .github/workflows/zip.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index a337eed2d4d..74eb35ab067 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -201,8 +201,7 @@ jobs: # - name: Test Quickstart # run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") # - name: Remove data before upload -# if: ${{ failure() }} - if: always() +# if: always() # run: scripts/remove_data.sh abtesting # # - uses: actions/upload-artifact@v4 # # if: ${{ failure() }}