Skip to content

Commit 2b3c729

Browse files
authored
Fixing VSCE build by removing uneeded steps (#8107)
1 parent a1d61ec commit 2b3c729

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

firebase-vscode/webpack.common.js

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -191,19 +191,20 @@ const extensionConfig = {
191191
from: "../schema",
192192
to: "./schema",
193193
},
194+
// TODO(hlshen): Sanity check if these should be fixed or removed. AFIACT, they exist for functions and hosting deploys, which are not relevant anymore.
194195
// Copy uncompiled JS files called at runtime by
195196
// firebase-tools/src/parseTriggers.ts
196-
{
197-
from: "*.js",
198-
to: "./",
199-
context: "../src/deploy/functions/runtimes/node",
200-
},
201-
// Copy cross-env-shell.js used to run predeploy scripts
202-
// to ensure they work in Windows
203-
{
204-
from: "../node_modules/cross-env/dist",
205-
to: "./cross-env/dist",
206-
},
197+
// {
198+
// from: "*.js",
199+
// to: "./",
200+
// context: "../src/deploy/functions/runtimes/node",
201+
// },
202+
// // Copy cross-env-shell.js used to run predeploy scripts
203+
// // to ensure they work in Windows
204+
// {
205+
// from: "../node_modules/cross-env/dist",
206+
// to: "./cross-env/dist",
207+
// },
207208
],
208209
}),
209210
],

0 commit comments

Comments
 (0)