Fixed an issue where empty firebase.json files would break init (#9228)

* Fixed an issue where empty firebase.json files would break init

* Update src/config.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Adding one test, fixing another badly designed one

* Adding test fxiture

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Author: joehan

src/commands/firestore-operations-describe.spec.ts

@@ -86,9 +86,9 @@ describe("firestore:operations:describe", () => {
 
   it("should throw a FirebaseError if operation name is invalid", async () => {
     const options = { project: "test-project" };
-    await expect(command.runner()("", options)).to.be.rejectedWith(
+    await expect(command.runner()("/databases/blah", options)).to.be.rejectedWith(
       FirebaseError,
-      '"" is not a valid operation name.',
+      '"/databases/blah" is not a valid operation name.',
     );
     await expect(command.runner()("projects/p/databases/d", options)).to.be.rejectedWith(
       FirebaseError,

src/config.spec.ts

@@ -7,6 +7,7 @@ import { Config } from "./config";
 import { FIREBASE_JSON_PATH as VALID_CONFIG_PATH } from "./test/fixtures/valid-config";
 import { FIXTURE_DIR as SIMPLE_CONFIG_DIR } from "./test/fixtures/config-imports";
 import { FIXTURE_DIR as DUP_TOP_LEVEL_CONFIG_DIR } from "./test/fixtures/dup-top-level";
+import { FIREBASE_JSON_PATH as EMPTY_CONFIG_PATH } from "./test/fixtures/empty-config";
 
 describe("Config", () => {
   describe("#load", () => {
@@ -17,9 +18,16 @@ describe("Config", () => {
         configPath: path.relative(cwd, VALID_CONFIG_PATH),
       });
       expect(config).to.not.be.null;
-      if (config) {
-        expect(config.get("database.rules")).to.eq("config/security-rules.json");
-      }
+      expect(config?.get("database.rules")).to.eq("config/security-rules.json");
+    });
+    it("should fall back to {} when the file is empty", () => {
+      const cwd = __dirname;
+      const config = Config.load({
+        cwd,
+        configPath: path.relative(cwd, EMPTY_CONFIG_PATH),
+      });
+      expect(config).to.not.be.null;
+      expect(config?.data).to.deep.eq({});
     });
   });
 

src/config.ts

@@ -6,7 +6,6 @@ import * as _ from "lodash";
 import * as clc from "colorette";
 import * as fs from "fs-extra";
 import * as path from "path";
-const cjson = require("cjson");
 
 import { detectProjectRoot } from "./detectProjectRoot";
 import { FirebaseError } from "./error";
@@ -303,7 +302,10 @@ export class Config {
     if (pd) {
       try {
         const filePath = path.resolve(pd, path.basename(filename));
-        const data = cjson.load(filePath);
+        let data: unknown = {};
+        if (fs.statSync(filePath).size > 0) {
+          data = loadCJSON(filePath);
+        }
 
         // Validate config against JSON Schema. For now we just print these to debug
         // logs but in a future CLI version they could be warnings and/or errors.

src/test/fixtures/empty-config/firebase.json

@@ -0,0 +1,8 @@
+import { resolve } from "path";
+
+/**
+ * A directory containing an empty rebase.json.
+ */
+export const FIXTURE_DIR = __dirname;
+
+export const FIREBASE_JSON_PATH = resolve(__dirname, "firebase.json");