Skip to content

[FirebaseAI] Add Grounding with Google search sample #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Jul 4, 2025

@dlarocque dlarocque requested review from rlazo and thatfiredev July 4, 2025 18:25
@dlarocque dlarocque marked this pull request as draft July 17, 2025 18:05
dlarocque and others added 2 commits July 17, 2025 15:40
…dl/grounding

# Conflicts:
#	firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/FirebaseAISamples.kt
#	firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/feature/text/ChatViewModel.kt
#	firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/ui/navigation/Sample.kt
#	gradle/libs.versions.toml
Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM :)

Just 2 comments before we merge

@@ -33,7 +33,7 @@ androidx-ui-test-manifest = { group = "androidx.compose.ui", name = "ui-test-man
androidx-ui-tooling = { group = "androidx.compose.ui", name = "ui-tooling" }
androidx-ui-tooling-preview = { group = "androidx.compose.ui", name = "ui-tooling-preview" }
compose-navigation = { group = "androidx.navigation", name = "navigation-compose", version.ref = "composeNavigation"}
firebase-ai = { module = "com.google.firebase:firebase-ai" }
firebase-ai = { module = "com.google.firebase:firebase-ai", version = "16.2.0" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comment so that we don't forget to undo this before merging

Comment on lines +79 to +80
// Webkit
implementation(libs.androidx.webkit)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move these 2 lines up? (around line 62, next to the other androidx dependencies that use implementation())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants