From 13beedcef382ccd8138c9fde3475c63625ed0823 Mon Sep 17 00:00:00 2001 From: yuetloo Date: Sat, 7 Dec 2024 17:03:54 -0500 Subject: [PATCH 1/3] fix CI build error --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7fde95a..42e19c5 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -17,7 +17,7 @@ jobs: - name: Checkout pixie-firmware uses: actions/checkout@v3 with: - ref: chore/add-submodules + ref: main submodules: 'recursive' - name: Setup node version uses: actions/setup-node@v4 From 2437699b495f0652a0ad99786b73348c923482ae Mon Sep 17 00:00:00 2001 From: yuetloo Date: Sat, 7 Dec 2024 17:05:04 -0500 Subject: [PATCH 2/3] update read with troubleshooting tips --- README.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/README.md b/README.md index e804c32..82845e5 100644 --- a/README.md +++ b/README.md @@ -33,6 +33,21 @@ Use [docker](https://docs.docker.com/engine/install) to build the project: docker run --rm -v $PWD:/project -w /project -e HOME=/tmp espressif/idf idf.py build ``` +Troubleshooting +--------------- + +1. If you get `error: implicit declaration of function x; did you mean function y? [-Wimplicit-function-declaration]`, check and update the `firefly-scene` and `firefly-display` submodules in the components folder: + +```sh +# check the submodules are from the correct branch +git submodule status + +# update the submodules +git submodule update --init --recursive + +# pull submodules changes from the remote repositories +git pull --recurse-submodules +``` Hardware Specifications From ccabef5a6d73ae6ca6179af266cb7386f84cf349 Mon Sep 17 00:00:00 2001 From: yuetloo Date: Sat, 7 Dec 2024 17:16:27 -0500 Subject: [PATCH 3/3] add pull request trigger and checkout from the branch that triggered the job --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 42e19c5..23b16c4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,6 +1,7 @@ name: Build -on: +on: push: + pull_request: workflow_dispatch: inputs: memory: @@ -17,7 +18,6 @@ jobs: - name: Checkout pixie-firmware uses: actions/checkout@v3 with: - ref: main submodules: 'recursive' - name: Setup node version uses: actions/setup-node@v4