Skip to content

Commit e2f657d

Browse files
committed
Fix warnings
1 parent 95cce45 commit e2f657d

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

app/build.gradle

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,17 @@ android {
2626
signingConfig signingConfigs.SignConfig
2727
}
2828
}
29+
return void
2930
}
3031

3132
dependencies {
3233
compile fileTree(dir: 'libs', include: ['*.jar'])
3334
compile 'com.github.hotchemi:permissionsdispatcher:2.1.3'
3435
apt 'com.github.hotchemi:permissionsdispatcher-processor:2.1.3'
3536
compile 'com.android.support:appcompat-v7:24.2.1'
37+
//noinspection GradleDependency
3638
compile 'com.google.android.gms:play-services-location:9.4.0'
39+
//noinspection GradleDependency
3740
compile 'com.google.android.gms:play-services-maps:9.4.0'
3841
compile 'org.apache.commons:commons-lang3:3.4'
3942
// compile files('libs/Java-WebSocket-Library-1.2.1-SNAPSHOT.jar')

app/src/main/java/com/firemaples/androidlocationremotecontrol/MainActivity.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,14 @@
3131
import java.math.BigInteger;
3232
import java.net.InetAddress;
3333
import java.net.UnknownHostException;
34+
import java.util.Locale;
3435

3536
import permissions.dispatcher.NeedsPermission;
3637
import permissions.dispatcher.OnNeverAskAgain;
3738
import permissions.dispatcher.OnPermissionDenied;
3839
import permissions.dispatcher.RuntimePermissions;
3940

41+
@SuppressWarnings({"unused", "FieldCanBeLocal"})
4042
@RuntimePermissions
4143
public class MainActivity extends AppCompatActivity implements OnMapReadyCallback {
4244
private final int REQUEST_CODE_REQUEST_LOCATION_PERMISSION = 101;
@@ -174,7 +176,7 @@ public void run() {
174176
marker.setPosition(latLng);
175177
}
176178
}
177-
tv_position.setText(String.format(FORMAT_POSITION, lat, lng));
179+
tv_position.setText(String.format(Locale.getDefault(), FORMAT_POSITION, lat, lng));
178180
}
179181
});
180182
}
@@ -328,7 +330,7 @@ protected void initGoogleMap() {
328330
class ShowConnectionInfoThread extends Thread {
329331
private final RemoteListenerService service;
330332

331-
public ShowConnectionInfoThread(RemoteListenerService service) {
333+
ShowConnectionInfoThread(RemoteListenerService service) {
332334
this.service = service;
333335
}
334336

app/src/main/java/com/firemaples/androidlocationremotecontrol/RemoteListenerService.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import android.os.Bundle;
1313
import android.os.IBinder;
1414
import android.os.SystemClock;
15+
import android.support.annotation.NonNull;
1516
import android.support.v4.app.ActivityCompat;
1617
import android.support.v4.app.NotificationCompat;
1718

@@ -26,6 +27,7 @@
2627
import java.net.InetSocketAddress;
2728
import java.util.Date;
2829

30+
@SuppressWarnings({"FieldCanBeLocal", "unused"})
2931
public class RemoteListenerService extends Service implements GoogleApiClient.ConnectionCallbacks, GoogleApiClient.OnConnectionFailedListener {
3032
private final String MSG_GEO = "geo:";
3133

@@ -292,8 +294,8 @@ public void onConnectionSuspended(int i) {
292294
}
293295

294296
@Override
295-
public void onConnectionFailed(ConnectionResult connectionResult) {
296-
Utils.makeTestLog(this, "Google api :onConnectionFailed");
297+
public void onConnectionFailed(@NonNull ConnectionResult connectionResult) {
298+
Utils.makeTestLog(this, "Google api :onConnectionFailed:" + connectionResult.getErrorMessage());
297299
}
298300

299301
public class RemoteListenerBinder extends Binder {

0 commit comments

Comments
 (0)