Merge remote-tracking branch 'upstream/master' into width-adapter-fix-upstream-1.3.6

Author: sagark

.gitignore

@@ -35,6 +35,8 @@ waves.shm
 *.a
 *.ko
 
+!SDAccel/aws_platform/xilinx_aws-vu9p-f1_1ddr-xpr-2pr_4_0/libxilinxopencl.so
+
 nohup.out
 *.nohup.out
 
@@ -96,15 +98,5 @@ vivado*.log
 # pytest artifacts
 .cache/
 
-sdk/userspace/lib
-
-hdk/common/shell_v071417d3/build/debug_probes
-
-sdk/linux_kernel_drivers/edma/.edma-drv.ko.cmd
-sdk/linux_kernel_drivers/edma/.edma-drv.mod.o.cmd
-sdk/linux_kernel_drivers/edma/.edma-drv.o.cmd
-sdk/linux_kernel_drivers/edma/.edma.o.cmd
-sdk/linux_kernel_drivers/edma/.edma_backend_xdma.o.cmd
-sdk/linux_kernel_drivers/edma/.edma_dev.o.cmd
-sdk/linux_kernel_drivers/edma/.libxdma.o.cmd
-sdk/linux_kernel_drivers/edma/.tmp_versions/
+# Patches
+patches/*

ERRATA.md

@@ -21,9 +21,10 @@
 * FPGA to FPGA over the 400Gbps Ring for F1.16xl
 * Aurora and Reliable Aurora modules for the FPGA-to-FPGA 
 * Preserving the DRAM content between different AFI loads (by the same running instance)
-* Cadence RTL simulations tools
+* Cadence Xcelium simulations tools
 * PCIM and DMA-PCIS AXI-4 interfaces do not support AxSIZE other than 3'b110 (64B)
 
 ## Known Bugs/Issues
-
+* F1 CL designs using the v1.3 Shell must treat all clocks within the same group as asynchronous.  For example:  If using clk_main_a1, clk_extra_a1, clk_extra_a2, and clk_extra_a3 they need to be asynchronous.  See [AWS Shell Interface Specification](./hdk/docs/AWS_Shell_Interface_Specification.md)
+* The API fpga-load-local-image, has a bug in the error messaging which does not indicate a PCI ID mismatch occurred.  The PCI ID’s listed in the AFI manifest when an AFI is submitted to the CreateFpgaImage api (Vendor ID, Device ID, SubSystem ID, or SubSystem Vendor ID) should match the actual values in the submitted DCP. If there is a mismatch between the manifest IDs and the actual device ID, calling fpga-load-local-image on the AFI should report back load-failed (error 7), with a sub-error indicating there is a device ID mismatch. However, fpga-load-local-image does not report the sub-error, leaving no description as to why the load has failed.  Until this issue has been fixed, if you experience an AFI load-failed when loading the AFI,  double check the device IDs in the submitted manifest match the device IDs in the DCP.
 

FAQs.md

@@ -107,7 +107,8 @@ The developer can create multiple AFIs at no extra cost, up to a defined limited
 
 **Q: What regions are supported?**
 
-AWS FPGA generation and EC2 F1 instances are supported in us-east-1 (N. Virginia), us-west-2 (Oregon) and eu-west-1 (Ireland).
+AWS FPGA generation and EC2 F1 instances are supported in us-east-1 (N. Virginia), us-west-2 (Oregon), eu-west-1 (Ireland) and us-gov-west-1 (GovCloud US).
+
 
 
 **Q: What is the process for creating an AFI?**
@@ -137,6 +138,20 @@ Yes, use [delete-fpga-image](./hdk/docs/delete_fpga_image.md) to delete an AFI i
 
 Use [delete-fpga-image](./hdk/docs/delete_fpga_image.md) carefully. Once all AFIs of the same global AFI ID are deleted, the AFIs cannot be recovered from deletion.  Review [IAM policy best practices](http://docs.aws.amazon.com/IAM/latest/UserGuide/best-practices.html#grant-least-privilege) to restrict access to this API.
 
+**Q: Can I share an AFI with other AWS accounts?**
+
+Yes, sharing allows accounts other than the owner account to load and use an AFI.  Use [modify-fpga-image-attribute](./hdk/docs/fpga_image_attributes.md) API to update `loadPermission` attribute to grant/remove AFI load permission.  AWS AFIs support two load permission types:
+* `UserId`: share AFI with specific AWS accounts using account IDs.
+* `UserGroups`: only supports `all` group to make an AFI public or private.
+
+Use [reset-fpga-image-attribute](./hdk/docs/fpga_image_attributes.md) API to revoke all load permissions.
+
+**Q: Can I delete an AFI?**
+
+Yes, use [delete-fpga-image](./hdk/docs/delete_fpga_image.md) to delete an AFI in a specific region.  Deleting an AFI in one region does not affect AFIs in other regions.
+
+Use [delete-fpga-image](./hdk/docs/delete_fpga_image.md) carefully. Once all AFIs of the same global AFI ID are deleted, the AFIs cannot be recovered from deletion.  Review [IAM policy best practices](http://docs.aws.amazon.com/IAM/latest/UserGuide/best-practices.html#grant-least-privilege) to resrict access to this API.
+
 **Q: Can I bring my own bitstream for loading on an F1 FPGA?**
 
 No. There is no mechanism for loading a bitstream directly onto the FPGAs of an F1 instance. All Custom Logic is loaded onto the FPGA by calling `$ fpga-local-load-image` tool at [AWS FPGA SDK](./sdk). 
@@ -170,7 +185,7 @@ No. AWS supports a cloud-only development model and provides the necessary eleme
 
 **Q: Do I need to design for a specific power envelope?**
 
-Yes, the design scripts provided in the HDK include checks for power consumption that exceeds the allocated power for the Custom Logic (CL) region. Developers do not need to include design considerations for DRAM, Shell, or Thermal. AWS includes the design considerations for those as part of providing the power envelop for the CL region.
+Yes, the Xilinx UltraScale+ FPGA devices used on the F1 instances have a maximum power limit that must be maintained.  If a loaded AFI consumes maximum power, the F1 instance will automatically gate the input clocks provided to the AFI in order to prevent errors within the FPGA. Developers are provided warnings when power (Vccint) is greater than 85 watts.  Above that level, the CL is in danger of being clock gated.  [Additional details on AFI power](hdk/docs/afi_power.md)
 
 
 **Q: What IP blocks are provided in the HDK?**
@@ -190,6 +205,10 @@ Yes. Developers are free to use any IP blocks within the Custom Logic region. Th
 
 
 ## Getting Started
+**Q: What AWS knowledge do I need to learn before I can develop accelerators and run on AWS F1 instances?**
+
+[AWS Getting Started Resource Center](https://aws.amazon.com/getting-started/) has lots of resources to help developers get started.  For F1 development, launching linux virtual machines (EC2) and storing and retrieving files from S3 are required skills.  
+
 **Q: What do I need to get started on building accelerators for FPGA instances?**
 
 Getting started requires downloading the latest HDK and SDK from the AWS FPGA GitHub repository. The HDK and SDK provide the needed code and information for building FPGA code. The HDK provides all the information needed for developing an FPGA image from source code, while the SDK provides all the runtime software for managing the Amazon FPGA Image (AFI) loaded into the F1 instance FPGA.