From c283f8c74fef522e2a50268f52b5b680ef09e7ee Mon Sep 17 00:00:00 2001 From: Raghu Betina Date: Mon, 2 Mar 2026 11:55:28 -0600 Subject: [PATCH] Fix empty AICHAT_API_KEY fallback in specs In integration API key tests, treats empty strings as present and skips fallback. Use explicit empty checks before falling back to OPENAI_API_KEY for custom env-var and direct api_key test setup. This aligns test setup with runtime behavior and addresses the PR #56 review finding. --- spec/integration/ai_chat_integration_spec.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/spec/integration/ai_chat_integration_spec.rb b/spec/integration/ai_chat_integration_spec.rb index f288ee5..56617b7 100644 --- a/spec/integration/ai_chat_integration_spec.rb +++ b/spec/integration/ai_chat_integration_spec.rb @@ -230,7 +230,9 @@ end it "accepts a custom environment variable name" do - ENV["CUSTOM_OPENAI_KEY"] = ENV["AICHAT_API_KEY"] || ENV["OPENAI_API_KEY"] + preferred_key = ENV["AICHAT_API_KEY"] + preferred_key = ENV["OPENAI_API_KEY"] if preferred_key.to_s.empty? + ENV["CUSTOM_OPENAI_KEY"] = preferred_key chat = AI::Chat.new(api_key_env_var: "CUSTOM_OPENAI_KEY") chat.user("Hi") @@ -241,7 +243,9 @@ end it "accepts an API key directly" do - chat = AI::Chat.new(api_key: ENV["AICHAT_API_KEY"] || ENV["OPENAI_API_KEY"]) + api_key = ENV["AICHAT_API_KEY"] + api_key = ENV["OPENAI_API_KEY"] if api_key.to_s.empty? + chat = AI::Chat.new(api_key: api_key) chat.user("Hi") expect { chat.generate! }.not_to raise_error