[GVN] Clean up unused argument, unify style, modernize syntax (NFC)

Finalize code style overhaul in GVN, following up to
2a0946b and 9deed7d.

Author: antoniofrighetto

llvm/include/llvm/Transforms/Scalar/GVN.h

@@ -157,14 +157,14 @@ class GVNPass : public PassInfoMixin<GVNPass> {
   /// as an efficient mechanism to determine the expression-wise equivalence of
   /// two values.
   class ValueTable {
-    DenseMap<Value *, uint32_t> valueNumbering;
-    DenseMap<Expression, uint32_t> expressionNumbering;
+    DenseMap<Value *, uint32_t> ValueNumbering;
+    DenseMap<Expression, uint32_t> ExpressionNumbering;
 
     // Expressions is the vector of Expression. ExprIdx is the mapping from
     // value number to the index of Expression in Expressions. We use it
     // instead of a DenseMap because filling such mapping is faster than
     // filling a DenseMap and the compile time is a little better.
-    uint32_t nextExprNumber = 0;
+    uint32_t NextExprNumber = 0;
 
     std::vector<Expression> Expressions;
     std::vector<uint32_t> ExprIdx;
@@ -181,7 +181,7 @@ class GVNPass : public PassInfoMixin<GVNPass> {
     MemoryDependenceResults *MD = nullptr;
     DominatorTree *DT = nullptr;
 
-    uint32_t nextValueNumber = 1;
+    uint32_t NextValueNumber = 1;
 
     Expression createExpr(Instruction *I);
     Expression createCmpExpr(unsigned Opcode, CmpInst::Predicate Predicate,
@@ -190,11 +190,11 @@ class GVNPass : public PassInfoMixin<GVNPass> {
     Expression createGEPExpr(GetElementPtrInst *GEP);
     uint32_t lookupOrAddCall(CallInst *C);
     uint32_t phiTranslateImpl(const BasicBlock *BB, const BasicBlock *PhiBlock,
-                              uint32_t Num, GVNPass &Gvn);
+                              uint32_t Num, GVNPass &GVN);
     bool areCallValsEqual(uint32_t Num, uint32_t NewNum, const BasicBlock *Pred,
-                          const BasicBlock *PhiBlock, GVNPass &Gvn);
-    std::pair<uint32_t, bool> assignExpNewValueNum(Expression &exp);
-    bool areAllValsInBB(uint32_t num, const BasicBlock *BB, GVNPass &Gvn);
+                          const BasicBlock *PhiBlock, GVNPass &GVN);
+    std::pair<uint32_t, bool> assignExpNewValueNum(Expression &Exp);
+    bool areAllValsInBB(uint32_t Num, const BasicBlock *BB, GVNPass &GVN);
 
   public:
     ValueTable();
@@ -208,17 +208,17 @@ class GVNPass : public PassInfoMixin<GVNPass> {
     uint32_t lookupOrAddCmp(unsigned Opcode, CmpInst::Predicate Pred,
                             Value *LHS, Value *RHS);
     uint32_t phiTranslate(const BasicBlock *BB, const BasicBlock *PhiBlock,
-                          uint32_t Num, GVNPass &Gvn);
+                          uint32_t Num, GVNPass &GVN);
     void eraseTranslateCacheEntry(uint32_t Num, const BasicBlock &CurrBlock);
     bool exists(Value *V) const;
-    void add(Value *V, uint32_t num);
+    void add(Value *V, uint32_t Num);
     void clear();
-    void erase(Value *v);
+    void erase(Value *V);
     void setAliasAnalysis(AAResults *A) { AA = A; }
     AAResults *getAliasAnalysis() const { return AA; }
     void setMemDep(MemoryDependenceResults *M) { MD = M; }
     void setDomTree(DominatorTree *D) { DT = D; }
-    uint32_t getNextUnusedValueNumber() { return nextValueNumber; }
+    uint32_t getNextUnusedValueNumber() { return NextValueNumber; }
     void verifyRemoved(const Value *) const;
   };
 
@@ -327,9 +327,9 @@ class GVNPass : public PassInfoMixin<GVNPass> {
                OptimizationRemarkEmitter *ORE, MemorySSA *MSSA = nullptr);
 
   // List of critical edges to be split between iterations.
-  SmallVector<std::pair<Instruction *, unsigned>, 4> toSplit;
+  SmallVector<std::pair<Instruction *, unsigned>, 4> ToSplit;
 
-  // Helper functions of redundant load elimination
+  // Helper functions of redundant load elimination.
   bool processLoad(LoadInst *L);
   bool processNonLocalLoad(LoadInst *L);
   bool processAssumeIntrinsic(AssumeInst *II);
@@ -367,16 +367,16 @@ class GVNPass : public PassInfoMixin<GVNPass> {
       MapVector<BasicBlock *, Value *> &AvailableLoads,
       MapVector<BasicBlock *, LoadInst *> *CriticalEdgePredAndLoad);
 
-  // Other helper routines
+  // Other helper routines.
   bool processInstruction(Instruction *I);
   bool processBlock(BasicBlock *BB);
-  void dump(DenseMap<uint32_t, Value *> &d) const;
+  void dump(DenseMap<uint32_t, Value *> &Map) const;
   bool iterateOnFunction(Function &F);
   bool performPRE(Function &F);
   bool performScalarPRE(Instruction *I);
   bool performScalarPREInsertion(Instruction *Instr, BasicBlock *Pred,
                                  BasicBlock *Curr, unsigned int ValNo);
-  Value *findLeader(const BasicBlock *BB, uint32_t num);
+  Value *findLeader(const BasicBlock *BB, uint32_t Num);
   void cleanupGlobalSets();
   void removeInstruction(Instruction *I);
   void verifyRemoved(const Instruction *I) const;