Skip to content

Commit 84670ca

Browse files
authored
Move fabric_host_interface.h out of host API (tenstorrent#25711)
### Ticket tenstorrent#25750 ### Problem description fabric_host_interface.h is placed on public facing directory, but it only has internal only definitions. ### What's changed Move (and renamed) the file to hostdevcommon directory as it has common features for both host/device. The file also has methods only for host/device, so split the file for each actor. ### Checklist - [ ] [All post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml) CI passes - [ ] [Blackhole Post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/blackhole-post-commit.yaml) CI with demo tests passes (if applicable) - [ ] [Model regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-models.yaml) CI passes (if applicable) - [ ] [Device performance regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-device-models.yaml) CI passes (if applicable) - [ ] (For models and ops writers) [Single-card demo tests](https://github.com/tenstorrent/tt-metal/actions/workflows/single-card-demo-tests.yaml) CI passes (if applicable) See [recommended dev flow](https://github.com/tenstorrent/tt-metal/blob/main/models/MODEL_ADD.md#a-recommended-dev-flow-on-github-for-adding-new-models). - [ ] [Galaxy quick](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-quick-trigger.yaml) CI passes (if applicable) - [ ] [TG demo tests, for Llama](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-demo-tests.yaml) CI passes, if applicable, because of current Llama work - [ ] (For runtime and ops writers) [T3000 unit tests](https://github.com/tenstorrent/tt-metal/actions/workflows/t3000-unit-tests.yaml) CI passes (if applicable, since this is run on push to main) - [ ] (For models and ops writers) [T3000 demo tests](https://github.com/tenstorrent/tt-metal/actions/workflows/t3000-demo-tests.yaml) CI passes (if applicable, since this is required for release) - [ ] (For models and ops writers) [Single-card demo tests](https://github.com/tenstorrent/tt-metal/actions/workflows/single-card-demo-tests.yaml) CI passes (if applicable, since this is required for release) - [ ] New/Existing tests provide coverage for changes
1 parent cdff361 commit 84670ca

31 files changed

+315
-346
lines changed

setup.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,6 @@ def run(self) -> None:
293293
"api/tt-metalium/circular_buffer_constants.h",
294294
"api/tt-metalium/constants.hpp",
295295
"api/tt-metalium/dev_msgs.h",
296-
"api/tt-metalium/fabric_host_interface.h",
297296
"api/tt-metalium/fabric_edm_types.hpp",
298297
"api/tt-metalium/fabric_edm_packet_header.hpp",
299298
"api/tt-metalium/edm_fabric_counters.hpp",

tests/tt_metal/multihost/fabric_tests/intermesh_routing_test_utils.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
#include <tt-metalium/device_pool.hpp>
1313
#include <tt-metalium/erisc_datamover_builder.hpp>
1414
#include <tt-metalium/fabric.hpp>
15-
#include <tt-metalium/fabric_host_interface.h>
1615
#include <tt-metalium/allocator.hpp>
1716
#include <tt-metalium/host_api.hpp>
1817

18+
#include "hostdevcommon/fabric_common.h"
1919
#include "tt_metal/fabric/hw/inc/tt_fabric_status.h"
2020
#include "tt_metal/fabric/fabric_context.hpp"
2121
#include "intermesh_routing_test_utils.hpp"

tests/tt_metal/tt_fabric/fabric_data_movement/test_basic_1d_fabric.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include <tt-metalium/control_plane.hpp>
99
#include <tt-metalium/device_pool.hpp>
1010
#include <tt-metalium/erisc_datamover_builder.hpp>
11-
#include <tt-metalium/fabric_host_interface.h>
11+
#include "hostdevcommon/fabric_common.h"
1212
#include <array>
1313
#include <cstddef>
1414
#include <map>

tests/tt_metal/tt_fabric/fabric_data_movement/test_basic_fabric_apis.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#include <gtest/gtest.h>
77
#include <stdint.h>
88
#include <tt-metalium/device_pool.hpp>
9-
#include <tt-metalium/fabric_host_interface.h>
9+
#include "hostdevcommon/fabric_common.h"
1010
#include <algorithm>
1111
#include <map>
1212
#include <memory>

tests/tt_metal/tt_metal/perf_microbenchmark/routing/test_tt_fabric_multi_hop_sanity.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
#include <tt-metalium/core_coord.hpp>
2929
#include <tt-metalium/data_types.hpp>
3030
#include <tt-metalium/device.hpp>
31-
#include <tt-metalium/fabric_host_interface.h>
31+
#include "hostdevcommon/fabric_common.h"
3232
#include <tt-metalium/hal.hpp>
3333
#include <tt-metalium/hal_types.hpp>
3434
#include <tt-metalium/kernel_types.hpp>

tests/tt_metal/tt_metal/perf_microbenchmark/routing/test_tt_fabric_sanity.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
#include <tt-metalium/core_coord.hpp>
3535
#include <tt-metalium/data_types.hpp>
3636
#include <tt-metalium/device.hpp>
37-
#include <tt-metalium/fabric_host_interface.h>
37+
#include "hostdevcommon/fabric_common.h"
3838
#include <tt-metalium/fabric_types.hpp>
3939
#include <tt-metalium/hal.hpp>
4040
#include <tt-metalium/hal_types.hpp>

tests/tt_metal/tt_metal/perf_microbenchmark/routing/test_tt_fabric_socket_sanity.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
#include <tt-metalium/core_coord.hpp>
2727
#include <tt-metalium/data_types.hpp>
2828
#include <tt-metalium/device.hpp>
29-
#include <tt-metalium/fabric_host_interface.h>
29+
#include "hostdevcommon/fabric_common.h"
3030
#include <tt-metalium/hal.hpp>
3131
#include <tt-metalium/hal_types.hpp>
3232
#include <tt-metalium/kernel_types.hpp>

tt_metal/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ target_sources(
8181
api/tt-metalium/buffer_types.hpp
8282
api/tt-metalium/circular_buffer_constants.h
8383
api/tt-metalium/constants.hpp
84-
api/tt-metalium/fabric_host_interface.h
8584
api/tt-metalium/fabric_edm_packet_header.hpp
8685
api/tt-metalium/fabric_edm_types.hpp
8786
api/tt-metalium/edm_fabric_counters.hpp

tt_metal/api/tt-metalium/command_queue_interface.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include <enchantum/enchantum.hpp>
88
#include <mutex>
99
#include <tt-metalium/tt_align.hpp>
10-
#include <tt-metalium/fabric_host_interface.h>
10+
#include <hostdevcommon/fabric_common.h>
1111

1212
#include <tt-metalium/buffer.hpp>
1313
#include <umd/device/tt_core_coordinates.h>

tt_metal/api/tt-metalium/control_plane.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88

99
#include <tt_stl/span.hpp>
1010
#include <tt-metalium/routing_table_generator.hpp>
11-
#include <tt-metalium/fabric_host_interface.h>
1211
#include <tt-metalium/core_coord.hpp>
1312
#include <tt-metalium/mesh_coord.hpp>
1413
#include <tt-metalium/fabric_types.hpp>
1514
#include <tt-metalium/multi_mesh_types.hpp>
15+
#include <hostdevcommon/fabric_common.h>
1616

1717
#include <map>
1818
#include <unordered_map>

0 commit comments

Comments
 (0)