Greptile comments

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Author: dbochkov-flexcompute

tests/test_components/test_low_freq_smoothing.py

@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+import pydantic.v1 as pydantic
 import pytest
 
 import tidy3d as td
@@ -18,7 +19,7 @@ def test_low_freq_smoothing_spec_initialization_default_values():
 
 def test_empty_monitors():
     """Test that LowFrequencySmoothingSpec raises an error if monitors are not provided."""
-    with pytest.raises(ValueError):
+    with pytest.raises(pydantic.ValidationError):
         td.LowFrequencySmoothingSpec(monitors=[])
 
 
@@ -39,7 +40,7 @@ def test_monitors_exist():
         low_freq_smoothing=td.LowFrequencySmoothingSpec(monitors=["monitor1"]),
     )
 
-    with pytest.raises(ValueError):
+    with pytest.raises(pydantic.ValidationError):
         sim = td.Simulation(
             size=(1, 1, 1),
             monitors=[],

tidy3d/components/frequency_extrapolation.py

@@ -75,6 +75,6 @@ def _validate_sampling_times(cls, values):
     @pydantic.validator("monitors", always=True)
     def _validate_monitors(cls, val, values):
         """Validate the monitors list is not empty."""
-        if len(val) == 0:
+        if not val:
             raise ValueError("The monitors list must not be empty.")
         return val

tidy3d/components/simulation.py

@@ -4062,7 +4062,6 @@ def _validate_low_freq_smoothing(cls, val, values):
         present_mode_monitor_names = [
             monitor.name for monitor in monitors if isinstance(monitor, ModeMonitor)
         ]
-        print("present_mode_monitor_names: ", present_mode_monitor_names)
         for monitor in val.monitors:
             if monitor not in present_mode_monitor_names:
                 raise SetupError(

tidy3d/plugins/smatrix/component_modelers/terminal.py

@@ -413,7 +413,7 @@ def base_sim(self) -> Simulation:
 
         # propagate the low frequency smoothing specification to the simulation
         mode_monitors = [mnt.name for mnt in field_monitors if isinstance(mnt, ModeMonitor)]
-        if len(mode_monitors) > 0 and self.low_freq_smoothing is not None:
+        if mode_monitors and self.low_freq_smoothing is not None:
             update_dict["low_freq_smoothing"] = LowFrequencySmoothingSpec(
                 monitors=mode_monitors,
                 min_sampling_time=self.low_freq_smoothing.min_sampling_time,