Skip to content

When selecting a composite mesh with the cursor gizmo, ensure that the entire mesh is selected, rather than just that specific sub-mesh #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

When selecting a composite mesh with the cursor gizmo, ensure that the entire mesh is selected, rather than just that specific sub-mesh #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ccf218c
Add debug message to get parent of picked mesh when using select gizmo
Zishan-Rahman Sep 8, 2025
1353acb
Create function in ui/blockmesh.js for returning the root of a compos…
Zishan-Rahman Sep 8, 2025
79c632b
Add debug message to getRootMesh and rewrite conditional block in get…
Zishan-Rahman Sep 8, 2025
bc54b21
Make pickedMesh no longer a constant in pointerObserver for select gizmo
Zishan-Rahman Sep 8, 2025
cb59285
Use getRootMesh function from ui/blockmesh.js to retrieve root from c…
Zishan-Rahman Sep 8, 2025
96017d6
Fix error of undefined pickedMesh by actually defining pickedMesh as …
Zishan-Rahman Sep 8, 2025
2f25e0c
Rewrite getRootMesh to ensure parent mesh with name "__root__" is ret…
Zishan-Rahman Sep 8, 2025
9645804
Merge branch 'main'
Zishan-Rahman Sep 11, 2025
dac8094
Merge branch 'main'
Zishan-Rahman Sep 15, 2025
c26a1bd
Set root mesh visibility
Zishan-Rahman Sep 15, 2025
010a9fd
Get getRootMesh to return parent of "__root__" mesh in order to show …
Zishan-Rahman Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ui/blockmesh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ const colorFields = {
SLEEVES_COLOR: true,
};

export function getRootMesh(mesh) {
if (flock.meshDebug) console.log(mesh.parent);
if (mesh.parent && mesh.name === "__root__") return mesh.parent;
return getRootMesh(mesh.parent);
}

export function updateOrCreateMeshFromBlock(block, changeEvent) {

if (flock.meshDebug)
Expand Down
12 changes: 10 additions & 2 deletions ui/gizmos.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as Blockly from "blockly";
import { meshMap, meshBlockIdMap } from "../generators";
import { flock } from "../flock.js";
import { setPositionValues } from "./addmeshes.js";
import { getMeshFromBlockKey, updateBlockColorAndHighlight } from "./blockmesh.js";
import { getMeshFromBlockKey, getRootMesh, updateBlockColorAndHighlight } from "./blockmesh.js";
export let gizmoManager;

const blueColor = flock.BABYLON.Color3.FromHexString("#0072B2"); // Colour for X-axis
Expand Down Expand Up @@ -621,7 +621,7 @@ export function toggleGizmo(gizmoType) {
gizmoManager.attachedMesh,
).metadata.blockKey;
}
const pickedMesh = event.pickInfo.pickedMesh;
let pickedMesh = event.pickInfo.pickedMesh;

if (pickedMesh && pickedMesh.name !== "ground") {
// Assuming 'mesh' is your Babylon.js mesh object
Expand All @@ -639,6 +639,14 @@ export function toggleGizmo(gizmoType) {
color: "black"
});

if (flock.meshDebug) console.log(pickedMesh.parent);

if (pickedMesh.parent) {
pickedMesh = getRootMesh(pickedMesh.parent);
if (flock.meshDebug) console.log(pickedMesh.visibility);
pickedMesh.visibility = 0.001;
if (flock.meshDebug) console.log(pickedMesh.visibility);
}

const block = meshMap[blockKey];
highlightBlockById(Blockly.getMainWorkspace(), block);
Expand Down