[webview_flutter] General improvements (#500)

Author: swift-kim

packages/google_maps_flutter/example/tizen/tizen-manifest.xml

@@ -1,11 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest package="org.tizen.google_maps_flutter_tizen_example" version="1.0.0" api-version="5.5" xmlns="http://tizen.org/ns/packages">
-    <profile name="mobile"/>
-    <ui-application appid="org.tizen.google_maps_flutter_tizen_example" exec="Runner.dll" type="dotnet" multiple="false" taskmanage="true" nodisplay="false" launch_mode="single">
+    <profile name="common"/>
+    <ui-application appid="org.tizen.google_maps_flutter_tizen_example" exec="Runner.dll" type="dotnet" multiple="false" taskmanage="true" nodisplay="false">
         <label>google_maps_flutter_tizen_example</label>
         <icon>ic_launcher.png</icon>
         <metadata key="http://tizen.org/metadata/prefer_dotnet_aot" value="true"/>
-        <metadata key="http://tizen.org/metadata/direct-launch" value="yes"/>
     </ui-application>
     <privileges>
         <privilege>http://tizen.org/privilege/internet</privilege>

packages/webview_flutter/CHANGELOG.md

@@ -1,10 +1,20 @@
+## 0.6.2
+
+* Remove the use of internal API `ewk_settings_viewport_meta_tag_set`.
+* Fix crash when JavaScript evaluation result is null.
+* Change the project type to staticLib.
+* Enable back key navigation.
+* Implement `WebSettings.javascriptMode` and `WebViewController.clearCache`.
+* Redirect console messages to stdout/stderr.
+* Minor code cleanups.
+
 ## 0.6.1
 
-*  Fix canGoBack/Forward error
+* Fix canGoBack/Forward error.
 
 ## 0.6.0
 
-*  Change the backing web engine from LWE to EFL WebKit (EWK).
+* Change the backing web engine from LWE to EFL WebKit (EWK).
 
 ## 0.5.6
 

packages/webview_flutter/README.md

@@ -2,7 +2,8 @@
 
 [![pub package](https://img.shields.io/pub/v/webview_flutter_tizen.svg)](https://pub.dev/packages/webview_flutter_tizen)
 
-The Tizen implementation of [`webview_flutter`](https://github.com/flutter/plugins/tree/main/packages/webview_flutter) only for Tizen TV devices.  
+The Tizen implementation of [`webview_flutter`](https://github.com/flutter/plugins/tree/main/packages/webview_flutter) for Tizen TV devices.
+
 The WebView widget is backed by the EFL WebKit (EWK) on Tizen.
 
 ## Required privileges
@@ -22,7 +23,7 @@ This package is not an _endorsed_ implementation of `webview_flutter`. Therefore
 ```yaml
 dependencies:
   webview_flutter: ^3.0.4
-  webview_flutter_tizen: ^0.6.1
+  webview_flutter_tizen: ^0.6.2
 ```
 
 ## Example
@@ -47,4 +48,4 @@ class WebViewExampleState extends State<WebViewExample> {
 
 ## Supported devices
 
-This plugin is supported on Tizen TV devices running Tizen 5.5 or later.  
+This plugin is only supported on Tizen TV devices running Tizen 5.5 or later.  

packages/webview_flutter/example/tizen/tizen-manifest.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest package="org.tizen.webview_flutter_tizen_example" version="1.0.0" api-version="5.5" xmlns="http://tizen.org/ns/packages">
     <profile name="common"/>
-    <ui-application appid="org.tizen.webview_flutter_tizen_example" exec="Runner.dll" type="dotnet" multiple="false" taskmanage="true" nodisplay="false" launch_mode="single">
+    <ui-application appid="org.tizen.webview_flutter_tizen_example" exec="Runner.dll" type="dotnet" multiple="false" taskmanage="true" nodisplay="false">
         <label>webview_flutter_tizen_example</label>
         <icon>ic_launcher.png</icon>
         <metadata key="http://tizen.org/metadata/prefer_dotnet_aot" value="true"/>

packages/webview_flutter/pubspec.yaml

@@ -2,7 +2,7 @@ name: webview_flutter_tizen
 description: Tizen implementation of the webview plugin
 homepage: https://github.com/flutter-tizen/plugins
 repository: https://github.com/flutter-tizen/plugins/tree/master/packages/webview_flutter
-version: 0.6.1
+version: 0.6.2
 
 environment:
   sdk: ">=2.17.0 <3.0.0"
@@ -22,7 +22,3 @@ dependencies:
   flutter_tizen: ^0.2.0
   webview_flutter: ^3.0.4
   webview_flutter_platform_interface: ^1.8.0
-
-dev_dependencies:
-  flutter_test:
-    sdk: flutter

packages/webview_flutter/tizen/project_def.prop

@@ -2,7 +2,7 @@
 # for details.
 
 APPNAME = webview_flutter_tizen_plugin
-type = sharedLib
+type = staticLib
 profile = common-5.5
 
 # Source files
@@ -22,8 +22,3 @@ USER_CPPFLAGS_MISC =
 USER_INC_DIRS = inc src
 USER_INC_FILES =
 USER_CPP_INC_FILES =
-
-# Linker options
-USER_LIBS =
-USER_LIB_DIRS =
-USER_LFLAGS =

packages/webview_flutter/tizen/src/ewk_internal_api_binding.cc

@@ -17,7 +17,7 @@ EwkInternalApiBinding::~EwkInternalApiBinding() {
 }
 
 bool EwkInternalApiBinding::Initialize() {
-  if (handle_ == nullptr) {
+  if (!handle_) {
     return false;
   }
 

packages/webview_flutter/tizen/src/ewk_internal_api_binding.h

@@ -59,7 +59,7 @@ typedef void (*EwkSettingsImePanelEnabledSetFnPtr)(Ewk_Settings* settings,
 
 typedef struct {
   EwkSettingsImePanelEnabledSetFnPtr ImePanelEnabledSet = nullptr;
-} EWKSettingsProcTable;
+} EwkSettingsProcTable;
 
 typedef struct _Ewk_Console_Message Ewk_Console_Message;
 
@@ -86,7 +86,7 @@ typedef struct {
   EwkConsoleMessageTextGetFnPtr TextGet = nullptr;
   EwkConsoleMessageLineGetFnPtr LineGet = nullptr;
   EwkConsoleMessageSourceGetFnPtr SourceGet = nullptr;
-} EWKConsoleMessageProcTable;
+} EwkConsoleMessageProcTable;
 
 class EwkInternalApiBinding {
  public:
@@ -98,15 +98,14 @@ class EwkInternalApiBinding {
   ~EwkInternalApiBinding();
 
   EwkInternalApiBinding(const EwkInternalApiBinding&) = delete;
-
   EwkInternalApiBinding& operator=(const EwkInternalApiBinding&) = delete;
 
   bool Initialize();
 
   EwkViewProcTable view;
   EwkMainProcTable main;
-  EWKSettingsProcTable settings;
-  EWKConsoleMessageProcTable console_message;
+  EwkSettingsProcTable settings;
+  EwkConsoleMessageProcTable console_message;
 
  private:
   EwkInternalApiBinding();