Skip to content

Commit 952418d

Browse files
authored
[web_benchmarks] Report correct expected metrics for wasm (#10236)
Depends on flutter/flutter@2e51c3f which will be part of the `3.38.0` release. Fixes flutter/flutter#177057
1 parent 1e7a00a commit 952418d

File tree

4 files changed

+17
-15
lines changed

4 files changed

+17
-15
lines changed

packages/web_benchmarks/CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
## NEXT
1+
## 4.1.0
22

3-
* Updates minimum supported SDK version to Flutter 3.32/Dart 3.8.
3+
* Fixes the reported metrics in `expectedBenchmarkMetrics` for wasm.
4+
* Updates minimum supported SDK version to Flutter 3.38/Dart 3.10.
45

56
## 4.0.0
67

packages/web_benchmarks/lib/src/metrics.dart

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -144,14 +144,15 @@ final class PercentileMetricComputation extends BenchmarkMetricComputation {
144144

145145
/// The list of expected benchmark metrics for the current compilation mode, as
146146
/// determined by the value of [useWasm].
147-
List<BenchmarkMetric> expectedBenchmarkMetrics({required bool useWasm}) {
147+
List<BenchmarkMetric> expectedBenchmarkMetrics({
148+
@Deprecated(
149+
'This parameter is unused and will be removed in a future release.',
150+
)
151+
bool? useWasm,
152+
}) {
148153
return <BenchmarkMetric>[
149-
// The skwasm renderer doesn't have preroll or apply frame steps in its
150-
// rendering.
151-
if (!useWasm) ...<BenchmarkMetric>[
152-
BenchmarkMetric.prerollFrame,
153-
BenchmarkMetric.applyFrame,
154-
],
154+
BenchmarkMetric.prerollFrame,
155+
BenchmarkMetric.applyFrame,
155156
BenchmarkMetric.drawFrame,
156157
BenchmarkMetric.flutterFrameTotalTime,
157158
BenchmarkMetric.flutterFrameBuildTime,

packages/web_benchmarks/pubspec.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ name: web_benchmarks
22
description: A benchmark harness for performance-testing Flutter apps in Chrome.
33
repository: https://github.com/flutter/packages/tree/main/packages/web_benchmarks
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+web_benchmarks%22
5-
version: 4.0.0
5+
version: 4.1.0
66

77
environment:
8-
sdk: ^3.8.0
9-
flutter: ">=3.32.0"
8+
sdk: ^3.10.0
9+
flutter: ">=3.38.0"
1010

1111
dependencies:
1212
collection: ^1.18.0

packages/web_benchmarks/testing/test_app/benchmark/web_benchmarks_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@ Future<BenchmarkResults> _runBenchmarks({
8484
compilationOptions: compilationOptions,
8585
);
8686

87-
final List<String> expectedMetrics = expectedBenchmarkMetrics(
88-
useWasm: compilationOptions.useWasm,
89-
).map((BenchmarkMetric metric) => metric.label).toList();
87+
final List<String> expectedMetrics = expectedBenchmarkMetrics()
88+
.map((BenchmarkMetric metric) => metric.label)
89+
.toList();
9090

9191
for (final String benchmarkName in benchmarkNames) {
9292
for (final String metricName in expectedMetrics) {

0 commit comments

Comments
 (0)