File tree Expand file tree Collapse file tree 4 files changed +17
-15
lines changed
testing/test_app/benchmark Expand file tree Collapse file tree 4 files changed +17
-15
lines changed Original file line number Diff line number Diff line change 1- ## NEXT
1+ ## 4.1.0
22
3- * Updates minimum supported SDK version to Flutter 3.32/Dart 3.8.
3+ * Fixes the reported metrics in ` expectedBenchmarkMetrics ` for wasm.
4+ * Updates minimum supported SDK version to Flutter 3.38/Dart 3.10.
45
56## 4.0.0
67
Original file line number Diff line number Diff line change @@ -144,14 +144,15 @@ final class PercentileMetricComputation extends BenchmarkMetricComputation {
144144
145145/// The list of expected benchmark metrics for the current compilation mode, as
146146/// determined by the value of [useWasm] .
147- List <BenchmarkMetric > expectedBenchmarkMetrics ({required bool useWasm}) {
147+ List <BenchmarkMetric > expectedBenchmarkMetrics ({
148+ @Deprecated (
149+ 'This parameter is unused and will be removed in a future release.' ,
150+ )
151+ bool ? useWasm,
152+ }) {
148153 return < BenchmarkMetric > [
149- // The skwasm renderer doesn't have preroll or apply frame steps in its
150- // rendering.
151- if (! useWasm) ...< BenchmarkMetric > [
152- BenchmarkMetric .prerollFrame,
153- BenchmarkMetric .applyFrame,
154- ],
154+ BenchmarkMetric .prerollFrame,
155+ BenchmarkMetric .applyFrame,
155156 BenchmarkMetric .drawFrame,
156157 BenchmarkMetric .flutterFrameTotalTime,
157158 BenchmarkMetric .flutterFrameBuildTime,
Original file line number Diff line number Diff line change @@ -2,11 +2,11 @@ name: web_benchmarks
22description : A benchmark harness for performance-testing Flutter apps in Chrome.
33repository : https://github.com/flutter/packages/tree/main/packages/web_benchmarks
44issue_tracker : https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+web_benchmarks%22
5- version : 4.0 .0
5+ version : 4.1 .0
66
77environment :
8- sdk : ^3.8 .0
9- flutter : " >=3.32 .0"
8+ sdk : ^3.10 .0
9+ flutter : " >=3.38 .0"
1010
1111dependencies :
1212 collection : ^1.18.0
Original file line number Diff line number Diff line change @@ -84,9 +84,9 @@ Future<BenchmarkResults> _runBenchmarks({
8484 compilationOptions: compilationOptions,
8585 );
8686
87- final List <String > expectedMetrics = expectedBenchmarkMetrics (
88- useWasm : compilationOptions.useWasm,
89- ). map (( BenchmarkMetric metric) => metric.label) .toList ();
87+ final List <String > expectedMetrics = expectedBenchmarkMetrics ()
88+ . map (( BenchmarkMetric metric) => metric.label)
89+ .toList ();
9090
9191 for (final String benchmarkName in benchmarkNames) {
9292 for (final String metricName in expectedMetrics) {
You can’t perform that action at this time.
0 commit comments