refactor(overlay): simplify anisotropy clamps with safeWidth/safeHeight; remove redundant abs;\nchore(controller): warn once when getBoundingSphere is missing; add comment clarifying effective MAX in auto tessellation

Author: flyingrobots

src/engine/render/DebugOverlaySystem.ts

@@ -90,13 +90,14 @@ export class DebugOverlaySystem implements EngineSystem {
       if (hasOrthoExtents) {
         const rawWidth = right - left
         const rawHeight = top - bottom
-        const worldWidth = Math.max(1e-6, Math.abs(rawWidth))
-        const worldHeight = Math.max(1e-6, Math.abs(rawHeight))
-        // Guard: inverted extents → uniform scale fallback
+        // Guard: inverted or non-positive extents → uniform scale fallback
         if (rawWidth <= 0 || rawHeight <= 0) {
           mesh.scale.set(r, r, 1)
           return
         }
+        // Clamp tiny dimensions to a small epsilon to avoid divide-by-zero
+        const safeWidth = Math.max(1e-6, rawWidth)
+        const safeHeight = Math.max(1e-6, rawHeight)
         let viewportWidth = 1
         let viewportHeight = 1
         const anyView = this.view as unknown as { getViewportPixels?: () => { width: number; height: number } }
@@ -107,8 +108,8 @@ export class DebugOverlaySystem implements EngineSystem {
             viewportHeight = vp.height
           }
         } catch { /* no-op */ }
-        const pxPerMeterX = viewportWidth / worldWidth
-        const pxPerMeterY = viewportHeight / worldHeight
+        const pxPerMeterX = viewportWidth / safeWidth
+        const pxPerMeterY = viewportHeight / safeHeight
         const k = pxPerMeterX / pxPerMeterY
         if (Number.isFinite(k) && k > 0) {
           mesh.scale.set(r, r * k, 1)

src/lib/clothSceneController.ts

@@ -84,6 +84,7 @@ class ClothBodyAdapter implements SimBody, Component {
   private _worldSleepVelThreshold = 0.001
   private _worldSleepFrameThreshold = 60
   private _worldSleepGuardEnabled = true
+  private _warnedAboutMissingBoundingSphere = false
 
   constructor(
     id: string,
@@ -163,6 +164,11 @@ class ClothBodyAdapter implements SimBody, Component {
         }
       }
       this._lastWorldCenter.copy(worldCenter)
+      } else {
+        if (!this._warnedAboutMissingBoundingSphere) {
+          console.warn(`ClothBodyAdapter ${this.id}: getBoundingSphere not available, world sleep guard disabled`)
+          this._warnedAboutMissingBoundingSphere = true
+        }
       }
     }
 
@@ -527,6 +533,7 @@ export class ClothSceneController {
     const MAX_TESSELLATION_CAP = 48
     const rawMax = round(maxCap)
     const maxUser = clamp(round(this.debug.tessellationMax ?? maxCap), MIN_SEGMENTS + 2, MAX_TESSELLATION_CAP)
+    // Effective max is the lesser of: user-configured max and the provided cap, both bounded by global limits
     const MAX = Math.min(clamp(rawMax, MIN_SEGMENTS + 2, MAX_TESSELLATION_CAP), maxUser)
 
     const desired = round(MIN_SEGMENTS + s * (MAX - MIN_SEGMENTS))