Skip to content
This repository was archived by the owner on Mar 10, 2018. It is now read-only.
This repository was archived by the owner on Mar 10, 2018. It is now read-only.

Query with has_available_redemptions? #15

@sammdec

Description

@sammdec

Hi there, more of a query than an issue, I have found looking through your code really really helpful and have learnt alot from it, so thank you very much for that!

I noticed one method though and I don't see how it works and was hoping you might be able to shed light on it.

https://github.com/fnando/coupons/blob/master/lib/coupons/models/coupon.rb#L65
The method named has_available_redemptions?, I assume should return true if there is no limit set(0) but from this code it will return false?

Therefore would that not make redeemable? false as well

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions