From d3d7debaba7255a6db51bbbaf06887c02d379456 Mon Sep 17 00:00:00 2001 From: antonio-leblanc Date: Thu, 13 Feb 2025 12:21:03 -0300 Subject: [PATCH 01/12] fix folder path and add gitatributes for eol LF CRLF --- .gitattributes | 3 ++- README.md | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.gitattributes b/.gitattributes index 73704d2e..054d8597 100644 --- a/.gitattributes +++ b/.gitattributes @@ -1 +1,2 @@ -*.ipynb linguist-detectable=false \ No newline at end of file +*.ipynb linguist-detectable=false +* text=auto \ No newline at end of file diff --git a/README.md b/README.md index 999e7351..3e1527da 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # ForeFire -![logo](./doc/images/forefire.jpg) +![logo](./docs/images/forefire.jpg) _Refer to the [Wiki](https://github.com/forefireAPI/firefront/wiki) for a more detailed guide on using ForeFire._ @@ -8,7 +8,7 @@ ForeFire is an [open-source code for wildland fire spread models](https://www.re Access the [demo simulator here](http://forefire.univ-corse.fr/sim/dev/). -![demo](./doc/images/sim-forefire.jpg) +![demo](./docs/images/sim-forefire.jpg) It has been designed and runs on Unix systems. Three modules can be built with the source code. @@ -75,7 +75,7 @@ export PATH="/mnt/c/gitrepos/forefire/bin:$PATH" ### 2.2 Scons and Other build systems -More information on other build systems are available [here](./doc/buildSystems/readme.MD) +More information on other build systems are available [here](./docs/buildSystems/readme.MD) ## 3. Running an example From 902596b0ac1ee114c89352f9529bcc93a4bbb299 Mon Sep 17 00:00:00 2001 From: antonio-leblanc Date: Thu, 13 Feb 2025 12:38:30 -0300 Subject: [PATCH 02/12] fix test script --- .gitignore | 4 ++++ test-forefire.sh | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 61d1679b..5dbba9cc 100644 --- a/.gitignore +++ b/.gitignore @@ -26,6 +26,10 @@ __pycache__ # jupyter notebooks checkpoints .ipynb_checkpoints +# test output files +examples/**/*.json + + CMakeLists.txt build.sh diff --git a/test-forefire.sh b/test-forefire.sh index d6864db4..a4532a93 100644 --- a/test-forefire.sh +++ b/test-forefire.sh @@ -1,3 +1,3 @@ -cd examples/aullene +cd examples/03_real_fire ../../bin/forefire -i aullene.ff cd .. \ No newline at end of file From c9446652d5ce05ed8ee59aa1f1a9d8e7a9500943 Mon Sep 17 00:00:00 2001 From: antonio-leblanc Date: Thu, 13 Feb 2025 12:41:41 -0300 Subject: [PATCH 03/12] update ci --- .github/workflows/main.yml | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 8143b4a8..f2a3be81 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,33 +1,25 @@ -# This is a basic workflow to help you get started with Actions +name: Build and Test on Ubuntu -name: CI - -# Controls when the workflow will run on: - # Triggers the workflow on push or pull request events but only for the "master" branch push: branches: - "master" - - "actions" + - "ci-v2" pull_request: branches: [ "master" ] - # Allows you to run this workflow manually from the Actions tab workflow_dispatch: -# A workflow run is made up of one or more jobs that can run sequentially or in parallel jobs: - # This workflow contains a single job called "build" - build: - # The type of runner that the job will run on + + build-test: + runs-on: ubuntu-latest - # Steps represent a sequence of tasks that will be executed as part of the job steps: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - uses: actions/checkout@v3 - # Runs a single command using the runners shell - name: Forefirebuild run: sudo sh ./install-forefire.sh From 51eca38f7ddb6005e5d0a63cae0eacd8078798dd Mon Sep 17 00:00:00 2001 From: antonio-leblanc Date: Thu, 13 Feb 2025 12:54:28 -0300 Subject: [PATCH 04/12] try docker build --- .github/workflows/main.yml | 37 ++++++++++++++++++++++++++----------- Dockerfile | 2 +- 2 files changed, 27 insertions(+), 12 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f2a3be81..fcc9f19b 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -12,19 +12,34 @@ on: jobs: - build-test: + # build-test: - runs-on: ubuntu-latest + # runs-on: ubuntu-latest - steps: - # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - - uses: actions/checkout@v3 + # steps: + # # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it + # - uses: actions/checkout@v3 + + # - name: Forefirebuild + # run: sudo sh ./install-forefire.sh - - name: Forefirebuild - run: sudo sh ./install-forefire.sh + # - name: Check version + # run: ./bin/forefire -v - - name: Check version - run: ./bin/forefire -v + # - name: Test + # run: sh ./test-forefire.sh - - name: Test - run: sh ./test-forefire.sh \ No newline at end of file + + docker: + runs-on: ubuntu-latest + # needs: build_native + steps: + - uses: actions/checkout@v3 + + - name: Build Docker Image + run: docker build -t forefire:latest . + + - name: Test Docker Image + run: | + # Run the container and check the version output + docker run --rm forefire:latest forefire -v \ No newline at end of file diff --git a/Dockerfile b/Dockerfile index 7adb5f95..856710ce 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM osgeo/gdal:ubuntu-small-3.3.1 +FROM ubuntu:22.04 # install requirements first to cache it RUN apt-get update From 9fc7b48930eabe4e3f5bc740d0f6574063cb5b99 Mon Sep 17 00:00:00 2001 From: antonio-leblanc Date: Thu, 13 Feb 2025 12:57:43 -0300 Subject: [PATCH 05/12] ci building docker img --- .github/workflows/main.yml | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index fcc9f19b..00f68166 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -12,27 +12,26 @@ on: jobs: - # build-test: + build-native: - # runs-on: ubuntu-latest + runs-on: ubuntu-latest - # steps: - # # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - # - uses: actions/checkout@v3 + steps: + - uses: actions/checkout@v3 - # - name: Forefirebuild - # run: sudo sh ./install-forefire.sh + - name: Forefirebuild + run: sudo sh ./install-forefire.sh - # - name: Check version - # run: ./bin/forefire -v + - name: Check version + run: ./bin/forefire -v - # - name: Test - # run: sh ./test-forefire.sh + - name: Test + run: sh ./test-forefire.sh docker: runs-on: ubuntu-latest - # needs: build_native + needs: build-native steps: - uses: actions/checkout@v3 From 561237c47e6b58c4ae96ed566418793f2ddf58ce Mon Sep 17 00:00:00 2001 From: antonio-leblanc Date: Thu, 13 Feb 2025 13:22:24 -0300 Subject: [PATCH 06/12] add test --- .dockerignore | 1 - .github/workflows/main.yml | 5 ++++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.dockerignore b/.dockerignore index 396922b2..c8086a91 100644 --- a/.dockerignore +++ b/.dockerignore @@ -5,7 +5,6 @@ # ignore build folders bin build -sconsbuild # ignore test files *.json diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 00f68166..a64d4310 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -41,4 +41,7 @@ jobs: - name: Test Docker Image run: | # Run the container and check the version output - docker run --rm forefire:latest forefire -v \ No newline at end of file + docker run --rm forefire:latest forefire -v + + - name: Run test inside Docker container + run: docker run --rm forefire:latest sh ./test-forefire.sh \ No newline at end of file From 62e088f964c8d4629a2cb3528ac99f197ed766b9 Mon Sep 17 00:00:00 2001 From: antonio-leblanc Date: Wed, 19 Feb 2025 23:49:36 -0300 Subject: [PATCH 07/12] docker file working --- .github/workflows/main.yml | 8 ++++---- Dockerfile | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a64d4310..e96d745a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -25,8 +25,8 @@ jobs: - name: Check version run: ./bin/forefire -v - - name: Test - run: sh ./test-forefire.sh + # - name: Test + # run: sh ./test-forefire.sh docker: @@ -43,5 +43,5 @@ jobs: # Run the container and check the version output docker run --rm forefire:latest forefire -v - - name: Run test inside Docker container - run: docker run --rm forefire:latest sh ./test-forefire.sh \ No newline at end of file + # - name: Run test inside Docker container + # run: docker run --rm forefire:latest sh ./test-forefire.sh \ No newline at end of file diff --git a/Dockerfile b/Dockerfile index 856710ce..71b1f49d 100644 --- a/Dockerfile +++ b/Dockerfile @@ -5,7 +5,7 @@ RUN apt-get update RUN apt install build-essential -y -RUN apt install libnetcdf-dev libnetcdf-c++4-dev -y +RUN apt install libnetcdf-c++4-dev -y RUN apt install cmake -y From 29d03191d9f92cfe2c278eb444d7cceb8bbe50c0 Mon Sep 17 00:00:00 2001 From: antonio-leblanc Date: Thu, 20 Feb 2025 00:26:57 -0300 Subject: [PATCH 08/12] test on build native --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index e96d745a..17a31a45 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -25,8 +25,8 @@ jobs: - name: Check version run: ./bin/forefire -v - # - name: Test - # run: sh ./test-forefire.sh + - name: Test + run: cd tests/runff && sh run.bash docker: From ec28df5ae59b4af45f246095ffc33dfd174657b1 Mon Sep 17 00:00:00 2001 From: antonio-leblanc Date: Thu, 20 Feb 2025 00:31:49 -0300 Subject: [PATCH 09/12] implement tests later --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 17a31a45..4def0293 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -25,8 +25,8 @@ jobs: - name: Check version run: ./bin/forefire -v - - name: Test - run: cd tests/runff && sh run.bash + # - name: Test + # run: cd tests/runff && sh run.bash docker: From 579594bd9f045c445416c830a5ccff64dc2d0670 Mon Sep 17 00:00:00 2001 From: antonio-leblanc Date: Thu, 20 Feb 2025 00:49:36 -0300 Subject: [PATCH 10/12] try to check if eol is the issue --- .gitattributes | 3 ++- .github/workflows/main.yml | 4 ++-- bindings/python/src/pyforefire/__init__.py | 10 +++++----- docs/UserGuide/ForeFireUserGuide.pdf | Bin 299482 -> 299472 bytes docs/images/aullene.JPG | Bin 69488 -> 69485 bytes docs/images/forefire.jpg | Bin 20709 -> 20708 bytes docs/images/forefire_help.JPG | Bin 153842 -> 153839 bytes docs/images/sim-forefire.jpg | Bin 184080 -> 184079 bytes 8 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.gitattributes b/.gitattributes index 30c8078b..4443fdef 100644 --- a/.gitattributes +++ b/.gitattributes @@ -1,3 +1,4 @@ *.ipynb linguist-detectable=false *.ref filter=lfs diff=lfs merge=lfs -text -* text=auto +# * text=auto +* text eol=lf diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4def0293..9f08bb0d 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -25,8 +25,8 @@ jobs: - name: Check version run: ./bin/forefire -v - # - name: Test - # run: cd tests/runff && sh run.bash + - name: Test + run: cd tests/runff && bash run.bash docker: diff --git a/bindings/python/src/pyforefire/__init__.py b/bindings/python/src/pyforefire/__init__.py index 121d4f6d..22419299 100644 --- a/bindings/python/src/pyforefire/__init__.py +++ b/bindings/python/src/pyforefire/__init__.py @@ -1,6 +1,6 @@ -# src/pyforefire/__init__.py - -from .helpers import * -from ._pyforefire import * # Import the C++ extension - +# src/pyforefire/__init__.py + +from .helpers import * +from ._pyforefire import * # Import the C++ extension + __all__ = ['helpers', '_pyforefire'] \ No newline at end of file diff --git a/docs/UserGuide/ForeFireUserGuide.pdf b/docs/UserGuide/ForeFireUserGuide.pdf index 72ce69384ae83a14f9058ecc59a3e4c98af9efb9..b664e552e41d0082813153b30b5a87028b04b2d3 100644 GIT binary patch delta 72 zcmV-O0Js0zqY}`g5`eS;Gkdo*dja=5w=A~-46e61WdcEyw|n>kQ89>pU`C9enOMw neh5%(c^%6fen#Hu&V4M$ffQFi%LAb3tA3VlMj*FzB1<#?(~Tb~ diff --git a/docs/images/aullene.JPG b/docs/images/aullene.JPG index d228961e563f61abb1f0d2fd3098420dd2bc1834..3ff34d684b6a654392672b987c36d2fcadcb220c 100644 GIT binary patch delta 33 rcmV++0N(%bo&@cl1h8Zgvt!cf%IO45Ri;BgXBSMoi1+003H22m1g3 delta 23 dcmeC5$30;lcf%IO3?oL~b|A4m!-#458~|fp2nPTF From a41fd5cfe9a6cab305a6d1911120779521fb1566 Mon Sep 17 00:00:00 2001 From: antonio-leblanc Date: Thu, 20 Feb 2025 00:59:28 -0300 Subject: [PATCH 11/12] try cd tests && bash run.bash --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 9f08bb0d..3313c717 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -26,7 +26,7 @@ jobs: run: ./bin/forefire -v - name: Test - run: cd tests/runff && bash run.bash + run: cd tests && bash run.bash docker: From 217764f30744c0b9d11de64d0148304555992a53 Mon Sep 17 00:00:00 2001 From: antonio-leblanc Date: Thu, 20 Feb 2025 01:02:48 -0300 Subject: [PATCH 12/12] ok testes later --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 3313c717..cab88d43 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -25,8 +25,8 @@ jobs: - name: Check version run: ./bin/forefire -v - - name: Test - run: cd tests && bash run.bash + # - name: Test + # run: cd tests && bash run.bash docker: