Inconsistent naming of equality operator

[sim642]

Expr.Bool calls it equal:

smtml/src/smtml/expr_intf.ml

Lines 338 to 339 in f50d5bf

	(** [equal expr1 expr2] constructs an equality expression. *)
	val equal : t -> t -> t

The underlying Ty.Relop.t calls it Eq:

smtml/src/smtml/ty.ml

Line 404 in f50d5bf

| Eq

Typed.Bool calls it eq:

smtml/src/smtml/typed.mli

Lines 125 to 126 in f50d5bf

	(** [eq t1 t2] returns true if [t1] and [t2] are structurally equal. *)
	val eq : 'a expr -> 'a expr -> t

I guess it probably should also be Expr.Bool.eq.
Although Expr.Bool seems like a strange module altogether: there aren't Expr.Int, etc like under Typed.

[filipeom]

I guess it probably should also be Expr.Bool.eq

I agree, but now looking at the signature val eq : 'a expr -> 'a expr -> t doesn't feel very idiomatic ocaml. Maybe it should be equal everywhere?

Although Expr.Bool seems like a strange module altogether: there aren't Expr.Int, etc like under Typed

Yeah, historically we had a few constructors under Expr but now we're forcing everything to be under Typed. I'll eventually remove Expr.Bool in the next couple versions of smtml.

[sim642]

I think the eq name is fine, maybe even good. Because it has a totally different signature from the usual equal.

There might also be a reason to have the usual equal: t -> t -> bool at some point.