From b12c06b73ce441e6fe4ff57254dffd6eb9dab584 Mon Sep 17 00:00:00 2001 From: Sylvain Rabot Date: Fri, 23 Jan 2026 10:04:20 +0100 Subject: [PATCH] fix: --confirm=false wasn't working Signed-off-by: Sylvain Rabot --- pkg/approval.go | 9 +++------ pkg/command.go | 2 +- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/pkg/approval.go b/pkg/approval.go index b00dd0c7..02120007 100644 --- a/pkg/approval.go +++ b/pkg/approval.go @@ -25,14 +25,11 @@ const ( ) func NeedConfirm(cmd *cobra.Command) bool { - if GetBool(cmd, confirmFlag) { - return false - } - return true + return GetBool(cmd, confirmFlag) } func CheckStackApprobation(cmd *cobra.Command, disclaimer string, args ...any) bool { - if GetBool(cmd, confirmFlag) { + if !NeedConfirm(cmd) { return true } @@ -46,7 +43,7 @@ func CheckStackApprobation(cmd *cobra.Command, disclaimer string, args ...any) b } func CheckOrganizationApprobation(cmd *cobra.Command, disclaimer string, args ...any) bool { - if GetBool(cmd, confirmFlag) { + if !NeedConfirm(cmd) { return true } diff --git a/pkg/command.go b/pkg/command.go index ad6e122f..95b58828 100644 --- a/pkg/command.go +++ b/pkg/command.go @@ -299,7 +299,7 @@ func WithSilenceError() CommandOptionFn { } func WithConfirmFlag() CommandOptionFn { - return WithBoolFlag(confirmFlag, false, "Confirm action") + return WithBoolFlag(confirmFlag, true, "Confirm action") } func NewStackCommand(use string, opts ...CommandOption) *cobra.Command {