refactor

- fix tests
- better comments

Author: Taowyoo

mbedtls/src/bignum/mod.rs

@@ -760,8 +760,6 @@ impl ShrAssign<usize> for Mpi {
 
 #[cfg(test)]
 mod tests {
-    use core::str::FromStr;
-
     use super::*;
 
     #[test]
@@ -776,7 +774,10 @@ mod tests {
         assert_eq!(mpi2.less_than_const_time(&mpi1), Ok(false));
 
         // Check: function returns `Error::MpiBadInputData` if the allocated length of the two input Mpis is not the same.
-        let mpi3 = Mpi::from_str("0xdddddddddddddddddddddddddddddddd").unwrap();
+        let mpi3 = Mpi::from_binary(&[
+            0xdd, 0xdd, 0xdd, 0xdd, 0xdd, 0xdd, 0xdd, 0xdd, 0xdd, 0xdd, 0xdd, 0xdd, 0xdd, 0xdd,
+        ])
+        .unwrap();
         assert_eq!(mpi3.less_than_const_time(&mpi3), Ok(false));
         assert_eq!(mpi2.less_than_const_time(&mpi3), Err(Error::MpiBadInputData));
     }

mbedtls/src/ecp/mod.rs

@@ -369,8 +369,8 @@ Please use `mul_with_rng` instead."
     ///
     /// This function will return an error if:
     ///
-    /// * `k` is not a valid private key, determined by mbedtls function [`mbedtls_ecp_check_privkey`]
-    /// * `self` is not a valid public key, determined by mbedtls function [`mbedtls_ecp_check_pubkey`]
+    /// * The scalar `k` is not valid as a private key, determined by mbedtls function [`mbedtls_ecp_check_privkey`].
+    /// * The point `self` is not valid as a public key, determined by mbedtls function [`mbedtls_ecp_check_pubkey`].
     /// * Memory allocation fails.
     /// * Any other kind of failure occurs during the execution of the underlying [`mbedtls_ecp_mul`] function.
     ///