-
Notifications
You must be signed in to change notification settings - Fork 3
Description
It's usually best practice to release code that works on both the old and new version of PHP that we are upgrading to. That said, since Composer 2, platform_check.php has always been generated. While this is good to have on locals AND CI, we don't want it to bring down production while we do an upgrade on hosts like acquia/siteground etc. Furthermore, the CLI PHP version may be different than the Website PHP version. WHile this may cause soem libraries to not work 100%, most times, the majority of actions will. We want that more graceful failure than the heavy handed platform check. Consider looking at https://php.watch/articles/composer-platform-check and adding composer-min-autoload to php-build script building out the artifact, or at least running composer config platform-check false during artifact build.