Boolean packed incorrectly by JSON packer

[JSCU-CNI]

flow.record.fieldtypes.boolean does not identify itself as a boolean value, which results in incorrect JSON encoding in the JSON packer (and by proxy the Elastic adapter).

>>> from flow.record.fieldtypes import boolean
>>> foo = boolean(1)
>>> isinstance(foo, bool)
False
>>> isinstance(foo, int)
True

Perhaps this can be fixed with a metaclass __instancecheck__ method?

[yunzheng]

Not sure if it's possible to get isinstance(x, bool) -> True, even with __instancecheck__.

Do you have an example where our JSONPacker results in incorrect JSON encoding of our boolean type?

I see there is a regression test called test_record_pack_bool_regression that should catch this.

[JSCU-CNI]

Not sure if it's possible to get isinstance(x, bool) -> True, even with instancecheck.

Agreed, this is a bad simplified example.

Do you have an example where our JSONPacker results in incorrect JSON encoding of our boolean type?

I see there is a regression test called test_record_pack_bool_regression that should catch this.

That test indeed tests boolean conversion when initialized with a record. However this issue occurs when the packer is initialized with an ordered dict (see #205 for an example).